Page MenuHomeFreeBSD
Differential D49155

arm64/vmm: Don't load on Ampere eMAG
ClosedPublic
Actions

Authored by andrew on Feb 27 2025, 9:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 1:57 AM
Unknown Object (File)
Sat, Oct 11, 7:00 PM
Unknown Object (File)
Thu, Oct 2, 4:05 PM
Unknown Object (File)
Wed, Oct 1, 3:48 AM
Unknown Object (File)
Wed, Oct 1, 2:26 AM
Unknown Object (File)
Sat, Sep 27, 7:15 AM
Unknown Object (File)
Sat, Sep 27, 1:32 AM
Unknown Object (File)
Fri, Sep 26, 3:14 PM
View All 77 Files
Subscribers
bz
emaste
imp

Details

Reviewers
dch
tuexen
manu
Group Reviewers
arm64
Commits
rG872fc1b8de1a: arm64/vmm: Don't load on Ampere eMAG
Summary

Loading vmm.ko on Ampere eMAG locks up the system. Block loading for
now until it can be fixed.

PR: 285051
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Feb 27 2025, 9:52 AM
Herald added a reviewer: manu. · View Herald TranscriptFeb 27 2025, 9:52 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Feb 27 2025, 9:52 AM
Harbormaster completed remote builds in B62661: Diff 151567.Feb 27 2025, 9:52 AM
tuexen accepted this revision.Feb 27 2025, 10:37 AM

Is there anything I could do to help fixing the root cause?

This revision is now accepted and ready to land.Feb 27 2025, 10:37 AM
tuexen added a comment.Feb 27 2025, 10:48 AM

After approving:
I applied the patch, compiled and installed the kernel, rebooted and tried sudo kldload vmm.
The system became unresponsive. Is a buildworld needed? I thought just building kernel
includes building the kernel modules including vmm.ko...
Any idea why the above fix did not work?

andrew updated this revision to Diff 151568.Feb 27 2025, 10:54 AM

Use the correct CPU Implementer ID

This revision now requires review to proceed.Feb 27 2025, 10:54 AM
Harbormaster completed remote builds in B62662: Diff 151568.Feb 27 2025, 10:54 AM
tuexen added a comment.Feb 27 2025, 12:21 PM

Tested again:
sudo kldload vmm
does NOT lock up the system anymore.
/var/log/messages
contains
vgic0: <Virtual GIC v3> on gic0
module_register_init: MOD_LOAD (vmm, 0xffff0002a5298574, 0) error 6
vgic0: detached
as expected.
What is unexpected for me is that after sudo kldload vmm,
kldstat reports vmm.ko as being loaded.
sudo kldunload vmm
succeeds. Is it expected, that vmm.ko is reported as loaded even though loading
of it fails?

andrew added a comment.Feb 27 2025, 1:55 PM

From a quick look at kldload handling in the kernel it appears that is the expected behaviour.

tuexen accepted this revision.Feb 27 2025, 3:03 PM
In D49155#1121141, @andrew wrote:

From a quick look at kldload handling in the kernel it appears that is the expected behaviour.

OK.

This revision is now accepted and ready to land.Feb 27 2025, 3:03 PM
bz added a subscriber: bz.Feb 27 2025, 8:31 PM
bz added inline comments.
sys/arm64/vmm/vmm.c
317

I think the comment is misleading if it's a hard freeze for the machine.

Closed by commit rG872fc1b8de1a: arm64/vmm: Don't load on Ampere eMAG (authored by andrew). · Explain WhyMar 27 2025, 1:48 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG872fc1b8de1a: arm64/vmm: Don't load on Ampere eMAG.

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
17 lines

Diff 152739

View Options

sys/arm64/vmm/vmm.c

Loading...