Page MenuHomeFreeBSD
Differential D49155

arm64/vmm: Don't load on Ampere eMAG
AcceptedPublic
Actions

Authored by andrew on Thu, Feb 27, 9:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 11:42 PM
Unknown Object (File)
Thu, Mar 6, 10:02 PM
Unknown Object (File)
Thu, Mar 6, 8:58 PM
Unknown Object (File)
Thu, Mar 6, 5:59 PM
Unknown Object (File)
Thu, Mar 6, 5:24 PM
Unknown Object (File)
Thu, Mar 6, 2:58 PM
Unknown Object (File)
Mon, Mar 3, 9:39 PM
Unknown Object (File)
Fri, Feb 28, 4:22 PM
View All 13 Files
Subscribers
bz
emaste
imp

Details

Reviewers
dch
tuexen
manu
Group Reviewers
arm64
Summary

Loading vmm.ko on Ampere eMAG locks up the system. Block loading for
now until it can be fixed.

PR: 285051
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62662
Build 59546: arc lint + arc unit

Event Timeline

andrew created this revision.Thu, Feb 27, 9:52 AM
Herald added a reviewer: manu. · View Herald TranscriptThu, Feb 27, 9:52 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Thu, Feb 27, 9:52 AM
Harbormaster completed remote builds in B62661: Diff 151567.Thu, Feb 27, 9:52 AM
tuexen accepted this revision.Thu, Feb 27, 10:37 AM

Is there anything I could do to help fixing the root cause?

This revision is now accepted and ready to land.Thu, Feb 27, 10:37 AM
tuexen added a comment.Thu, Feb 27, 10:48 AM

After approving:
I applied the patch, compiled and installed the kernel, rebooted and tried sudo kldload vmm.
The system became unresponsive. Is a buildworld needed? I thought just building kernel
includes building the kernel modules including vmm.ko...
Any idea why the above fix did not work?

andrew updated this revision to Diff 151568.Thu, Feb 27, 10:54 AM

Use the correct CPU Implementer ID

This revision now requires review to proceed.Thu, Feb 27, 10:54 AM
Harbormaster completed remote builds in B62662: Diff 151568.Thu, Feb 27, 10:54 AM
tuexen added a comment.Thu, Feb 27, 12:21 PM

Tested again:
sudo kldload vmm
does NOT lock up the system anymore.
/var/log/messages
contains
vgic0: <Virtual GIC v3> on gic0
module_register_init: MOD_LOAD (vmm, 0xffff0002a5298574, 0) error 6
vgic0: detached
as expected.
What is unexpected for me is that after sudo kldload vmm,
kldstat reports vmm.ko as being loaded.
sudo kldunload vmm
succeeds. Is it expected, that vmm.ko is reported as loaded even though loading
of it fails?

andrew added a comment.Thu, Feb 27, 1:55 PM

From a quick look at kldload handling in the kernel it appears that is the expected behaviour.

tuexen accepted this revision.Thu, Feb 27, 3:03 PM
In D49155#1121141, @andrew wrote:

From a quick look at kldload handling in the kernel it appears that is the expected behaviour.

OK.

This revision is now accepted and ready to land.Thu, Feb 27, 3:03 PM
bz added a subscriber: bz.Thu, Feb 27, 8:31 PM
bz added inline comments.
sys/arm64/vmm/vmm.c
317

I think the comment is misleading if it's a hard freeze for the machine.

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
17 lines

Diff 151568

View Options

sys/arm64/vmm/vmm.c

Loading...