Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (343 w, 1 d)

Recent Activity

Wed, Oct 15

mhorne accepted D46139: libc: scalar memcpy() in RISC-V assembly.
Wed, Oct 15, 4:28 PM
mhorne accepted D46230: libc: scalar strnlen() in RISC-V assembly.

Yes, please go ahead!

Wed, Oct 15, 4:27 PM
mhorne added a comment to D53119: uart: provide and use default rclk for JH7110 UART.

The logic for removing this in the FDT is that, on Linux, the clock framework comes up early enough (or at least some early part of it) in order to be able to query the UART clock's frequency from the clock driver, whereas we don't do anything like that with clocks prior to newbus passes, so way too late for cninit.

Wed, Oct 15, 3:49 PM
mhorne requested review of D53118: riscv: build allwinner DTBs.
Wed, Oct 15, 3:14 PM
mhorne requested review of D53119: uart: provide and use default rclk for JH7110 UART.
Wed, Oct 15, 3:14 PM
mhorne requested review of D53117: riscv: build starfive JH7110 DTBs.
Wed, Oct 15, 3:14 PM
mhorne requested review of D53116: dtb: sort by vendor on riscv.
Wed, Oct 15, 3:14 PM

Mon, Sep 29

mhorne committed rG6cd33535a5f3: MODULE_PNP_INFO.9: tweak list indent (authored by mhorne).
MODULE_PNP_INFO.9: tweak list indent
Mon, Sep 29, 1:51 PM
mhorne committed rG75f1a35ce445: if_re: Add PNP info for module (authored by mhorne).
if_re: Add PNP info for module
Mon, Sep 29, 1:51 PM
mhorne committed rG16de4bc01135: MODULE_PNP_INFO.9: tweak list indent (authored by mhorne).
MODULE_PNP_INFO.9: tweak list indent
Mon, Sep 29, 1:50 PM
mhorne committed rGf54dfda721ef: if_re: Add PNP info for module (authored by mhorne).
if_re: Add PNP info for module
Mon, Sep 29, 1:50 PM

Sep 16 2025

mhorne updated the summary of D52585: man4: move allwinner pages to standard place.
Sep 16 2025, 8:17 PM
mhorne updated the diff for D52585: man4: move allwinner pages to standard place.

Fix aw_spi.4

Sep 16 2025, 8:16 PM
mhorne requested review of D52586: aw_mmc.4: add D1 compatible.
Sep 16 2025, 8:14 PM
mhorne requested review of D52585: man4: move allwinner pages to standard place.
Sep 16 2025, 8:14 PM
mhorne requested review of D52584: modules: enable allwinner modules on riscv, arm.
Sep 16 2025, 8:14 PM
mhorne added a comment to D51134: sys: harmonize FDT/DTS include paths.

This prompted a secondary question of whether the x86 FDT experiment bits can be removed outright (sys/x86/x86/fdt_machdep.c).

Sep 16 2025, 7:48 PM
mhorne added reviewers for D51134: sys: harmonize FDT/DTS include paths: emaste, imp, manu.
Sep 16 2025, 7:45 PM
mhorne committed rGa7340d559ee9: MODULE_PNP_INFO.9: tweak list indent (authored by mhorne).
MODULE_PNP_INFO.9: tweak list indent
Sep 16 2025, 2:11 PM
mhorne committed rGe13b5298ec87: if_re: Add PNP info for module (authored by mhorne).
if_re: Add PNP info for module
Sep 16 2025, 1:22 PM
mhorne closed D52557: if_re: Add PNP info for module.
Sep 16 2025, 1:22 PM

Sep 15 2025

mhorne updated the summary of D52557: if_re: Add PNP info for module.
Sep 15 2025, 7:42 PM
mhorne requested review of D52557: if_re: Add PNP info for module.
Sep 15 2025, 7:39 PM
mhorne committed rG850182848dad: riscv: Fix SSTC extension support (authored by br).
riscv: Fix SSTC extension support
Sep 15 2025, 7:35 PM
mhorne committed rG8302f09d844c: riscv timer: fix interrupt handling. (authored by br).
riscv timer: fix interrupt handling.
Sep 15 2025, 7:35 PM
mhorne committed rG31eaa0141c49: riscv timer: fix interrupt handling. (authored by br).
riscv timer: fix interrupt handling.
Sep 15 2025, 7:22 PM
mhorne committed rG4efc1b22aab1: riscv: Fix SSTC extension support (authored by br).
riscv: Fix SSTC extension support
Sep 15 2025, 7:22 PM

Aug 20 2025

mhorne committed rGc0771d8c78b4: jh7110_pcie.c: add empty PIC methods to conform conventions (authored by jsihv_gmx.com).
jh7110_pcie.c: add empty PIC methods to conform conventions
Aug 20 2025, 6:12 PM
mhorne closed D52042: jh7110_pcie.c: add empty pic methods to conform conventions.
Aug 20 2025, 6:11 PM
mhorne added a comment to D52035: riscv: Provide prototypes for fpgetmask/fpsetmask.

You can use Fixes: 7393b267c6ce ("libc: Provide sub fp(s|g)etmask() implementations for RISC-V") in the commit message.

Aug 20 2025, 5:06 PM
mhorne accepted D52035: riscv: Provide prototypes for fpgetmask/fpsetmask.
Aug 20 2025, 5:05 PM
mhorne accepted D52042: jh7110_pcie.c: add empty pic methods to conform conventions.
Aug 20 2025, 3:23 PM

Aug 19 2025

mhorne added inline comments to D45730: libc: scalar memset() in RISC-V assembly.
Aug 19 2025, 7:01 PM
mhorne accepted D47275: libc: scalar strrchr() in RISC-V assembly.
Aug 19 2025, 7:00 PM
mhorne added inline comments to D46230: libc: scalar strnlen() in RISC-V assembly.
Aug 19 2025, 6:58 PM
mhorne requested changes to D46230: libc: scalar strnlen() in RISC-V assembly.
Aug 19 2025, 6:52 PM
mhorne added a comment to D46139: libc: scalar memcpy() in RISC-V assembly.

No objection from me on this one; @fuz your comments don't seem to be blockers, just possible refinements?

Aug 19 2025, 6:50 PM
mhorne accepted D46023: libc: scalar memchr() in RISC-V assembly.
Aug 19 2025, 6:47 PM

Aug 9 2025

mhorne committed rG60fce0e22147: busdma: another fix for small bounce transfers (authored by mhorne).
busdma: another fix for small bounce transfers
Aug 9 2025, 6:43 PM
mhorne closed D47807: WIP/RFC: another busdma fix for small bounce transfers.
Aug 9 2025, 6:43 PM
mhorne added a comment to D47807: WIP/RFC: another busdma fix for small bounce transfers.
In D47807#1182659, @jhb wrote:

I'm trying to think of a case when the roundup would ever be correct. That is, there are two cases after the previous expression:

		sgsize = MIN(buflen, PAGE_SIZE - (curaddr & PAGE_MASK));

Either 1) sgsize == buflen, or 2) sgsize == PAGE_SIZE - (curaddr & PAGE_MASK)

Your patch turns case 1) into a no-op as it effectively undoes the roundup. Case 2) seems worse though. This means that we can now expand the S/G entry *off the end of the page* and randomly read/write data on the next physical page of RAM. There is no way that is correct. I wonder if this was meant to be a rounddown to keep segments a multiple of the alignment instead of a roundup? However, in that case you'd never finish a buffer whose size wasn't a multiple of the alignment.

Aha! See this part of the commit log from daf6545e6158f:

Now all contiguous regions returned from bus-dma will be aligned to the
alignment constraint and all but the last region are guaranteed to be
a multiple of the alignment in length.

I think if that is the desired behavior, then the correct fix instead is to replace the roundup2 line with this:

if (sgsize != buflen)
    sgsize = rounddown2(sgsize, dmat->common.alignment);

That will give the desired property. It should never have been a roundup2().

Aug 9 2025, 6:33 PM

Aug 7 2025

mhorne committed rG7d955e02b1d8: jh7110_pcie: Add StarFive JH7110 PCIe controller driver (authored by jsihv_gmx.com).
jh7110_pcie: Add StarFive JH7110 PCIe controller driver
Aug 7 2025, 11:15 PM
mhorne committed rG5bae2ace2e55: jh7110_gpio: Add StarFive JH7110 GPIO controller driver (authored by jsihv_gmx.com).
jh7110_gpio: Add StarFive JH7110 GPIO controller driver
Aug 7 2025, 11:15 PM
mhorne closed D47919: Add StarFive JH7110's PCIE controller driver.
Aug 7 2025, 11:15 PM
mhorne closed D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.
Aug 7 2025, 11:14 PM

Aug 6 2025

mhorne added a comment to D47919: Add StarFive JH7110's PCIE controller driver.

I've built and booted the driver.

Aug 6 2025, 8:12 PM
mhorne added a comment to D47807: WIP/RFC: another busdma fix for small bounce transfers.

I'm sorry for the delayed follow-up. I'm trying to understand the purpose of the roundup. It appears to have been introduced by commit daf6545e6158f; the implication seems to be that some drivers depend on the property that "the relative alignment of two consecutive bytes in the I/O stream have a difference of 1 even if they are not physically contiguous."

I don't really understand why that property is important, but assuming so, I think your patch is probably the right thing to do.

Aug 6 2025, 6:37 PM
mhorne added inline comments to D51755: kern: fix incorrect format in device_if.m.
Aug 6 2025, 3:43 PM

Jul 30 2025

mhorne added inline comments to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..
Jul 30 2025, 3:57 PM
mhorne added a comment to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..

Seems fine to me, with a couple tweaks needed.

Jul 30 2025, 3:52 PM
mhorne accepted D47919: Add StarFive JH7110's PCIE controller driver.

Looks good to me, with some small nitpicks.

Jul 30 2025, 3:19 PM

Jul 23 2025

mhorne added a reviewer for D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models.: arm64.
Jul 23 2025, 3:46 PM

Jul 22 2025

mhorne accepted D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.
Jul 22 2025, 6:21 PM
mhorne added a comment to D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

This small update includes the proposed smaller changes.

Your larger proposition looks like a straightforward application of a generic structure from other GPIO drivers, so if you like to add it by yourself, just go ahead. I considered writing just the same thing by myself (mostly after the example of SiFive's gpio driver) but I didn't understand why those data structures would be needed for this particular driver.

Jul 22 2025, 6:21 PM
mhorne committed rG4113280f7547: aw_mmc: changes for Allwinner D1 (authored by julien.cassette_gmail.com).
aw_mmc: changes for Allwinner D1
Jul 22 2025, 3:09 PM
mhorne committed rG09fb6eb4a4af: riscv: enable aw_mmc driver (authored by mhorne).
riscv: enable aw_mmc driver
Jul 22 2025, 3:09 PM
mhorne closed D51198: riscv: enable aw_mmc driver.
Jul 22 2025, 3:09 PM
mhorne closed D51197: aw_mmc: changes for Allwinner D1 (riscv).
Jul 22 2025, 3:08 PM
mhorne accepted D50946: style.mdoc.5: xref mdoc extended documentation.
Jul 22 2025, 2:41 PM

Jul 11 2025

mhorne added a comment to D51262: HW Relnotes: Move uaudio to Sound.
  1. I only have amd64, but when I looked into this, we do have quite a few things that actually are only for certain architectures. One of my aspirations is definitely to clean that up, they should be moved to their respective man4/man4.*/ directories and have their .Dt's fixed.
Jul 11 2025, 7:57 PM
mhorne added a comment to D51264: man4: Use arch specifier of Dt consistently.

I am happy with the idea of making this consistent across man/man4.$arch.

Jul 11 2025, 7:31 PM
mhorne added inline comments to D50795: gpioctl.8: Document pin operand.
Jul 11 2025, 7:14 PM
mhorne requested changes to D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

Thanks for the update. Despite my many absences in the past, we should be able to move quickly on this and get it merged.

Jul 11 2025, 7:06 PM
mhorne created P663 WIP JH7110 GPIO improvements.
Jul 11 2025, 6:38 PM
mhorne accepted D51262: HW Relnotes: Move uaudio to Sound.

Two thoughts beyond the scope of this change:

  1. Should we provide uaudio(4) as a legitimate link to the page? The answer might be no.
Jul 11 2025, 4:42 PM
mhorne added a comment to D51258: modules/dtb: Add the ARM dtb module.

Do you intend to enable it in the build for some config? Maybe in std.arm?

Jul 11 2025, 4:35 PM
mhorne accepted D51261: ifconfig.8: remove accept_rev_ethip_ver/send_rev_ethip_ver.
Jul 11 2025, 4:27 PM
mhorne added a member for manpages: mhorne.
Jul 11 2025, 4:26 PM

Jul 7 2025

mhorne requested review of D51198: riscv: enable aw_mmc driver.
Jul 7 2025, 8:23 PM
mhorne requested review of D51197: aw_mmc: changes for Allwinner D1 (riscv).
Jul 7 2025, 8:23 PM

Jul 4 2025

mhorne committed rG5fea0aec5c8e: riscv: add aw_rtc device to config (authored by mhorne).
riscv: add aw_rtc device to config
Jul 4 2025, 4:27 PM
mhorne committed rGdeaae83da057: riscv: enable allwinner RTC (authored by mhorne).
riscv: enable allwinner RTC
Jul 4 2025, 4:00 PM
mhorne closed D50369: riscv: enable allwinner RTC.
Jul 4 2025, 4:00 PM

Jul 2 2025

mhorne added inline comments to D51134: sys: harmonize FDT/DTS include paths.
Jul 2 2025, 8:03 PM
mhorne updated the test plan for D51134: sys: harmonize FDT/DTS include paths.
Jul 2 2025, 7:54 PM
mhorne requested review of D51134: sys: harmonize FDT/DTS include paths.
Jul 2 2025, 7:52 PM
mhorne added a comment to D50369: riscv: enable allwinner RTC.

I am back after some time away. I plan to commit this soon, so, last chance to look :)

Jul 2 2025, 7:22 PM
mhorne committed R11:8e0b9063b872: sysutils/opensbi: update to v1.7 (authored by mhorne).
sysutils/opensbi: update to v1.7
Jul 2 2025, 4:29 PM

Jun 27 2025

mhorne updated the test plan for D51076: gone_in(9): update man page.
Jun 27 2025, 6:32 PM
mhorne requested review of D51076: gone_in(9): update man page.
Jun 27 2025, 6:26 PM

Jun 2 2025

mhorne accepted D50545: mlx.4: Improve specificity for apropos + hw notes.

Seems fine to me, but I am not an authority on the subject matter.

Jun 2 2025, 6:41 PM
mhorne accepted D50608: uftdi.4: Makeover!.
Jun 2 2025, 6:37 PM

May 28 2025

mhorne accepted D50525: HW Relnotes: Improve gve.
May 28 2025, 6:13 PM
mhorne accepted D50526: HW Relnotes: Remove traces of sio(4).

Please check the commit description before pushing.

May 28 2025, 6:11 PM
mhorne accepted D50522: HW Relnotes: Remove traces of cy, rc, rp drivers.
May 28 2025, 6:10 PM
mhorne accepted D50527: HW Relnotes: Remove traces of ar(4).
May 28 2025, 6:09 PM
mhorne accepted D50541: cdce.4: Improve HARDWARE.

Looks good, I am unfamiliar with the content/purpose here, so trusting your fact-checking.

May 28 2025, 6:06 PM
mhorne accepted D50374: usb/if_mos.c: Fix incorrect SPDX ID.
May 28 2025, 5:59 PM
mhorne accepted D50540: aue.4: Improve HARDWARE, specificity, and tag spdx.
May 28 2025, 5:58 PM
mhorne accepted D50529: rtsx.4: Improve hardware, add history and spdx.
May 28 2025, 5:57 PM
mhorne accepted D50528: scc.4: Improve acronyms + tag SPDX.
May 28 2025, 5:56 PM
mhorne accepted D50440: pam_xdg.8: Improve usage and standards.
May 28 2025, 5:55 PM
mhorne accepted D50523: axge.4: Create a HARDWARE section.
May 28 2025, 5:52 PM

May 20 2025

mhorne added a comment to D48401: bhyvectl.8: Polish.

Approved, please go ahead and commit this.

May 20 2025, 3:36 PM

May 18 2025

mhorne added a comment to D50410: style.mdoc: Ask for maintainable wrapping.

Oh spare me your wounded pride and perceived victimhood.

May 18 2025, 7:54 PM
mhorne added a comment to D48401: bhyvectl.8: Polish.

The subject of line-breaks is infinitely bikesheddable, so I will state my opinion here once more and then never again.

May 18 2025, 4:16 PM
mhorne added a reviewer for D50403: HW Relnotes: Add remaining Cryptographic Accelerators: markj.
May 18 2025, 3:51 PM
mhorne added a comment to D50402: HW Relnotes: Add safexcel to Cryptographic Accelerators.

So, should it also be expanded/applied to the various hardware notes in this commit (not just the template)?

May 18 2025, 3:42 PM

May 17 2025

mhorne accepted D50395: HW Relnotes: Add qat to Cryptographic Accelerators.
May 17 2025, 9:02 PM

May 16 2025

mhorne accepted D50381: qat.4: Cleanup.
May 16 2025, 8:33 PM