Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (344 w, 1 d)

Recent Activity

Thu, Oct 23

mhorne committed rG8691e93a458e: modules/allwinner: add nvmem_if.h to SRCS (authored by mhorne).
modules/allwinner: add nvmem_if.h to SRCS
Thu, Oct 23, 6:38 PM
mhorne committed rG84ca93c355e7: aw_mmc.4: add D1 compatible (authored by mhorne).
aw_mmc.4: add D1 compatible
Thu, Oct 23, 6:38 PM
mhorne committed rGcd7c8ba03b26: modules: fix some riscv module logic (authored by mhorne).
modules: fix some riscv module logic
Thu, Oct 23, 6:38 PM
mhorne committed rG898aea3d847c: arm: tweak imx module build logic (authored by mhorne).
arm: tweak imx module build logic
Thu, Oct 23, 6:38 PM
mhorne committed rG7b5e4e5e35a5: modules: enable allwinner kmods on riscv (authored by mhorne).
modules: enable allwinner kmods on riscv
Thu, Oct 23, 6:38 PM
mhorne committed rG58f613b3026d: man4: move allwinner pages and logic to a standard place (authored by mhorne).
man4: move allwinner pages and logic to a standard place
Thu, Oct 23, 6:38 PM
mhorne added a comment to D53119: uart: provide and use default rclk for JH7110 UART.

@imp any objection?

Thu, Oct 23, 6:25 PM
mhorne committed rG2257adb848d0: riscv: build starfive JH7110 DTBs (authored by mhorne).
riscv: build starfive JH7110 DTBs
Thu, Oct 23, 6:21 PM
mhorne committed rG9a44b569071d: riscv: build allwinner DTBs (authored by mhorne).
riscv: build allwinner DTBs
Thu, Oct 23, 6:21 PM
mhorne committed rG0cc2448fc2a2: dtb: sort by vendor on riscv (authored by mhorne).
dtb: sort by vendor on riscv
Thu, Oct 23, 6:21 PM
mhorne added a comment to D53287: dwcotg.4: Initial stub manual.

I have not succeeded in using this myself, but I have never tried too hard.

Thu, Oct 23, 6:17 PM

Wed, Oct 22

mhorne committed rGfe7954d723f8: modules/allwinner: add nvmem_if.h to SRCS (authored by mhorne).
modules/allwinner: add nvmem_if.h to SRCS
Wed, Oct 22, 2:36 PM

Tue, Oct 21

mhorne accepted D46047: libc: scalar strchrnul() in RISC-V assembly.
Tue, Oct 21, 7:18 PM
mhorne accepted D47275: libc: scalar strrchr() in RISC-V assembly.
Tue, Oct 21, 7:16 PM

Mon, Oct 20

mhorne abandoned D52584: modules: enable allwinner modules on riscv, arm.

Committed. Forgot the DR tag.

Mon, Oct 20, 11:47 PM
mhorne committed rGf34e152e025e: ti_clkctrl.c: fix paths in comment (authored by mhorne).
ti_clkctrl.c: fix paths in comment
Mon, Oct 20, 11:44 PM
mhorne committed rG15c79c6fa608: man4: move allwinner pages and logic to a standard place (authored by mhorne).
man4: move allwinner pages and logic to a standard place
Mon, Oct 20, 11:43 PM
mhorne committed rG67bc0e34594d: aw_mmc.4: add D1 compatible (authored by mhorne).
aw_mmc.4: add D1 compatible
Mon, Oct 20, 11:43 PM
mhorne committed rGddc1d4b0722b: modules: fix some riscv module logic (authored by mhorne).
modules: fix some riscv module logic
Mon, Oct 20, 11:43 PM
mhorne committed rG5aefe9f16f24: arm: tweak imx module build logic (authored by mhorne).
arm: tweak imx module build logic
Mon, Oct 20, 11:43 PM
mhorne committed rG5522519731b7: modules: enable allwinner kmods on riscv (authored by mhorne).
modules: enable allwinner kmods on riscv
Mon, Oct 20, 11:43 PM
mhorne committed rG3ed48eb085f7: riscv: build allwinner DTBs (authored by mhorne).
riscv: build allwinner DTBs
Mon, Oct 20, 11:42 PM
mhorne closed D52585: man4: move allwinner pages to standard place.
Mon, Oct 20, 11:42 PM
mhorne committed rG96b137c044d8: riscv: build starfive JH7110 DTBs (authored by mhorne).
riscv: build starfive JH7110 DTBs
Mon, Oct 20, 11:42 PM
mhorne closed D52586: aw_mmc.4: add D1 compatible.
Mon, Oct 20, 11:42 PM
mhorne closed D53118: riscv: build allwinner DTBs.
Mon, Oct 20, 11:42 PM
mhorne committed rGcf202819af23: dtb: sort by vendor on riscv (authored by mhorne).
dtb: sort by vendor on riscv
Mon, Oct 20, 11:42 PM
mhorne closed D53117: riscv: build starfive JH7110 DTBs.
Mon, Oct 20, 11:42 PM
mhorne closed D53116: dtb: sort by vendor on riscv.
Mon, Oct 20, 11:42 PM
mhorne accepted D51258: modules/dtb: Add the ARM dtb module.
Mon, Oct 20, 7:20 PM

Wed, Oct 15

mhorne accepted D46139: libc: scalar memcpy() in RISC-V assembly.
Wed, Oct 15, 4:28 PM
mhorne accepted D46230: libc: scalar strnlen() in RISC-V assembly.

Yes, please go ahead!

Wed, Oct 15, 4:27 PM
mhorne added a comment to D53119: uart: provide and use default rclk for JH7110 UART.

The logic for removing this in the FDT is that, on Linux, the clock framework comes up early enough (or at least some early part of it) in order to be able to query the UART clock's frequency from the clock driver, whereas we don't do anything like that with clocks prior to newbus passes, so way too late for cninit.

Wed, Oct 15, 3:49 PM
mhorne requested review of D53118: riscv: build allwinner DTBs.
Wed, Oct 15, 3:14 PM
mhorne requested review of D53119: uart: provide and use default rclk for JH7110 UART.
Wed, Oct 15, 3:14 PM
mhorne requested review of D53117: riscv: build starfive JH7110 DTBs.
Wed, Oct 15, 3:14 PM
mhorne requested review of D53116: dtb: sort by vendor on riscv.
Wed, Oct 15, 3:14 PM

Mon, Sep 29

mhorne committed rG6cd33535a5f3: MODULE_PNP_INFO.9: tweak list indent (authored by mhorne).
MODULE_PNP_INFO.9: tweak list indent
Mon, Sep 29, 1:51 PM
mhorne committed rG75f1a35ce445: if_re: Add PNP info for module (authored by mhorne).
if_re: Add PNP info for module
Mon, Sep 29, 1:51 PM
mhorne committed rG16de4bc01135: MODULE_PNP_INFO.9: tweak list indent (authored by mhorne).
MODULE_PNP_INFO.9: tweak list indent
Mon, Sep 29, 1:50 PM
mhorne committed rGf54dfda721ef: if_re: Add PNP info for module (authored by mhorne).
if_re: Add PNP info for module
Mon, Sep 29, 1:50 PM

Sep 16 2025

mhorne updated the summary of D52585: man4: move allwinner pages to standard place.
Sep 16 2025, 8:17 PM
mhorne updated the diff for D52585: man4: move allwinner pages to standard place.

Fix aw_spi.4

Sep 16 2025, 8:16 PM
mhorne requested review of D52586: aw_mmc.4: add D1 compatible.
Sep 16 2025, 8:14 PM
mhorne requested review of D52585: man4: move allwinner pages to standard place.
Sep 16 2025, 8:14 PM
mhorne requested review of D52584: modules: enable allwinner modules on riscv, arm.
Sep 16 2025, 8:14 PM
mhorne added a comment to D51134: sys: harmonize FDT/DTS include paths.

This prompted a secondary question of whether the x86 FDT experiment bits can be removed outright (sys/x86/x86/fdt_machdep.c).

Sep 16 2025, 7:48 PM
mhorne added reviewers for D51134: sys: harmonize FDT/DTS include paths: emaste, imp, manu.
Sep 16 2025, 7:45 PM
mhorne committed rGa7340d559ee9: MODULE_PNP_INFO.9: tweak list indent (authored by mhorne).
MODULE_PNP_INFO.9: tweak list indent
Sep 16 2025, 2:11 PM
mhorne committed rGe13b5298ec87: if_re: Add PNP info for module (authored by mhorne).
if_re: Add PNP info for module
Sep 16 2025, 1:22 PM
mhorne closed D52557: if_re: Add PNP info for module.
Sep 16 2025, 1:22 PM

Sep 15 2025

mhorne updated the summary of D52557: if_re: Add PNP info for module.
Sep 15 2025, 7:42 PM
mhorne requested review of D52557: if_re: Add PNP info for module.
Sep 15 2025, 7:39 PM
mhorne committed rG850182848dad: riscv: Fix SSTC extension support (authored by br).
riscv: Fix SSTC extension support
Sep 15 2025, 7:35 PM
mhorne committed rG8302f09d844c: riscv timer: fix interrupt handling. (authored by br).
riscv timer: fix interrupt handling.
Sep 15 2025, 7:35 PM
mhorne committed rG31eaa0141c49: riscv timer: fix interrupt handling. (authored by br).
riscv timer: fix interrupt handling.
Sep 15 2025, 7:22 PM
mhorne committed rG4efc1b22aab1: riscv: Fix SSTC extension support (authored by br).
riscv: Fix SSTC extension support
Sep 15 2025, 7:22 PM

Aug 20 2025

mhorne committed rGc0771d8c78b4: jh7110_pcie.c: add empty PIC methods to conform conventions (authored by jsihv_gmx.com).
jh7110_pcie.c: add empty PIC methods to conform conventions
Aug 20 2025, 6:12 PM
mhorne closed D52042: jh7110_pcie.c: add empty pic methods to conform conventions.
Aug 20 2025, 6:11 PM
mhorne added a comment to D52035: riscv: Provide prototypes for fpgetmask/fpsetmask.

You can use Fixes: 7393b267c6ce ("libc: Provide sub fp(s|g)etmask() implementations for RISC-V") in the commit message.

Aug 20 2025, 5:06 PM
mhorne accepted D52035: riscv: Provide prototypes for fpgetmask/fpsetmask.
Aug 20 2025, 5:05 PM
mhorne accepted D52042: jh7110_pcie.c: add empty pic methods to conform conventions.
Aug 20 2025, 3:23 PM

Aug 19 2025

mhorne added inline comments to D45730: libc: scalar memset() in RISC-V assembly.
Aug 19 2025, 7:01 PM
mhorne accepted D47275: libc: scalar strrchr() in RISC-V assembly.
Aug 19 2025, 7:00 PM
mhorne added inline comments to D46230: libc: scalar strnlen() in RISC-V assembly.
Aug 19 2025, 6:58 PM
mhorne requested changes to D46230: libc: scalar strnlen() in RISC-V assembly.
Aug 19 2025, 6:52 PM
mhorne added a comment to D46139: libc: scalar memcpy() in RISC-V assembly.

No objection from me on this one; @fuz your comments don't seem to be blockers, just possible refinements?

Aug 19 2025, 6:50 PM
mhorne accepted D46023: libc: scalar memchr() in RISC-V assembly.
Aug 19 2025, 6:47 PM

Aug 9 2025

mhorne committed rG60fce0e22147: busdma: another fix for small bounce transfers (authored by mhorne).
busdma: another fix for small bounce transfers
Aug 9 2025, 6:43 PM
mhorne closed D47807: WIP/RFC: another busdma fix for small bounce transfers.
Aug 9 2025, 6:43 PM
mhorne added a comment to D47807: WIP/RFC: another busdma fix for small bounce transfers.
In D47807#1182659, @jhb wrote:

I'm trying to think of a case when the roundup would ever be correct. That is, there are two cases after the previous expression:

		sgsize = MIN(buflen, PAGE_SIZE - (curaddr & PAGE_MASK));

Either 1) sgsize == buflen, or 2) sgsize == PAGE_SIZE - (curaddr & PAGE_MASK)

Your patch turns case 1) into a no-op as it effectively undoes the roundup. Case 2) seems worse though. This means that we can now expand the S/G entry *off the end of the page* and randomly read/write data on the next physical page of RAM. There is no way that is correct. I wonder if this was meant to be a rounddown to keep segments a multiple of the alignment instead of a roundup? However, in that case you'd never finish a buffer whose size wasn't a multiple of the alignment.

Aha! See this part of the commit log from daf6545e6158f:

Now all contiguous regions returned from bus-dma will be aligned to the
alignment constraint and all but the last region are guaranteed to be
a multiple of the alignment in length.

I think if that is the desired behavior, then the correct fix instead is to replace the roundup2 line with this:

if (sgsize != buflen)
    sgsize = rounddown2(sgsize, dmat->common.alignment);

That will give the desired property. It should never have been a roundup2().

Aug 9 2025, 6:33 PM

Aug 7 2025

mhorne committed rG7d955e02b1d8: jh7110_pcie: Add StarFive JH7110 PCIe controller driver (authored by jsihv_gmx.com).
jh7110_pcie: Add StarFive JH7110 PCIe controller driver
Aug 7 2025, 11:15 PM
mhorne committed rG5bae2ace2e55: jh7110_gpio: Add StarFive JH7110 GPIO controller driver (authored by jsihv_gmx.com).
jh7110_gpio: Add StarFive JH7110 GPIO controller driver
Aug 7 2025, 11:15 PM
mhorne closed D47919: Add StarFive JH7110's PCIE controller driver.
Aug 7 2025, 11:15 PM
mhorne closed D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.
Aug 7 2025, 11:14 PM

Aug 6 2025

mhorne added a comment to D47919: Add StarFive JH7110's PCIE controller driver.

I've built and booted the driver.

Aug 6 2025, 8:12 PM
mhorne added a comment to D47807: WIP/RFC: another busdma fix for small bounce transfers.

I'm sorry for the delayed follow-up. I'm trying to understand the purpose of the roundup. It appears to have been introduced by commit daf6545e6158f; the implication seems to be that some drivers depend on the property that "the relative alignment of two consecutive bytes in the I/O stream have a difference of 1 even if they are not physically contiguous."

I don't really understand why that property is important, but assuming so, I think your patch is probably the right thing to do.

Aug 6 2025, 6:37 PM
mhorne added inline comments to D51755: kern: fix incorrect format in device_if.m.
Aug 6 2025, 3:43 PM

Jul 30 2025

mhorne added inline comments to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..
Jul 30 2025, 3:57 PM
mhorne added a comment to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..

Seems fine to me, with a couple tweaks needed.

Jul 30 2025, 3:52 PM
mhorne accepted D47919: Add StarFive JH7110's PCIE controller driver.

Looks good to me, with some small nitpicks.

Jul 30 2025, 3:19 PM

Jul 23 2025

mhorne added a reviewer for D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models.: arm64.
Jul 23 2025, 3:46 PM

Jul 22 2025

mhorne accepted D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.
Jul 22 2025, 6:21 PM
mhorne added a comment to D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

This small update includes the proposed smaller changes.

Your larger proposition looks like a straightforward application of a generic structure from other GPIO drivers, so if you like to add it by yourself, just go ahead. I considered writing just the same thing by myself (mostly after the example of SiFive's gpio driver) but I didn't understand why those data structures would be needed for this particular driver.

Jul 22 2025, 6:21 PM
mhorne committed rG4113280f7547: aw_mmc: changes for Allwinner D1 (authored by julien.cassette_gmail.com).
aw_mmc: changes for Allwinner D1
Jul 22 2025, 3:09 PM
mhorne committed rG09fb6eb4a4af: riscv: enable aw_mmc driver (authored by mhorne).
riscv: enable aw_mmc driver
Jul 22 2025, 3:09 PM
mhorne closed D51198: riscv: enable aw_mmc driver.
Jul 22 2025, 3:09 PM
mhorne closed D51197: aw_mmc: changes for Allwinner D1 (riscv).
Jul 22 2025, 3:08 PM
mhorne accepted D50946: style.mdoc.5: xref mdoc extended documentation.
Jul 22 2025, 2:41 PM

Jul 11 2025

mhorne added a comment to D51262: HW Relnotes: Move uaudio to Sound.
  1. I only have amd64, but when I looked into this, we do have quite a few things that actually are only for certain architectures. One of my aspirations is definitely to clean that up, they should be moved to their respective man4/man4.*/ directories and have their .Dt's fixed.
Jul 11 2025, 7:57 PM
mhorne added a comment to D51264: man4: Use arch specifier of Dt consistently.

I am happy with the idea of making this consistent across man/man4.$arch.

Jul 11 2025, 7:31 PM
mhorne added inline comments to D50795: gpioctl.8: Document pin operand.
Jul 11 2025, 7:14 PM
mhorne requested changes to D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

Thanks for the update. Despite my many absences in the past, we should be able to move quickly on this and get it merged.

Jul 11 2025, 7:06 PM
mhorne created P663 WIP JH7110 GPIO improvements.
Jul 11 2025, 6:38 PM
mhorne accepted D51262: HW Relnotes: Move uaudio to Sound.

Two thoughts beyond the scope of this change:

  1. Should we provide uaudio(4) as a legitimate link to the page? The answer might be no.
Jul 11 2025, 4:42 PM
mhorne added a comment to D51258: modules/dtb: Add the ARM dtb module.

Do you intend to enable it in the build for some config? Maybe in std.arm?

Jul 11 2025, 4:35 PM
mhorne accepted D51261: ifconfig.8: remove accept_rev_ethip_ver/send_rev_ethip_ver.
Jul 11 2025, 4:27 PM
mhorne added a member for manpages: mhorne.
Jul 11 2025, 4:26 PM

Jul 7 2025

mhorne requested review of D51198: riscv: enable aw_mmc driver.
Jul 7 2025, 8:23 PM
mhorne requested review of D51197: aw_mmc: changes for Allwinner D1 (riscv).
Jul 7 2025, 8:23 PM