Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (261 w, 6 d)

Recent Activity

Fri, Mar 22

mhorne committed rGdc7ae2bc6fad: kern_ctf.c: fix linking with nooptions DDB (authored by mhorne).
kern_ctf.c: fix linking with nooptions DDB
Fri, Mar 22, 4:31 PM

Thu, Mar 21

mhorne committed rG3f72f36cf2f9: assert.3: Update manual page based on mandoc -Tlint (authored by christopher.davidson_gmail.com).
assert.3: Update manual page based on mandoc -Tlint
Thu, Mar 21, 6:25 PM
mhorne committed rG36de8bb22667: kassert.h: update MPASS definition commentary (authored by mhorne).
kassert.h: update MPASS definition commentary
Thu, Mar 21, 3:27 PM
mhorne committed rG5d956e11ed37: KASSERT(9): describe history of MPASS (authored by mhorne).
KASSERT(9): describe history of MPASS
Thu, Mar 21, 3:26 PM
mhorne committed rG83a426d13a6a: KASSERT(9): add assertion message guidelines (authored by mhorne).
KASSERT(9): add assertion message guidelines
Thu, Mar 21, 3:26 PM
mhorne committed rGcc1268a92677: BSD.usr.dist: remove empty /usr/libdata/gcc directory (authored by mhorne).
BSD.usr.dist: remove empty /usr/libdata/gcc directory
Thu, Mar 21, 3:26 PM
mhorne closed D44438: kassert.h: update MPASS definition commentary.
Thu, Mar 21, 3:26 PM
mhorne closed D44439: KASSERT(9): describe history of MPASS.
Thu, Mar 21, 3:26 PM
mhorne closed D44434: KASSERT(9): add assertion message guidelines.
Thu, Mar 21, 3:26 PM
mhorne closed D44440: BSD.usr.dist: remove empty /usr/libdata/gcc directory.
Thu, Mar 21, 3:26 PM
mhorne committed rG8b864151856f: cp: Remove useless ssize_t cast (authored by collin.funk1_gmail.com).
cp: Remove useless ssize_t cast
Thu, Mar 21, 2:44 PM
mhorne committed rG501f7e7bf847: em.4: add interfaces to name section (authored by concussious.bugzilla_runbox.com).
em.4: add interfaces to name section
Thu, Mar 21, 2:20 PM

Wed, Mar 20

mhorne requested review of D44440: BSD.usr.dist: remove empty /usr/libdata/gcc directory.
Wed, Mar 20, 5:45 PM
mhorne added inline comments to D44439: KASSERT(9): describe history of MPASS.
Wed, Mar 20, 2:44 PM
mhorne added a comment to D44434: KASSERT(9): add assertion message guidelines.
In D44434#1013418, @bz wrote:

Thank you!
Can we also adjust the comment above MPASS() in the header file?

Wed, Mar 20, 2:43 PM
mhorne updated the diff for D44434: KASSERT(9): add assertion message guidelines.

Handle minor review feedback.

Wed, Mar 20, 2:42 PM
mhorne requested review of D44439: KASSERT(9): describe history of MPASS.
Wed, Mar 20, 2:42 PM
mhorne requested review of D44438: kassert.h: update MPASS definition commentary.
Wed, Mar 20, 2:41 PM

Tue, Mar 19

mhorne requested review of D44434: KASSERT(9): add assertion message guidelines.
Tue, Mar 19, 5:44 PM

Fri, Mar 8

mhorne committed rGaccda7815317: simple_mfd: don't attach children twice (authored by mhorne).
simple_mfd: don't attach children twice
Fri, Mar 8, 2:11 PM
mhorne committed rG08635c51d1e3: clkdom_dump(): improve output text (authored by mhorne).
clkdom_dump(): improve output text
Fri, Mar 8, 2:11 PM
mhorne committed rG1cb9f6f6413e: clk_fixed: quiet by default (authored by mhorne).
clk_fixed: quiet by default
Fri, Mar 8, 2:10 PM
mhorne closed D44268: simple_mfd: don't attach children twice.
Fri, Mar 8, 2:10 PM
mhorne closed D44267: clkdom_dump(): improve output text.
Fri, Mar 8, 2:10 PM
mhorne committed rG6e66bb9fc3d0: clk_fixed: call clkdom_dump() for verbose boot (authored by mhorne).
clk_fixed: call clkdom_dump() for verbose boot
Fri, Mar 8, 2:10 PM
mhorne closed D44266: clk_fixed: quiet by default.
Fri, Mar 8, 2:10 PM
mhorne closed D44265: clk_fixed: call clkdom_dump() for verbose boot.
Fri, Mar 8, 2:10 PM

Thu, Mar 7

mhorne updated the diff for D44270: starfive: add a syscon driver.

Trim #includes; fix softc size in driver declaration.

Thu, Mar 7, 7:51 PM
mhorne requested review of D44270: starfive: add a syscon driver.
Thu, Mar 7, 7:46 PM
mhorne requested review of D44268: simple_mfd: don't attach children twice.
Thu, Mar 7, 6:25 PM
mhorne requested review of D44267: clkdom_dump(): improve output text.
Thu, Mar 7, 6:24 PM
mhorne requested review of D44266: clk_fixed: quiet by default.
Thu, Mar 7, 6:24 PM
mhorne requested review of D44265: clk_fixed: call clkdom_dump() for verbose boot.
Thu, Mar 7, 6:24 PM
mhorne added inline comments to D44026: JH7110 MMC driver.
Thu, Mar 7, 5:22 PM

Mon, Mar 4

mhorne committed rGda48ddbf7c38: riscv: catch up with EARLY_PRINTF changes (authored by mhorne).
riscv: catch up with EARLY_PRINTF changes
Mon, Mar 4, 6:46 PM
mhorne closed D44100: riscv: catch up with EARLY_PRINTF changes.
Mon, Mar 4, 6:46 PM

Feb 27 2024

mhorne committed rGf84e9df6d0e5: conf: deduplicate dwmmc config logic (authored by mhorne).
conf: deduplicate dwmmc config logic
Feb 27 2024, 10:11 PM
mhorne committed rG749e318da39e: riscv: add starfive kernelconf template (authored by mhorne).
riscv: add starfive kernelconf template
Feb 27 2024, 10:11 PM
mhorne committed rG036ce936a5aa: riscv: add dwc, dwmmc to NOTES (authored by mhorne).
riscv: add dwc, dwmmc to NOTES
Feb 27 2024, 10:11 PM
mhorne committed rGfae39d8da9d5: dwc: fix DEBUG macro name (authored by mhorne).
dwc: fix DEBUG macro name
Feb 27 2024, 10:11 PM
mhorne committed rGa01dc140b27e: conf: deduplicate dwc config logic (authored by mhorne).
conf: deduplicate dwc config logic
Feb 27 2024, 10:11 PM
mhorne closed D44105: riscv: add starfive kernelconf template.
Feb 27 2024, 10:11 PM
mhorne closed D44104: conf: deduplicate dwmmc config logic.
Feb 27 2024, 10:11 PM
mhorne closed D44103: conf: deduplicate dwc config logic.
Feb 27 2024, 10:11 PM
mhorne closed D44102: dwc: fix DEBUG macro name.
Feb 27 2024, 10:11 PM
mhorne added inline comments to D44103: conf: deduplicate dwc config logic.
Feb 27 2024, 6:09 PM
mhorne accepted D44098: Fix md5.1 example.
Feb 27 2024, 6:02 PM
mhorne added a comment to D44105: riscv: add starfive kernelconf template.

This, and the preceding changes are not super impactful. I'm just trying to lay the groundwork to make the testing/upstreaming process simpler (mainly for myself).

Feb 27 2024, 6:01 PM
mhorne requested review of D44105: riscv: add starfive kernelconf template.
Feb 27 2024, 5:58 PM
mhorne requested review of D44104: conf: deduplicate dwmmc config logic.
Feb 27 2024, 5:57 PM
mhorne requested review of D44103: conf: deduplicate dwc config logic.
Feb 27 2024, 5:57 PM
mhorne requested review of D44102: dwc: fix DEBUG macro name.
Feb 27 2024, 5:56 PM
mhorne requested review of D44100: riscv: catch up with EARLY_PRINTF changes.
Feb 27 2024, 5:49 PM

Feb 26 2024

mhorne committed rG7a3d7b29f83e: release: de-duplicate arm.subr fstab logic (authored by mhorne).
release: de-duplicate arm.subr fstab logic
Feb 26 2024, 3:37 PM

Feb 16 2024

mhorne committed rGb134c10d658c: busdma: fix page miscount for small segment sizes (authored by mhorne).
busdma: fix page miscount for small segment sizes
Feb 16 2024, 6:40 PM
mhorne closed D34118: busdma: fix page miscount for small segment sizes.
Feb 16 2024, 6:39 PM

Feb 15 2024

mhorne accepted D43919: riscv: Add missing includes for DDB.
Feb 15 2024, 4:08 PM

Feb 14 2024

mhorne closed D43293: RISCV: Introduce support for APLIC interrupt controller.
Feb 14 2024, 3:44 PM · riscv
mhorne committed rGee91dae43d23: riscv: Introduce support for APLIC interrupt controller (authored by himanshu_thechauhan.dev).
riscv: Introduce support for APLIC interrupt controller
Feb 14 2024, 3:44 PM
mhorne accepted D43293: RISCV: Introduce support for APLIC interrupt controller.
Feb 14 2024, 3:27 PM · riscv
mhorne committed rG3fb8f1272b50: riscv: add firmware partitions to GENERICSD.conf (authored by mhorne).
riscv: add firmware partitions to GENERICSD.conf
Feb 14 2024, 3:18 PM
mhorne committed rG2af03ebfb853: release: make SD card partition layout more flexible (authored by mhorne).
release: make SD card partition layout more flexible
Feb 14 2024, 3:18 PM
mhorne committed rG94b86c12f14e: release: de-duplicate arm.subr fstab logic (authored by mhorne).
release: de-duplicate arm.subr fstab logic
Feb 14 2024, 3:18 PM
mhorne closed D43849: riscv: add firmware partitions to GENERICSD.conf.
Feb 14 2024, 3:17 PM
mhorne closed D43848: release: make SD card partition layout more flexible.
Feb 14 2024, 3:17 PM
mhorne closed D43847: release: deduplicate arm.subr fstab logic.
Feb 14 2024, 3:17 PM

Feb 13 2024

mhorne added a comment to D34118: busdma: fix page miscount for small segment sizes.
In D34118#1000839, @jhb wrote:

This is ok, but I do think it's not ideal, per se. I think to make bounce pages more packed you would not apply this diff but instead do something like:

...

Feb 13 2024, 7:57 PM
mhorne added a comment to D34118: busdma: fix page miscount for small segment sizes.
In D34118#771586, @jhb wrote:

I would say that a max segment size < PAGE_SIZE is generally under-tested and probably broken in several ways. I would be tempted to still copy PAGE_SIZE chunks into bounce pages when needed and then carve the PAGE_SIZE segments up into multiple segments when writing out the segments if possible.

Feb 13 2024, 6:04 PM
mhorne retitled D34118: busdma: fix page miscount for small segment sizes from riscv: fix bounce page miscalculation to busdma: fix page miscount for small segment sizes.
Feb 13 2024, 6:02 PM
mhorne updated the diff for D34118: busdma: fix page miscount for small segment sizes.

Rebase and extend the patch to other architectures.

Feb 13 2024, 6:00 PM
mhorne added a comment to D43849: riscv: add firmware partitions to GENERICSD.conf.

Is the following summary accurate: This change is not required for all systems, but doesn't hurt; it makes it easier for some configurations. If that's true, then I don't have a problem with it.

Feb 13 2024, 2:54 PM

Feb 12 2024

mhorne added a comment to D43849: riscv: add firmware partitions to GENERICSD.conf.

I just flashed the firmware to the VisionFive 2's on-board flash and then booted the existing GENERICSD without touching partitioning.

Feb 12 2024, 7:49 PM
mhorne added a comment to D43849: riscv: add firmware partitions to GENERICSD.conf.

Doing this for the Unmatched doesn’t seem very useful when we can’t use the SD card for our rootfs due to driver limitations. I’ve generally taken the view that the “correct” way to treat all these dev boards so far is to treat firmware as distinct, whether that means using on-board flash (and a normally-partitioned drive in any form) or a dedicated firmware SD card (and a normally-partitioned drive that’s not the same SD card). The Arm world is a mess with all the special firmware you need, and we should be pushing for standard EFI boot flows where the firmware is part of the board rather than the OS (even if we ship updates to it for convenience).

Feb 12 2024, 7:34 PM
mhorne added inline comments to D43847: release: deduplicate arm.subr fstab logic.
Feb 12 2024, 6:12 PM
mhorne updated the test plan for D43848: release: make SD card partition layout more flexible.
Feb 12 2024, 6:03 PM
mhorne added a reviewer for D43849: riscv: add firmware partitions to GENERICSD.conf: riscv.
Feb 12 2024, 5:55 PM
mhorne requested review of D43849: riscv: add firmware partitions to GENERICSD.conf.
Feb 12 2024, 5:55 PM
mhorne requested review of D43848: release: make SD card partition layout more flexible.
Feb 12 2024, 5:55 PM
mhorne requested review of D43847: release: deduplicate arm.subr fstab logic.
Feb 12 2024, 5:55 PM

Feb 3 2024

mhorne accepted D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:51 PM · Contributor Reviews (src)

Feb 2 2024

mhorne accepted D41295: arm64/disassem.c: add bitwise or (immediate) instructions.
Feb 2 2024, 7:00 PM
mhorne accepted D41561: arm64/disassem.c: add disassembly support crc32.
Feb 2 2024, 6:49 PM

Feb 1 2024

mhorne committed R11:7fb860ab8aa0: sysutils/u-boot-starfive-visionfive2: fix description (authored by mhorne).
sysutils/u-boot-starfive-visionfive2: fix description
Feb 1 2024, 4:16 PM

Jan 31 2024

mhorne accepted D43293: RISCV: Introduce support for APLIC interrupt controller.

LGTM!

Jan 31 2024, 7:09 PM · riscv
mhorne requested review of D43683: where.adoc: add 14-STABLE snapshot links.
Jan 31 2024, 6:54 PM
mhorne requested review of D43682: where.adoc: remove armv6 link for 15-CURRENT snapshots.
Jan 31 2024, 6:54 PM
mhorne committed rG712fd5ac9181: intro.9: minor changes (authored by grahamperrin).
intro.9: minor changes
Jan 31 2024, 6:36 PM

Jan 30 2024

mhorne accepted D43672: riscv: Remove the unused riscv64_cpu driver.
Jan 30 2024, 8:31 PM

Jan 24 2024

mhorne accepted D35901: riscv: Convert local interrupt controller to a newbus PIC.
Jan 24 2024, 8:05 PM

Jan 23 2024

mhorne closed D43517: sysutils/u-boot-starfive-visionfive2: new port.
Jan 23 2024, 5:21 PM
mhorne committed R11:970cec81a5cd: sysutils/u-boot-starfive-visionfive2: new port (authored by mhorne).
sysutils/u-boot-starfive-visionfive2: new port
Jan 23 2024, 5:21 PM

Jan 22 2024

mhorne added a comment to D35901: riscv: Convert local interrupt controller to a newbus PIC.

I am pretty sure this is good. But I don't understand the addition of the resource list management to sbi.c. Why shouldn't these requests just be passed to nexus?

Jan 22 2024, 8:14 PM
mhorne committed rG4057fb12a1d7: arm64: fix db_read_bytes() for size == 8 (authored by mhorne).
arm64: fix db_read_bytes() for size == 8
Jan 22 2024, 6:08 PM
mhorne committed rGc738eac52e05: arm64: fix db_read_bytes() for size == 8 (authored by mhorne).
arm64: fix db_read_bytes() for size == 8
Jan 22 2024, 6:05 PM
mhorne accepted D35899: intrng: Allow alternative IPI PICs to be registered and used.

To me, this is quite sane, and achieves what we need in the immediate present for the purposes of the RISC-V interrupt controller stack.

Jan 22 2024, 4:52 PM
mhorne accepted D35898: intrng: Extract arm/arm64 IPI->PIC glue code.
Jan 22 2024, 4:25 PM
mhorne accepted D35900: riscv: Create a newbus device for the SBI driver.
Jan 22 2024, 4:10 PM
mhorne accepted D35897: intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg.
Jan 22 2024, 3:53 PM
mhorne updated the diff for D43517: sysutils/u-boot-starfive-visionfive2: new port.

Remove the config fragment. Add the port to SUBDIR list.

Jan 22 2024, 3:52 PM
mhorne added a comment to D43517: sysutils/u-boot-starfive-visionfive2: new port.

Hm, OpenSBI is supposed to be built as a PIE by default if the toolchain supports it, which LLVM should, and thus it shouldn't matter where the SPL loads OpenSBI. Debian doesn't override this as far as I can tell, yet also uses its generic OpenSBI binary package.

Jan 22 2024, 3:50 PM