machine/param.h: drop __HAVE_ACPI define
ClosedPublic
Actions

Authored by mhorne on Jan 16 2025, 5:21 PM.

Details

Reviewers

jhb
imp

Commits

rG44bd0e89a1c4: machine/param.h: drop __HAVE_ACPI define

Summary

It is no longer used anywhere, and not defined for arm64 which also
supports ACPI.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Jan 16 2025, 5:21 PM

mhorne created this revision.

mhorne added a child revision: D48487: bus.h: remove deprecated struct driver.

Harbormaster completed remote builds in B61768: Diff 149355.Jan 16 2025, 5:22 PM

imp accepted this revision.Jan 16 2025, 5:35 PM

This revision is now accepted and ready to land.Jan 16 2025, 5:35 PM

jhb accepted this revision.Jan 18 2025, 2:29 PM

As I note in the other review, this has been unused since:

commit 62508c531e0f19a9154670a3cd820164c486131f
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue Aug 17 15:44:52 2010 +0000

    Add a new method to the PCI bridge interface, PCIB_POWER_FOR_SLEEP().  This
    method is used by the PCI bus driver to query the power management system
    to determine the proper device state to be used for a device during suspend
    and resume.  For the ACPI PCI bridge drivers this calls
    acpi_device_pwr_for_sleep().  This removes ACPI-specific knowledge from
    the PCI and PCI-PCI bridge drivers.
    
    Reviewed by:    jkim

Notes:
    svn path=/head/; revision=211430

NetBSD does this more extensively and we picked up the habit from them, but have been somewhat bad about keeping up with it, even by 2010

Closed by commit rG44bd0e89a1c4: machine/param.h: drop __HAVE_ACPI define (authored by mhorne). · Explain WhyJan 23 2025, 8:32 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG44bd0e89a1c4: machine/param.h: drop __HAVE_ACPI define.