bus.h: remove unused devop_t typedef
ClosedPublic
Actions

Authored by mhorne on Jan 16 2025, 5:22 PM.

Details

Reviewers

jhb
imp

Commits

rG5ec5d08489ba: bus.h: remove unused devop_t typedef

Summary

Passes tinderbox.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Jan 16 2025, 5:22 PM

mhorne created this revision.

mhorne added a parent revision: D48487: bus.h: remove deprecated struct driver.

mhorne added a child revision: D48489: EARLY_DRIVER_MODULE: use designated initializers.

Harbormaster completed remote builds in B61770: Diff 149357.Jan 16 2025, 5:22 PM

This has been unused since

commit f7b776917236d24a4ac7aaa19b3595abdd8411f9
Author: Doug Rabson <dfr@FreeBSD.org>
Date:   Sat Apr 8 14:17:18 2000 +0000

    * Factor out the object system from new-bus so that it can be used by
      non-device code.
    * Re-implement the method dispatch to improve efficiency. The new system
      takes about 40ns for a method dispatch on a 300Mhz PII which is only
      10ns slower than a direct function call on the same hardware.

    This changes the new-bus ABI slightly so make sure you re-compile any
    driver modules which you use.

I don't think we're being too hasty removing it. It used to be used a pointer to the compiled ops (method) table.

This revision is now accepted and ready to land.Jan 16 2025, 5:30 PM

In D48488#1106326, @imp wrote:

This has been unused since

commit f7b776917236d24a4ac7aaa19b3595abdd8411f9
Author: Doug Rabson <dfr@FreeBSD.org>
Date:   Sat Apr 8 14:17:18 2000 +0000

    * Factor out the object system from new-bus so that it can be used by
      non-device code.
    * Re-implement the method dispatch to improve efficiency. The new system
      takes about 40ns for a method dispatch on a 300Mhz PII which is only
      10ns slower than a direct function call on the same hardware.

    This changes the new-bus ABI slightly so make sure you re-compile any
    driver modules which you use.

I don't think we're being too hasty removing it. It used to be used a pointer to the compiled ops (method) table.

Thanks, I will include this info in the commit message.

jhb accepted this revision.Jan 18 2025, 2:31 PM

Closed by commit rG5ec5d08489ba: bus.h: remove unused devop_t typedef (authored by mhorne). · Explain WhyJan 23 2025, 8:32 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG5ec5d08489ba: bus.h: remove unused devop_t typedef.