pci: cleanup __PCI_REROUTE_INTERRUPTS
ClosedPublic
Actions

Authored by mhorne on Jan 16 2025, 5:21 PM.

Details

Reviewers

jhb
jrtc27
andrew
manu
imp

Commits

rG5884fab46153: pci: cleanup __PCI_REROUTE_INTERRUPTS

Summary

It is defined for all supported architectures.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jan 16 2025, 5:21 PM

Herald added a reviewer: andrew. · View Herald TranscriptJan 16 2025, 5:21 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

mhorne requested review of this revision.Jan 16 2025, 5:21 PM

Harbormaster completed remote builds in B61767: Diff 149354.Jan 16 2025, 5:22 PM

This, I think , was for old mips boards, but I've not done the software archeology to confirm that.

This revision is now accepted and ready to land.Jan 16 2025, 5:36 PM

This was a transition aid before all architectures implemented the proper pcib_if.m methods. It can go away now.

This helper was added in this commit:

commit a48895a77e3b6390481c1bb4fa850252c04d183d
Author: Warner Losh <imp@FreeBSD.org>
Date:   Sun Jan 1 21:04:31 2006 +0000

    Use __HAVE_ACPI and __PCI_REROUTE_INTERRUPT as appropriate rather than
    the complicated #ifdefs.

Notes:
    svn path=/head/; revision=153956

The macro was added in

commit 501755f4f61fef5716992ea6d59cfba80eef84ee
Author: Warner Losh <imp@FreeBSD.org>
Date:   Sun Jan 1 20:59:28 2006 +0000

    Define __HAVE_ACPI and/or __PCI_REROUTE_INTERRUPT, as appropriate for
    each platform.  These will be used in the pci code in preference to
    the complicated #ifdefs we have there now.

Notes:
    svn path=/head/; revision=153955

The diff from the pci.c commit is a bit helpful to understand the history. I probably moved the ACPI bits out when creating acpi_pci.c. Hmm, nope, this commit:

commit 62508c531e0f19a9154670a3cd820164c486131f
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue Aug 17 15:44:52 2010 +0000

    Add a new method to the PCI bridge interface, PCIB_POWER_FOR_SLEEP().  This
    method is used by the PCI bus driver to query the power management system
    to determine the proper device state to be used for a device during suspend
    and resume.  For the ACPI PCI bridge drivers this calls
    acpi_device_pwr_for_sleep().  This removes ACPI-specific knowledge from
    the PCI and PCI-PCI bridge drivers.
    
    Reviewed by:    jkim

I failed to remove "opt_acpi.h" includes from sys/dev/pci/pci.c though in that change.

jhb accepted this revision.Jan 18 2025, 2:40 PM

Closed by commit rG5884fab46153: pci: cleanup __PCI_REROUTE_INTERRUPTS (authored by mhorne). · Explain WhyJan 23 2025, 8:32 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG5884fab46153: pci: cleanup __PCI_REROUTE_INTERRUPTS.