Page MenuHomeFreeBSD

pci: cleanup __PCI_REROUTE_INTERRUPTS
ClosedPublic

Authored by mhorne on Jan 16 2025, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 4:18 AM
Unknown Object (File)
Fri, Oct 3, 5:25 PM
Unknown Object (File)
Sep 17 2025, 7:46 PM
Unknown Object (File)
Sep 17 2025, 4:34 AM
Unknown Object (File)
Sep 12 2025, 3:42 PM
Unknown Object (File)
Aug 10 2025, 11:39 AM
Unknown Object (File)
Aug 9 2025, 9:14 PM
Unknown Object (File)
Aug 9 2025, 4:28 PM

Details

Summary

It is defined for all supported architectures.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This, I think , was for old mips boards, but I've not done the software archeology to confirm that.

This revision is now accepted and ready to land.Jan 16 2025, 5:36 PM

This was a transition aid before all architectures implemented the proper pcib_if.m methods. It can go away now.

This helper was added in this commit:

commit a48895a77e3b6390481c1bb4fa850252c04d183d
Author: Warner Losh <imp@FreeBSD.org>
Date:   Sun Jan 1 21:04:31 2006 +0000

    Use __HAVE_ACPI and __PCI_REROUTE_INTERRUPT as appropriate rather than
    the complicated #ifdefs.

Notes:
    svn path=/head/; revision=153956

The macro was added in

commit 501755f4f61fef5716992ea6d59cfba80eef84ee
Author: Warner Losh <imp@FreeBSD.org>
Date:   Sun Jan 1 20:59:28 2006 +0000

    Define __HAVE_ACPI and/or __PCI_REROUTE_INTERRUPT, as appropriate for
    each platform.  These will be used in the pci code in preference to
    the complicated #ifdefs we have there now.

Notes:
    svn path=/head/; revision=153955

The diff from the pci.c commit is a bit helpful to understand the history. I probably moved the ACPI bits out when creating acpi_pci.c. Hmm, nope, this commit:

commit 62508c531e0f19a9154670a3cd820164c486131f
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue Aug 17 15:44:52 2010 +0000

    Add a new method to the PCI bridge interface, PCIB_POWER_FOR_SLEEP().  This
    method is used by the PCI bus driver to query the power management system
    to determine the proper device state to be used for a device during suspend
    and resume.  For the ACPI PCI bridge drivers this calls
    acpi_device_pwr_for_sleep().  This removes ACPI-specific knowledge from
    the PCI and PCI-PCI bridge drivers.
    
    Reviewed by:    jkim

I failed to remove "opt_acpi.h" includes from sys/dev/pci/pci.c though in that change.

This revision was automatically updated to reflect the committed changes.