Page MenuHomeFreeBSD

sdhci: refine locking in sdhci_card_task()
AbandonedPublic

Authored by mhorne on Feb 4 2025, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 1:02 AM
Unknown Object (File)
Sep 15 2025, 1:21 PM
Unknown Object (File)
Sep 15 2025, 1:15 PM
Unknown Object (File)
Sep 9 2025, 6:19 PM
Unknown Object (File)
Aug 15 2025, 12:50 AM
Unknown Object (File)
Jul 6 2025, 10:42 AM
Unknown Object (File)
Jul 5 2025, 12:37 AM
Unknown Object (File)
Jul 2 2025, 6:13 PM
Subscribers
None

Details

Reviewers
imp
manu
Summary

It is invalid to call device_add_child() while holding the driver's
mutex. This was previously of no consequence, but a recent change
to device array allocation (f3d3c63442ff) switched the logic to use
M_WAITOK. Now, a LOR warning is printed when the card is inserted.

Fix this by reducing the scope of the device lock in the helper function
to:

  1. Reading device state (card & child device presence)
  2. Updating device state (after child added/before removed)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62259
Build 59143: arc lint + arc unit