Page MenuHomeFreeBSD

dougm (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (417 w, 3 d)

Tauist. Bit twiddler. Advocate for continued logarithms.

Recent Activity

Sat, Jun 28

dougm committed rG3a33e39edd48: pctrie: correct iter node after node allocation (authored by dougm).
pctrie: correct iter node after node allocation
Sat, Jun 28, 6:51 AM
dougm closed D51059: pctrie: correct iter node after node allocation.
Sat, Jun 28, 6:51 AM

Thu, Jun 26

dougm committed rG725eb0f85ea9: pctrie: drop freenode param to pctrie_remove (authored by dougm).
pctrie: drop freenode param to pctrie_remove
Thu, Jun 26, 10:55 PM
dougm closed D51057: pctrie: drop freenode param to pctrie_remove.
Thu, Jun 26, 10:55 PM
dougm updated the diff for D51058: pctrie: define lookup_readonly.

Update comments, asserts, convert one more lookup to lookup_readonly.

Thu, Jun 26, 8:21 PM
dougm added inline comments to D51058: pctrie: define lookup_readonly.
Thu, Jun 26, 7:57 PM
dougm added reviewers for D51060: pctrie: move the root to the latest search node: alc, kib, markj.
Thu, Jun 26, 7:04 AM
dougm added reviewers for D51059: pctrie: correct iter node after node allocation: alc, kib, markj.
Thu, Jun 26, 7:04 AM
dougm added reviewers for D51058: pctrie: define lookup_readonly: alc, kib, markj.
Thu, Jun 26, 7:03 AM
dougm added reviewers for D51057: pctrie: drop freenode param to pctrie_remove: alc, markj, kib.
Thu, Jun 26, 7:03 AM
dougm requested review of D51060: pctrie: move the root to the latest search node.
Thu, Jun 26, 7:02 AM
dougm requested review of D51059: pctrie: correct iter node after node allocation.
Thu, Jun 26, 6:48 AM
dougm requested review of D51058: pctrie: define lookup_readonly.
Thu, Jun 26, 6:44 AM
dougm requested review of D51057: pctrie: drop freenode param to pctrie_remove.
Thu, Jun 26, 6:40 AM
dougm committed rG44d6f4b314ad: pctrie: use one lookup function (authored by dougm).
pctrie: use one lookup function
Thu, Jun 26, 6:28 AM
dougm closed D50839: pctrie: use one lookup function.
Thu, Jun 26, 6:28 AM

Wed, Jun 25

dougm added reviewers for D50839: pctrie: use one lookup function: markj, kib.
Wed, Jun 25, 6:32 AM

Sun, Jun 22

dougm added inline comments to D50970: amd64 pmap: eliminate two explicit panics on low mem conditions.
Sun, Jun 22, 6:24 PM
dougm added inline comments to D50970: amd64 pmap: eliminate two explicit panics on low mem conditions.
Sun, Jun 22, 8:03 AM

Mon, Jun 16

dougm closed D50861: vm_map: drop simplify_entry.9.
Mon, Jun 16, 5:23 AM

Sun, Jun 15

dougm committed rGc48077d54da6: vm_map: drop vm_map_simplify_entry.9 (authored by dougm).
vm_map: drop vm_map_simplify_entry.9
Sun, Jun 15, 9:24 PM
dougm updated the diff for D50861: vm_map: drop simplify_entry.9.

Update ObsoleteFiles.inc.

Sun, Jun 15, 9:09 PM
dougm requested review of D50861: vm_map: drop simplify_entry.9.
Sun, Jun 15, 7:39 AM

Sat, Jun 14

dougm committed rG7458fac87831: pctrie: simplify lookup_node (authored by dougm).
pctrie: simplify lookup_node
Sat, Jun 14, 7:33 PM
dougm closed D50750: pctrie: simplify lookup_node .
Sat, Jun 14, 7:33 PM

Fri, Jun 13

dougm requested review of D50839: pctrie: use one lookup function.
Fri, Jun 13, 8:02 PM

Wed, Jun 11

dougm updated the diff for D50750: pctrie: simplify lookup_node .
Wed, Jun 11, 10:00 PM

Tue, Jun 10

dougm updated the diff for D50750: pctrie: simplify lookup_node .

Discard the "leaf parents of root" part.

Tue, Jun 10, 8:10 PM

Mon, Jun 9

dougm requested review of D50750: pctrie: simplify lookup_node .
Mon, Jun 9, 7:58 AM

Fri, Jun 6

dougm committed rG7908b5df1abd: pctrie_lookup_node: assume parent_out != NULL (authored by dougm).
pctrie_lookup_node: assume parent_out != NULL
Fri, Jun 6, 8:25 PM
dougm closed D50729: pctrie_lookup_node: assume parent_out != NULL.
Fri, Jun 6, 8:25 PM
dougm requested review of D50729: pctrie_lookup_node: assume parent_out != NULL.
Fri, Jun 6, 6:16 PM

Mon, Jun 2

dougm added a comment to D50640: uma: Use a hand-rolled bitset implementation.

Do you mean that slab->us_free should still have type int *? Then, is the idea that BIT_* would only access the low 32 bits of each bitset (us_free and slab_dbg_bits()), so it's okay to let them overlap from the perspective of BIT_*?

Mon, Jun 2, 11:06 PM
dougm added a comment to D50640: uma: Use a hand-rolled bitset implementation.

Could you shrink uma_slab at still use BITSET?

Mon, Jun 2, 7:38 PM

Sun, Jun 1

dougm accepted D50515: vm_page: retire its listq field.
Sun, Jun 1, 11:42 PM

May 31 2025

dougm committed rG6dd1c0643e9c: vm_page: use lookup_ge in grab_valid_iter() (authored by dougm).
vm_page: use lookup_ge in grab_valid_iter()
May 31 2025, 6:41 PM
dougm closed D50601: vm_page: use lookup_ge in grab_valid_iter().
May 31 2025, 6:41 PM
dougm committed rGe3bc87ab1b66: vm_pageout: fix pageout_flush (authored by dougm).
vm_pageout: fix pageout_flush
May 31 2025, 6:04 PM
dougm closed D50622: vm_pageout: fix pageout_flush.
May 31 2025, 6:04 PM
dougm requested review of D50622: vm_pageout: fix pageout_flush.
May 31 2025, 2:42 AM

May 30 2025

dougm added inline comments to D50601: vm_page: use lookup_ge in grab_valid_iter().
May 30 2025, 9:24 PM
dougm committed rGf2a193a967e3: vm_pageout: reduce number of flush() params (authored by dougm).
vm_pageout: reduce number of flush() params
May 30 2025, 9:10 PM
dougm closed D50568: vm_pageout: reduce number of flush() params.
May 30 2025, 9:09 PM
dougm updated the diff for D50568: vm_pageout: reduce number of flush() params.
May 30 2025, 6:20 PM
dougm updated the diff for D50568: vm_pageout: reduce number of flush() params.
May 30 2025, 4:45 PM
dougm updated the diff for D50601: vm_page: use lookup_ge in grab_valid_iter().
May 30 2025, 4:35 PM

May 29 2025

dougm updated the diff for D50601: vm_page: use lookup_ge in grab_valid_iter().

Don't let ahead exceed after.

May 29 2025, 11:09 PM
dougm updated the diff for D50601: vm_page: use lookup_ge in grab_valid_iter().

@alc advises that having lookup_range return a positive value in this case will be rare, and testing shows that. So, instead of using lookup_range to find a bunch of pages, try using lookup_ge to quickly identify a range of missing pages.

May 29 2025, 11:00 PM
dougm requested review of D50601: vm_page: use lookup_ge in grab_valid_iter().
May 29 2025, 6:54 PM

May 28 2025

dougm added inline comments to D50515: vm_page: retire its listq field.
May 28 2025, 7:00 AM
dougm requested review of D50568: vm_pageout: reduce number of flush() params.
May 28 2025, 6:02 AM
dougm committed rG18a62137df40: vm_object: use lookup_range in page_clean_flush (authored by dougm).
vm_object: use lookup_range in page_clean_flush
May 28 2025, 5:37 AM
dougm closed D50425: vm_object: use lookup_range in vm_object_page_clean_flush .
May 28 2025, 5:37 AM

May 27 2025

dougm added a comment to D50515: vm_page: retire its listq field.

If that's your regular user id, then the result is presumably the same. The killpg4.sh test assumes that nothing else on the system is running as that user. So, the problem isn't limited to "root" as I claimed earlier.

May 27 2025, 4:14 PM
dougm added a comment to D50515: vm_page: retire its listq field.

Before running stress2 tests you have to run make in the test suite, and as part of that you are prompted to provide a value for the testuser variable. That gets saved in the file /tmp/stress2.d/$(hostname). If the saved value of testuser is "root", killpg4 will never terminate. You're supposed to ensure that testuser is a non-root user.

May 27 2025, 3:50 PM
dougm added a comment to D50515: vm_page: retire its listq field.

Did you figure out why killpg4.sh is hanging?

It always hangs for me. It has always hung for me. I haven't tried to diagnose it. I'm only ever running the tests as root. If I'm supposed to run the tests some other way, I'm not aware of it.

May 27 2025, 5:58 AM

May 26 2025

dougm updated the diff for D50425: vm_object: use lookup_range in vm_object_page_clean_flush .

Limit the changes to just vm_object_page_clean_flush. Provide more meaningful performance results.

May 26 2025, 9:58 PM
dougm added inline comments to D50515: vm_page: retire its listq field.
May 26 2025, 4:00 PM
dougm committed rG68e3875b623b: vm_object: drop reverse walk from collect_flush (authored by dougm).
vm_object: drop reverse walk from collect_flush
May 26 2025, 3:06 AM
dougm closed D50517: vm_object: drop reverse walk from collect_flush.
May 26 2025, 3:06 AM

May 25 2025

dougm committed rG142bcdad1f67: vm_page: drop mpred from grab_valid_iter() (authored by dougm).
vm_page: drop mpred from grab_valid_iter()
May 25 2025, 9:16 PM
dougm closed D50424: vm_page: drop mpred from grab_valid_iter().
May 25 2025, 9:15 PM

May 24 2025

dougm added a reviewer for D50424: vm_page: drop mpred from grab_valid_iter(): alc.
May 24 2025, 10:06 PM
dougm requested review of D50517: vm_object: drop reverse walk from collect_flush.
May 24 2025, 9:59 PM

May 21 2025

dougm updated the test plan for D50425: vm_object: use lookup_range in vm_object_page_clean_flush .
May 21 2025, 4:21 AM

May 20 2025

dougm added inline comments to D50425: vm_object: use lookup_range in vm_object_page_clean_flush .
May 20 2025, 9:45 PM
dougm reopened D50424: vm_page: drop mpred from grab_valid_iter().
May 20 2025, 8:18 AM
dougm updated the diff for D50424: vm_page: drop mpred from grab_valid_iter().

Fixed.

May 20 2025, 8:18 AM
dougm committed rGc8ffb90b1dd3: Revert "vm_page: drop mpred from grab_valid_iter()" (authored by dougm).
Revert "vm_page: drop mpred from grab_valid_iter()"
May 20 2025, 8:10 AM
dougm added a reverting change for rG0f941203ac51: vm_page: drop mpred from grab_valid_iter(): rGc8ffb90b1dd3: Revert "vm_page: drop mpred from grab_valid_iter()".
May 20 2025, 8:10 AM
dougm added a reverting change for D50424: vm_page: drop mpred from grab_valid_iter(): rGc8ffb90b1dd3: Revert "vm_page: drop mpred from grab_valid_iter()".
May 20 2025, 8:10 AM
dougm requested review of D50425: vm_object: use lookup_range in vm_object_page_clean_flush .
May 20 2025, 7:32 AM
dougm closed D50424: vm_page: drop mpred from grab_valid_iter().
May 20 2025, 7:16 AM
dougm committed rG0f941203ac51: vm_page: drop mpred from grab_valid_iter() (authored by dougm).
vm_page: drop mpred from grab_valid_iter()
May 20 2025, 7:16 AM
dougm requested review of D50424: vm_page: drop mpred from grab_valid_iter().
May 20 2025, 3:19 AM

May 19 2025

dougm committed rG26b3641f97d9: vm_page_grab_pages: avoid doomed range lookups (authored by dougm).
vm_page_grab_pages: avoid doomed range lookups
May 19 2025, 4:00 AM
dougm closed D50394: vm_page_grab_pages: avoid doomed range lookups.
May 19 2025, 4:00 AM

May 18 2025

dougm closed D50392: vm_page: reset iterator after domainset drops lock.
May 18 2025, 6:15 PM
dougm committed rG7fa19ee28c90: vm_page: reset iterator after domainset drops lock (authored by dougm).
vm_page: reset iterator after domainset drops lock
May 18 2025, 6:15 PM
dougm committed rG6fd6c29a236c: pctrie: use popmap in locked lookup_range (authored by dougm).
pctrie: use popmap in locked lookup_range
May 18 2025, 3:14 AM
dougm closed D50389: pctrie: use popmap in locked lookup_range.
May 18 2025, 3:14 AM

May 17 2025

dougm updated the diff for D50389: pctrie: use popmap in locked lookup_range.

@alc asks for a more commenting about why this code treats SMR and locked diferently. I oblige.

May 17 2025, 7:56 PM
dougm updated the diff for D50389: pctrie: use popmap in locked lookup_range.

Correct ',' to '.' in comment.

May 17 2025, 7:45 PM
dougm updated the diff for D50389: pctrie: use popmap in locked lookup_range.

Remove extra paren on KASSERT.

May 17 2025, 7:22 PM
dougm updated the diff for D50389: pctrie: use popmap in locked lookup_range.

Add comments to explain end calculation. Add KASSERT to check that copied pages are not NULL.

May 17 2025, 6:55 PM
dougm added inline comments to D50389: pctrie: use popmap in locked lookup_range.
May 17 2025, 6:31 PM
dougm requested review of D50394: vm_page_grab_pages: avoid doomed range lookups.
May 17 2025, 5:58 PM
dougm updated the diff for D50392: vm_page: reset iterator after domainset drops lock.
May 17 2025, 5:17 PM
dougm updated the diff for D50389: pctrie: use popmap in locked lookup_range.
May 17 2025, 4:43 PM
dougm requested review of D50392: vm_page: reset iterator after domainset drops lock.
May 17 2025, 8:37 AM
dougm requested review of D50389: pctrie: use popmap in locked lookup_range.
May 17 2025, 5:44 AM
dougm committed rG5239a9fb8662: vm_page: alloc_domain_iter (authored by dougm).
vm_page: alloc_domain_iter
May 17 2025, 3:57 AM

May 16 2025

dougm committed rG4179cc8da65d: vm_page: conditionally compile label (authored by dougm).
vm_page: conditionally compile label
May 16 2025, 9:09 AM
dougm committed rG3fe2f81f665b: vm_page: reduce iter_reset calls in alloc_domain_iter (authored by dougm).
vm_page: reduce iter_reset calls in alloc_domain_iter
May 16 2025, 8:21 AM
dougm committed rG349340c8cd5c: vm_page: use vm_page_alloc_fail consistently (authored by dougm).
vm_page: use vm_page_alloc_fail consistently
May 16 2025, 8:20 AM
dougm committed rGefde1e2c8b76: vm_page: remove unneeded use of mpred (authored by dougm).
vm_page: remove unneeded use of mpred
May 16 2025, 8:20 AM
dougm committed rG7c9fe7a7925b: vm_page: remove obsolete page alloc loops (authored by dougm).
vm_page: remove obsolete page alloc loops
May 16 2025, 8:20 AM
dougm committed rGca18e0441029: vm_page: update some iterator-related comments (authored by dougm).
vm_page: update some iterator-related comments
May 16 2025, 8:20 AM
dougm closed D50263: vm_page: cleanup.
May 16 2025, 8:20 AM

May 14 2025

dougm committed rGcb205f5ed808: pctrie_lookup_range: don't write the null (authored by dougm).
pctrie_lookup_range: don't write the null
May 14 2025, 11:58 PM