Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (613 w, 1 d)

Recent Activity

Fri, Mar 27

brooks committed R11:ed313eabe5df: devel/qemu-cheri: update to a new snapshot (authored by brooks).
devel/qemu-cheri: update to a new snapshot
Fri, Mar 27, 4:32 PM
brooks committed R11:483a6fa9f087: devel/llvm22: 22.1.2 release (authored by brooks).
devel/llvm22: 22.1.2 release
Fri, Mar 27, 4:32 PM
brooks committed R11:9bef81efd3d9: devel/llvm22: 22.1.1 release (authored by brooks).
devel/llvm22: 22.1.1 release
Fri, Mar 27, 4:32 PM

Thu, Mar 26

brooks added a comment to D56033: tunefs: Don't lower WARNS.

__ASSUME_ALIGNED could work. __builtin_assume_aligned is broadly supported so I double we even need a fall back.

Thu, Mar 26, 10:03 AM
brooks accepted D56087: packages: Convert world to a subdir build.

I like the overall change. I've at most skimmed the makefile bits, but this seems like a move in the right direction.

Thu, Mar 26, 9:34 AM

Fri, Mar 13

brooks committed rG3abef030d31a: Set errno to ENOMEM on rallocx() OOM failures (authored by Juhyung Park <qkrwngud825@gmail.com>).
Set errno to ENOMEM on rallocx() OOM failures
Fri, Mar 13, 9:15 AM
brooks committed rGb4d8d9bde083: rallocx path: only set errno on the realloc case. (authored by Qi Wang <interwq@gwu.edu>).
rallocx path: only set errno on the realloc case.
Fri, Mar 13, 9:15 AM

Mon, Mar 9

brooks committed rG2c5cd07828ad: rallocx path: only set errno on the realloc case. (authored by Qi Wang <interwq@gwu.edu>).
rallocx path: only set errno on the realloc case.
Mon, Mar 9, 12:38 PM
brooks committed rG5583b64f230f: Set errno to ENOMEM on rallocx() OOM failures (authored by Juhyung Park <qkrwngud825@gmail.com>).
Set errno to ENOMEM on rallocx() OOM failures
Mon, Mar 9, 12:38 PM

Fri, Mar 6

brooks requested review of D55691: */*: remove checks that base ld is(n't) GNU ld.
Fri, Mar 6, 11:41 AM
brooks accepted D55624: all: drop support for FreeBSD 13 and MIPS/riscv64sf.
Fri, Mar 6, 10:37 AM

Thu, Mar 5

brooks committed rG4dd517acb694: libc/armv7: remove default version for alloca (authored by brooks).
libc/armv7: remove default version for alloca
Thu, Mar 5, 10:36 AM
brooks closed D51858: libc/armv7: remove default verison of alloca.
Thu, Mar 5, 10:36 AM
brooks committed rGdb1ecd5854d4: getnetconfig: make nc_error a thread local variable (authored by brooks).
getnetconfig: make nc_error a thread local variable
Thu, Mar 5, 10:31 AM
brooks closed D55310: getnetconfig: make nc_error a thread local variable.
Thu, Mar 5, 10:31 AM
brooks added a comment to D55310: getnetconfig: make nc_error a thread local variable.
In D55310#1269811, @jhb wrote:

I suspect the complexity wasn't to avoid 4 bytes per thread but more because TLS wasn't reliably working on all of our architectures when this was first written (but I could be wrong). :)

Thu, Mar 5, 10:26 AM
brooks committed rGea9bc8465830: cirrus-ci: move package_check after test (authored by brooks).
cirrus-ci: move package_check after test
Thu, Mar 5, 10:25 AM
brooks closed D55481: cirrus-ci: move package_check after test.
Thu, Mar 5, 10:25 AM

Wed, Mar 4

brooks accepted D55658: libc/quad: Switch to per-arch lists of symbols.

This is a lot easier to follow.

Wed, Mar 4, 8:46 PM
brooks accepted D55657: libc/quad: narrow list of symbols exposed for 32-bit arm.

Huh, I'm surprised lld doesn't complain.

Wed, Mar 4, 8:46 PM
brooks added a comment to D55624: all: drop support for FreeBSD 13 and MIPS/riscv64sf.

In the LLVM ports, the lines like:

_BE_LIBS_Mips=		AsmParser Disassembler
_BE_LIBS_BACKWARDS_Mips=Exegesis

Should not be removed as the Mips backend will continue to be built when default options are used and these are needed to ensure the files are handled correctly. The changes removing support from the FREEBSD and NATIVE targets are fine.

Wed, Mar 4, 11:06 AM

Feb 27 2026

brooks added a comment to D55539: Add renameat(2) and AT_RENAME_NOREPLACE flag for it.

Syscall bits look good. A few comments.

Feb 27 2026, 9:28 AM

Feb 25 2026

brooks accepted D55516: sys: Retire le(4).

In addition to ditching mips, we've since moved all our VMs to vtnet. At this point that's table stakes unless the emulator aims entirely for retro-computing support (in which case we don't care about it.)

Feb 25 2026, 9:55 PM

Feb 24 2026

brooks accepted D55453: tools/build/stddef.h: fix stock clang/gcc headers.

@vexeduxr please commit with kib's suggestion

Feb 24 2026, 5:55 PM
brooks updated the diff for D55480: ELF: detect and reject CheriABI binaries.
  • Rebase
  • Sort EF_AARCH64 before EF_ARM
Feb 24 2026, 2:30 PM
brooks updated the summary of D55480: ELF: detect and reject CheriABI binaries.
Feb 24 2026, 12:33 PM
brooks updated the diff for D55480: ELF: detect and reject CheriABI binaries.

drop RISC-V

Feb 24 2026, 12:32 PM
brooks added inline comments to D55480: ELF: detect and reject CheriABI binaries.
Feb 24 2026, 12:29 PM
brooks added a comment to D55481: cirrus-ci: move package_check after test.

Inspired by frustration caused by recent openssl manpage install bugs blocking smoke testing.

Feb 24 2026, 11:56 AM
brooks requested review of D55481: cirrus-ci: move package_check after test.
Feb 24 2026, 11:55 AM
brooks requested review of D55480: ELF: detect and reject CheriABI binaries.
Feb 24 2026, 11:49 AM
brooks added a comment to D55453: tools/build/stddef.h: fix stock clang/gcc headers.

The new commit message is much better. Thanks

Feb 24 2026, 11:33 AM
brooks committed R11:52e12ad06a5e: devel/llvm{19,20,21,22}: don't set LLVM_ENABLE_TERMINFO=OFF (authored by brooks).
devel/llvm{19,20,21,22}: don't set LLVM_ENABLE_TERMINFO=OFF
Feb 24 2026, 11:26 AM
brooks committed R11:c85d06b4b634: devel/llvm22: 22.1.0 Release (authored by brooks).
devel/llvm22: 22.1.0 Release
Feb 24 2026, 11:26 AM
brooks accepted D55453: tools/build/stddef.h: fix stock clang/gcc headers.
Feb 24 2026, 11:07 AM
brooks added a comment to D55453: tools/build/stddef.h: fix stock clang/gcc headers.

I don't think the commit text is specific enough about the cause. You should point to a specific combination that fails, not claim its is was macOS only (I'm fairly sure I added this due to testing cross build on ubuntu).

Feb 24 2026, 9:47 AM

Feb 23 2026

brooks committed rG0076f6d1ad05: sys/_offsetof.h: pacify GCC 12's macro redefinition check (authored by brooks).
sys/_offsetof.h: pacify GCC 12's macro redefinition check
Feb 23 2026, 10:06 AM

Feb 19 2026

brooks committed rGdcbd1fccdc66: types.h: use central definition of offsetof() (authored by brooks).
types.h: use central definition of offsetof()
Feb 19 2026, 4:26 PM
brooks committed rG89c3ae5fc9cc: build: add stddef.h to define ptraddr_t as required (authored by brooks).
build: add stddef.h to define ptraddr_t as required
Feb 19 2026, 3:11 PM
brooks committed rGa31127e6dfbf: sys/syscallsubr.h: assorted tidying (authored by brooks).
sys/syscallsubr.h: assorted tidying
Feb 19 2026, 3:11 PM
brooks committed rG2adc3f0db187: stddef.h: centralize definition of offsetof() (authored by brooks).
stddef.h: centralize definition of offsetof()
Feb 19 2026, 3:11 PM
brooks committed rG1e1892795764: .github: support all stable branches (authored by brooks).
.github: support all stable branches
Feb 19 2026, 3:11 PM
brooks committed rGcb59eec9ebbf: stddef.h: add ptraddr_t (authored by brooks).
stddef.h: add ptraddr_t
Feb 19 2026, 3:11 PM
brooks closed D55308: build: add stddef.h to define ptraddr_t as required.
Feb 19 2026, 3:11 PM
brooks closed D55309: sys/syscallsubr.h: assorted tidying.
Feb 19 2026, 3:11 PM
brooks closed D55307: stddef.h: centralize definition of offsetof().
Feb 19 2026, 3:11 PM
brooks closed D55305: stddef.h: add ptraddr_t.
Feb 19 2026, 3:11 PM
brooks closed D53838: .github: support all stable branches.
Feb 19 2026, 3:11 PM

Feb 18 2026

brooks added reviewers for D53838: .github: support all stable branches: jrtc27, andrew.
Feb 18 2026, 2:51 PM
brooks updated the diff for D55307: stddef.h: centralize definition of offsetof().

centralize definition

Feb 18 2026, 2:40 PM
brooks retitled D55307: stddef.h: centralize definition of offsetof() from sys/stddef.h: guard offsetof definition to stddef.h: centralize definition of offsetof().
Feb 18 2026, 2:39 PM
brooks committed R11:1580588b79e4: devel/llvm22: 22.1.0-rc3 (authored by brooks).
devel/llvm22: 22.1.0-rc3
Feb 18 2026, 12:01 PM
brooks committed R11:f59cd32a1a9b: Mk: add LLVM 22 in default versions list (authored by eric_camachat.org).
Mk: add LLVM 22 in default versions list
Feb 18 2026, 12:01 PM

Feb 17 2026

brooks closed D55332: OpenSSL: install EVP_CIPHER_CTX_get_app_data.3 once.
Feb 17 2026, 6:25 PM
brooks committed rGc4130a8a84e1: OpenSSL: install EVP_CIPHER_CTX_get_app_data.3 once (authored by brooks).
OpenSSL: install EVP_CIPHER_CTX_get_app_data.3 once
Feb 17 2026, 6:25 PM
brooks requested review of D55332: OpenSSL: install EVP_CIPHER_CTX_get_app_data.3 once.
Feb 17 2026, 5:19 PM
brooks added inline comments to D55308: build: add stddef.h to define ptraddr_t as required.
Feb 17 2026, 11:20 AM
brooks updated the diff for D55308: build: add stddef.h to define ptraddr_t as required.

Use size_t as the fall back type

Feb 17 2026, 11:19 AM

Feb 16 2026

brooks added inline comments to D55308: build: add stddef.h to define ptraddr_t as required.
Feb 16 2026, 3:27 PM
brooks updated the diff for D55308: build: add stddef.h to define ptraddr_t as required.

Use PTRADDR_TYPE where available

Feb 16 2026, 3:26 PM
brooks requested review of D55310: getnetconfig: make nc_error a thread local variable.
Feb 16 2026, 2:17 PM
brooks added a comment to D55309: sys/syscallsubr.h: assorted tidying.

The is a no-op change before I start trickling in about a large collection of kern_ and user_ functions required to handle integer pointer ABI compat with CHERI.

Feb 16 2026, 2:11 PM
brooks requested review of D55309: sys/syscallsubr.h: assorted tidying.
Feb 16 2026, 2:01 PM
brooks added a comment to D55308: build: add stddef.h to define ptraddr_t as required.

With this stack of changes it's possible to (cross)build world and kernel with ptraddr_t in a system header.

Feb 16 2026, 1:51 PM
brooks requested review of D55308: build: add stddef.h to define ptraddr_t as required.
Feb 16 2026, 1:50 PM
brooks requested review of D55307: stddef.h: centralize definition of offsetof().
Feb 16 2026, 1:50 PM
brooks requested review of D55305: stddef.h: add ptraddr_t.
Feb 16 2026, 1:47 PM

Feb 9 2026

brooks accepted D55151: amd64: define and use STACKALIGN and REDZONE_SZ.
Feb 9 2026, 4:33 PM

Feb 6 2026

brooks accepted D55135: Sprinkle the use of freebsd32_uint64_t over compat32.

This is a nice improvement over the mix of adhoc versions.

Feb 6 2026, 2:49 PM
brooks added inline comments to D55135: Sprinkle the use of freebsd32_uint64_t over compat32.
Feb 6 2026, 11:41 AM
brooks accepted D54920: STACKALIGN: Reimplement in terms of __align_down.
Feb 6 2026, 9:14 AM

Feb 2 2026

brooks committed rG18d47c1856f4: rpc: correct resultproc_t's type (authored by brooks).
rpc: correct resultproc_t's type
Feb 2 2026, 9:21 PM
brooks committed rGe236502a997d: clnt_broadcast(3): fix eachresult argument type (authored by brooks).
clnt_broadcast(3): fix eachresult argument type
Feb 2 2026, 9:21 PM
brooks committed rG47413f23e503: clnt_broadcast(3): don't free function pointers (authored by brooks).
clnt_broadcast(3): don't free function pointers
Feb 2 2026, 9:21 PM
brooks closed D54941: rpc: correct resultproc_t's type.
Feb 2 2026, 9:21 PM
brooks closed D54940: clnt_broadcast(3): fix eachresult argument type.
Feb 2 2026, 9:21 PM
brooks closed D54939: clnt_broadcast(3): don't free function pointers.
Feb 2 2026, 9:20 PM
brooks committed R11:dcdd54847b9d: devel/llvm-cheri: new snapshot (authored by brooks).
devel/llvm-cheri: new snapshot
Feb 2 2026, 5:59 PM
brooks committed R11:75ec43cc2c95: devel/llvm-morello: new snapshot (authored by brooks).
devel/llvm-morello: new snapshot
Feb 2 2026, 5:59 PM
brooks committed R11:7c32287b8d20: devel/llvm22: 22.1.0 RC2 (authored by brooks).
devel/llvm22: 22.1.0 RC2
Feb 2 2026, 5:59 PM
brooks added a comment to D54939: clnt_broadcast(3): don't free function pointers.
In D54939#1258282, @jhb wrote:

I suspect the old code just predates reliable TLS support in the toolchain so was using the guts of the implementation for pthread_key.

Feb 2 2026, 4:46 PM
brooks added a comment to D55039: Introduce setrlimit_uid(2).

This makes me wonder why not setrlimit_type(id_t id, int /*idtype_t*/ type, int which, const struct rlimit *rlp), but it's not clear most types really want limits so it feels overall like premature generalization.

Feb 2 2026, 4:36 PM

Jan 30 2026

brooks updated the diff for D54941: rpc: correct resultproc_t's type.

rebase

Jan 30 2026, 9:17 AM
brooks updated the diff for D54940: clnt_broadcast(3): fix eachresult argument type.

proc not prot in clnt_broadcast_resultproc_t

Jan 30 2026, 9:17 AM
brooks added a comment to D54941: rpc: correct resultproc_t's type.

@brooks : not sure if my tree is out of date, but I found a few more references of potential concern:

% rg -l '\(resultproc_t\)' worktree/main/ | sort | sed -e 's,worktree/main/,,g'
...
usr.bin/rup/rup.c
usr.bin/rusers/rusers.c
usr.sbin/bootparamd/callbootd/callbootd.c
usr.sbin/ypbind/ypbind.c

Do those need to be changed?

Jan 30 2026, 9:15 AM
brooks added a comment to D54940: clnt_broadcast(3): fix eachresult argument type.

Question on naming. I would read "resultproc" as "result process". What does "resultprot" stands for?

Jan 30 2026, 9:07 AM

Jan 29 2026

brooks requested review of D54941: rpc: correct resultproc_t's type.
Jan 29 2026, 12:19 PM
brooks requested review of D54940: clnt_broadcast(3): fix eachresult argument type.
Jan 29 2026, 12:17 PM
brooks added a comment to D54939: clnt_broadcast(3): don't free function pointers.

Alternatively one could avoid passing free to thr_keycreate, but the complexity of the thr_keycreate approach doesn't seem worth it to save sizeof(void *) of TLS storage.

Jan 29 2026, 12:17 PM
brooks requested review of D54939: clnt_broadcast(3): don't free function pointers.
Jan 29 2026, 12:15 PM

Jan 28 2026

brooks accepted D54920: STACKALIGN: Reimplement in terms of __align_down.
Jan 28 2026, 10:12 AM

Jan 27 2026

brooks accepted D54894: wlanstat: Drop unneeded bsd.compiler.mk from Makefile.

NFC = "No functional change" in this context.

Jan 27 2026, 9:26 AM

Jan 26 2026

brooks accepted D54876: bsd.mkopt.mk: Allow OPT_FOO to be set to override FOO.

LGTM

Jan 26 2026, 10:18 AM

Jan 23 2026

brooks committed rGe17d7ab869bb: xdr_string: don't leak strings with xdr_free (authored by brooks).
xdr_string: don't leak strings with xdr_free
Jan 23 2026, 11:08 AM
brooks closed D54825: xdr_string: don't leak strings with xdr_free.
Jan 23 2026, 11:07 AM
brooks committed rGac5a19ec6989: rpc/xdr.h: make xdrproc_t always take two arguments (authored by brooks).
rpc/xdr.h: make xdrproc_t always take two arguments
Jan 23 2026, 11:07 AM
brooks closed D54824: rpc/xdr.h: make xdrproc_t always take two arguments.
Jan 23 2026, 11:07 AM

Jan 22 2026

brooks requested review of D54825: xdr_string: don't leak strings with xdr_free.
Jan 22 2026, 10:12 AM
brooks requested review of D54824: rpc/xdr.h: make xdrproc_t always take two arguments.
Jan 22 2026, 10:12 AM

Jan 20 2026

brooks accepted D54797: rpctls_impl.c: Use a direct cast to uintptr_t instead of __DECONST.
Jan 20 2026, 5:49 PM