Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (551 w, 2 d)

Recent Activity

Wed, Jan 22

brooks accepted D48598: firewire: Add deprecation notice.

👍 to the idea, possible text change

Wed, Jan 22, 10:50 PM

Tue, Jan 21

brooks accepted D48554: kgssapi: remove the gssd_syscall.

Maybe mention the switch to netlink in the commit message.

Tue, Jan 21, 10:28 PM
brooks added inline comments to D48552: kgssapi: use netlink RPC client to talk to gssd(8).
Tue, Jan 21, 10:27 PM
brooks committed rG6d48eafa334f: checkstyle9.pl: don't require Signed-off-by for committers (authored by brooks).
checkstyle9.pl: don't require Signed-off-by for committers
Tue, Jan 21, 10:05 PM

Thu, Jan 16

brooks accepted D48481: munmap.2: Add STANDARDS and note about portability.

Is the same true of len?

Thu, Jan 16, 5:36 PM

Wed, Jan 15

brooks accepted D48465: munmap.2: Unaligned addresses do not return error.

Ideally I'd like to see a note that the use of unaligned addresses is non-portable, but that's probably a separate commit.

Wed, Jan 15, 5:52 PM

Tue, Jan 14

brooks committed R11:e333e1ef9022: devel/llvm19: 19.1.7 release (authored by brooks).
devel/llvm19: 19.1.7 release
Tue, Jan 14, 10:35 PM

Mon, Jan 13

brooks committed R11:e57ed3cc60d3: devel/llvm-devel: new snapshot (authored by brooks).
devel/llvm-devel: new snapshot
Mon, Jan 13, 11:53 PM
brooks committed R11:66b3823c32b3: devel/llvm-devel: Fix !CLANG plist (authored by brooks).
devel/llvm-devel: Fix !CLANG plist
Mon, Jan 13, 11:53 PM
brooks committed R11:e08503b86df7: devel/llvm19: Fix !CLANG plist and OPENMP (authored by brooks).
devel/llvm19: Fix !CLANG plist and OPENMP
Mon, Jan 13, 11:53 PM
brooks committed R11:460b1965554d: devel/llvm18: Fix !CLANG plist (authored by brooks).
devel/llvm18: Fix !CLANG plist
Mon, Jan 13, 11:53 PM
brooks committed R11:11d0f00be180: devel/llvm17: Fix !CLANG plist (authored by brooks).
devel/llvm17: Fix !CLANG plist
Mon, Jan 13, 11:53 PM
brooks committed R11:d7d561d6af3d: devel/llvm16: Fix !CLANG plist (authored by brooks).
devel/llvm16: Fix !CLANG plist
Mon, Jan 13, 11:53 PM
brooks committed R11:f3f26e7c8480: devel/llvm-cheriot: Fix !CLANG plist (authored by brooks).
devel/llvm-cheriot: Fix !CLANG plist
Mon, Jan 13, 11:53 PM
brooks accepted D48450: Centralize and simpify implemention of some VM macros.
Mon, Jan 13, 7:39 PM

Fri, Jan 10

brooks committed R11:fce28cc18fe3: devel/llvm-cheriot: fix plist for EXTRAAS (authored by brooks).
devel/llvm-cheriot: fix plist for EXTRAAS
Fri, Jan 10, 8:03 PM
brooks committed R11:74fd03383b13: devel/llvm15: whitespace [NFC] (authored by brooks).
devel/llvm15: whitespace [NFC]
Fri, Jan 10, 6:54 PM
brooks committed R11:f7f5f916e676: devel/llvm-{cheri,morello}: add clang-tools-extras (authored by brooks).
devel/llvm-{cheri,morello}: add clang-tools-extras
Fri, Jan 10, 6:54 PM
brooks added a comment to D48408: kobj: convert KOBJOPLOOKUP() to returning pointer to function.

The change seems fine at a glance, but I'm not very familiar with this code.

Fri, Jan 10, 1:10 AM
brooks committed R11:9592edb43243: devel/llvm16: backport flang fixes for llvm19 (authored by brooks).
devel/llvm16: backport flang fixes for llvm19
Fri, Jan 10, 12:44 AM

Thu, Jan 9

brooks accepted D48339: build: Check NO_ROOT and METALOG for more targets.

Seems reasonable

Thu, Jan 9, 6:17 PM

Wed, Jan 8

brooks committed R11:cc5192d32c8a: devel/llvm-cheri: Actually add files/llvm## to patches (authored by brooks).
devel/llvm-cheri: Actually add files/llvm## to patches
Wed, Jan 8, 8:04 PM

Mon, Jan 6

brooks committed R11:dab073e2c95b: devel/llvm-cheri: Actually add files/llvm## to patches (authored by brooks).
devel/llvm-cheri: Actually add files/llvm## to patches
Mon, Jan 6, 4:39 PM

Sat, Jan 4

brooks committed R11:4ab154a90419: devel/llvm11: fix build without LLDB (authored by brooks).
devel/llvm11: fix build without LLDB
Sat, Jan 4, 1:32 AM
brooks committed R11:1afdc808e67b: devel/llvm-cheri: fix type (authored by brooks).
devel/llvm-cheri: fix type
Sat, Jan 4, 12:33 AM

Fri, Jan 3

brooks committed R11:1fadfc2262fc: devel/llvm-devel: new snapshot (authored by brooks).
devel/llvm-devel: new snapshot
Fri, Jan 3, 11:57 PM
brooks committed R11:57f97b36a7cf: devel/llvm*: flip LICENSE_FILE_BSD3CLAUSE setting [NFC] (authored by brooks).
devel/llvm*: flip LICENSE_FILE_BSD3CLAUSE setting [NFC]
Fri, Jan 3, 11:57 PM
brooks committed R11:4f177eced75e: devel/llvm*: LICENSE_DIR simplification (authored by brooks).
devel/llvm*: LICENSE_DIR simplification
Fri, Jan 3, 11:57 PM
brooks committed R11:d17143d1b73e: devel/llvm*: don't define the ARM license [NFC] (authored by brooks).
devel/llvm*: don't define the ARM license [NFC]
Fri, Jan 3, 11:57 PM
brooks committed R11:18840affe5cd: devel/llvm*: Always define LLVM2 license [NFC] (authored by brooks).
devel/llvm*: Always define LLVM2 license [NFC]
Fri, Jan 3, 11:57 PM
brooks committed R11:789df5a26d6d: devel/llvm-cheriot: remove stray patches (authored by brooks).
devel/llvm-cheriot: remove stray patches
Fri, Jan 3, 11:57 PM
brooks committed R11:56f3450f8ac1: devel/llvm-cheriot: new LLVM 17 based snapshot (authored by brooks).
devel/llvm-cheriot: new LLVM 17 based snapshot
Fri, Jan 3, 12:48 AM
brooks committed R11:f661b45b56e1: devel/llvm-cheri: minor tidying [NFC] (authored by brooks).
devel/llvm-cheri: minor tidying [NFC]
Fri, Jan 3, 12:48 AM
brooks committed R11:fc0da5a4bd0c: devel/llvm*: Allow LICENSE_FILE_BSD3CLAUSE to be pre-defined (authored by brooks).
devel/llvm*: Allow LICENSE_FILE_BSD3CLAUSE to be pre-defined
Fri, Jan 3, 12:48 AM
brooks committed R11:c85e97b99084: devel/llvm-cheri: new snapshot (authored by brooks).
devel/llvm-cheri: new snapshot
Fri, Jan 3, 12:48 AM
brooks committed R11:958435241fbb: devel/llvm-morello: New LLVM 15 based snapshot (authored by brooks).
devel/llvm-morello: New LLVM 15 based snapshot
Fri, Jan 3, 12:48 AM

Dec 18 2024

brooks accepted D48130: shar: add a deprecation notice.

I would definitely like it to be harder to create shar files. They may have served a purpose in the 80s, but now they are absurd.

Dec 18 2024, 3:26 PM
brooks committed R11:6f9523707b18: devel/llvm-devel: new snapshot (authored by brooks).
devel/llvm-devel: new snapshot
Dec 18 2024, 1:23 AM
brooks committed R11:48f0cebae826: textproc/mandoc: rename from mdocml (authored by brooks).
textproc/mandoc: rename from mdocml
Dec 18 2024, 1:23 AM
brooks committed R11:983003a6153f: devel/llvm19: 19.1.6 release (authored by brooks).
devel/llvm19: 19.1.6 release
Dec 18 2024, 1:23 AM
brooks committed R11:6333c7f1de04: devel/llvm-devel: build compiler-rt as a runtime (authored by brooks).
devel/llvm-devel: build compiler-rt as a runtime
Dec 18 2024, 1:23 AM

Dec 17 2024

brooks accepted D48121: release: Use NO_ROOT mode for bootonly and mini-memstick.
Dec 17 2024, 8:44 PM

Dec 16 2024

brooks accepted D48095: Makefile.inc1: Remove non-NO_ROOT cases from distributeworld.

I wouldn't be surprised if we find some cases where people have to adapt to this change, but I think it's the right one. Eventually we might even want to forbid root entirely for this target, but that may be a bridge too far.

Dec 16 2024, 9:23 PM

Dec 14 2024

brooks committed rG1ad44b7f0e0d: style: Allow C++ comments (authored by imp).
style: Allow C++ comments
Dec 14 2024, 12:13 AM
brooks committed rGecfe30854204: style(9): Add comments about branch prediction (authored by imp).
style(9): Add comments about branch prediction
Dec 14 2024, 12:13 AM
brooks committed rG76ec0faf1ce7: style(9): Delete __FBSDID straggler (authored by imp).
style(9): Delete __FBSDID straggler
Dec 14 2024, 12:13 AM
brooks committed rG2317a685241a: style(9): Note larger divergence than implied (authored by imp).
style(9): Note larger divergence than implied
Dec 14 2024, 12:13 AM
brooks committed rG9bc9cf4a2ae7: style(9): deprecate blank lines without local vars (authored by brooks).
style(9): deprecate blank lines without local vars
Dec 14 2024, 12:13 AM
brooks committed rG866420279949: style(9): Remove $FreeBSD$ recommendation. (authored by minsoochoo0122_proton.me).
style(9): Remove $FreeBSD$ recommendation.
Dec 14 2024, 12:13 AM
brooks committed rG960665e47f0b: style(9): Remove ancient SCCS tags. (authored by brooks).
style(9): Remove ancient SCCS tags.
Dec 14 2024, 12:13 AM

Dec 13 2024

brooks committed rGc71b427bfa9a: nvi: Replace Clang-only __builtin_is_aligned with C code (#124) (authored by lichray_gmail.com).
nvi: Replace Clang-only __builtin_is_aligned with C code (#124)
Dec 13 2024, 9:50 PM
brooks committed rG3e9f61464ee3: nvi: use memmove to realign buffers (authored by brooks).
nvi: use memmove to realign buffers
Dec 13 2024, 9:50 PM
brooks committed rGf69b6410a632: depend-cleanup.sh: Extend clean_dep to support a custom regex (authored by jrtc27).
depend-cleanup.sh: Extend clean_dep to support a custom regex
Dec 13 2024, 9:05 PM
brooks added inline comments to D41421: Update jemalloc to version 5.3.0.
Dec 13 2024, 8:10 PM · Contributor Reviews (src)
brooks added a comment to D48030: Makefile.inc1: Require DISTDIR be set for `make distributeworld`.

This seems like a good change. I have some vague memories about complaints when I changed things in this area, but I think that might have been the largely unrelated "distribution" target.

Dec 13 2024, 5:29 PM

Dec 12 2024

brooks added inline comments to D48010: Makefile.inc1: Make reproducible release tarballs.
Dec 12 2024, 10:08 PM
brooks added inline comments to D48010: Makefile.inc1: Make reproducible release tarballs.
Dec 12 2024, 9:56 PM
brooks added inline comments to D48010: Makefile.inc1: Make reproducible release tarballs.
Dec 12 2024, 4:43 PM
brooks committed rG7d0d52fc7c53: distributeworld: dedup dist(.debug).meta generation (authored by brooks).
distributeworld: dedup dist(.debug).meta generation
Dec 12 2024, 4:30 PM
brooks closed D48038: distributeworld: dedup dist(.debug).meta generation.
Dec 12 2024, 4:30 PM
brooks accepted D48041: release: Always use NO_ROOT for distribute* and package*.

Seems like a good first step

Dec 12 2024, 3:00 PM

Dec 11 2024

brooks requested review of D48038: distributeworld: dedup dist(.debug).meta generation.
Dec 11 2024, 8:49 PM
brooks committed rGb9cf179622ba: libsys/i386/Symbol.sys.map: sort symbol names (authored by brooks).
libsys/i386/Symbol.sys.map: sort symbol names
Dec 11 2024, 8:33 PM

Dec 10 2024

brooks added inline comments to D48010: Makefile.inc1: Make reproducible release tarballs.
Dec 10 2024, 12:16 AM

Dec 9 2024

brooks added a comment to D48010: Makefile.inc1: Make reproducible release tarballs.

Looks like a generally viable solution to me.

Dec 9 2024, 11:51 PM
brooks committed rG6608a478cddb: depend-cleanup.sh: Extend clean_dep to support a custom regex (authored by jrtc27).
depend-cleanup.sh: Extend clean_dep to support a custom regex
Dec 9 2024, 9:50 PM
brooks added a reverting change for rG210ff8644846: depend-cleanup: fix after 99b2ab71c5b6: rG91549cf666db: Revert "depend-cleanup: fix after 99b2ab71c5b6".
Dec 9 2024, 9:50 PM
brooks committed rG50291c77306b: depend-cleanup.sh: Generalise lib32 code and avoid duplication (authored by jrtc27).
depend-cleanup.sh: Generalise lib32 code and avoid duplication
Dec 9 2024, 9:50 PM
brooks committed rG0f00a4c39b65: depend-cleanup: Add verbose (-v) and pretend/dry-run (-n) flags (authored by jrtc27).
depend-cleanup: Add verbose (-v) and pretend/dry-run (-n) flags
Dec 9 2024, 9:49 PM
brooks committed rG37d2e25a2dc7: Make sure MACHINE(_ARCH) are exported for depend-cleanup.sh (authored by jrtc27).
Make sure MACHINE(_ARCH) are exported for depend-cleanup.sh
Dec 9 2024, 9:49 PM
brooks committed rG82fcae46051c: depend-cleanup.sh: Simplify the logic, and clean bootstrap tools. (authored by des).
depend-cleanup.sh: Simplify the logic, and clean bootstrap tools.
Dec 9 2024, 9:49 PM
brooks committed rG91549cf666db: Revert "depend-cleanup: fix after 99b2ab71c5b6" (authored by brooks).
Revert "depend-cleanup: fix after 99b2ab71c5b6"
Dec 9 2024, 9:49 PM
brooks committed rG3ca117c6bb1d: mandoc: drop 3p section (authored by brooks).
mandoc: drop 3p section
Dec 9 2024, 5:56 PM
brooks closed D47948: mandoc: drop 3p section.
Dec 9 2024, 5:56 PM

Dec 6 2024

brooks requested review of D47948: mandoc: drop 3p section.
Dec 6 2024, 9:13 PM
brooks committed rGc1c95add8c80: Merge mandoc snapshot 2024-09-22 (authored by brooks).
Merge mandoc snapshot 2024-09-22
Dec 6 2024, 8:59 PM
brooks committed rG0fd7b4655666: mandoc: remove duplicate libstdthreads entry (authored by brooks).
mandoc: remove duplicate libstdthreads entry
Dec 6 2024, 8:59 PM
brooks committed rG20de55b07cf9: Vendor import of mandoc as of 2024-09-22 (authored by brooks).
Vendor import of mandoc as of 2024-09-22
Dec 6 2024, 8:58 PM

Dec 5 2024

brooks accepted D47618: New setcred() system call and associated MAC hooks.
Dec 5 2024, 10:26 PM
brooks committed rG028dae5d3e88: style(9): fix typo (authored by brooks).
style(9): fix typo
Dec 5 2024, 5:30 PM

Dec 4 2024

brooks committed rGebfb117e2e04: style(9): deprecate blank lines without local vars (authored by brooks).
style(9): deprecate blank lines without local vars
Dec 4 2024, 9:44 PM
brooks closed D47887: style(9): deprecate blank lines without local vars.
Dec 4 2024, 9:44 PM
brooks added inline comments to D47618: New setcred() system call and associated MAC hooks.
Dec 4 2024, 9:26 PM
brooks committed R11:8c3ffbca3d6e: devel/llvm-devel: new snapshot (authored by brooks).
devel/llvm-devel: new snapshot
Dec 4 2024, 8:41 PM
brooks committed R11:fd0b4dec18dd: devel/llvm19: 19.1.5 (authored by brooks).
devel/llvm19: 19.1.5
Dec 4 2024, 8:41 PM
brooks accepted D47618: New setcred() system call and associated MAC hooks.

Looks good! A few quibbles (mostly things that would make things easier for use in CheriBSD), but nothing mandatory.

Dec 4 2024, 6:32 PM
brooks accepted D47878: MAC: syscalls: mac_label_copyin(): 32-bit compatibility.
Dec 4 2024, 4:29 PM
brooks added a comment to D47887: style(9): deprecate blank lines without local vars.

I've tempered the commit message text.

Dec 4 2024, 4:17 PM
brooks updated the summary of D47887: style(9): deprecate blank lines without local vars.
Dec 4 2024, 4:14 PM

Dec 3 2024

brooks added inline comments to D47618: New setcred() system call and associated MAC hooks.
Dec 3 2024, 9:22 PM
brooks requested review of D47887: style(9): deprecate blank lines without local vars.
Dec 3 2024, 7:22 PM
brooks added a comment to D47618: New setcred() system call and associated MAC hooks.

Oops, it looks like our last comments raced.

Dec 3 2024, 7:02 PM
brooks requested changes to D47618: New setcred() system call and associated MAC hooks.
Dec 3 2024, 6:05 PM
brooks added inline comments to D47878: MAC: syscalls: mac_label_copyin(): 32-bit compatibility.
Dec 3 2024, 5:56 PM

Nov 27 2024

brooks committed rG06a98fefd3d3: nvi: Replace Clang-only __builtin_is_aligned with C code (#124) (authored by lichray_gmail.com).
nvi: Replace Clang-only __builtin_is_aligned with C code (#124)
Nov 27 2024, 6:39 PM
brooks committed rG56ef9c872bc5: nvi: use memmove to realign buffers (authored by brooks).
nvi: use memmove to realign buffers
Nov 27 2024, 6:21 PM

Nov 20 2024

brooks accepted D47589: getentropy: note that it is nearly POSIX 2024.
Nov 20 2024, 7:24 PM

Nov 19 2024

brooks closed D47258: Mk/Uses/sbrk.mk: centralize sbrk handling.
Nov 19 2024, 5:31 PM
brooks committed R11:f6132c416155: Mk/Uses/sbrk.mk: centralize sbrk handling (authored by brooks).
Mk/Uses/sbrk.mk: centralize sbrk handling
Nov 19 2024, 5:31 PM
brooks committed R11:705ee5784b0b: devel/llvm19: 19.1.4 release (authored by brooks).
devel/llvm19: 19.1.4 release
Nov 19 2024, 5:31 PM