Page MenuHomeFreeBSD
Differential D49141

makefs: Make Rock Ridge inode assignment reproducible
ClosedPublic
Actions

Authored by emaste on Feb 26 2025, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:06 AM
Unknown Object (File)
Sat, Sep 27, 1:27 AM
Unknown Object (File)
Fri, Sep 26, 4:15 PM
Unknown Object (File)
Fri, Sep 26, 3:25 AM
Unknown Object (File)
Thu, Sep 25, 2:00 PM
Unknown Object (File)
Fri, Sep 19, 12:43 PM
Unknown Object (File)
Sep 4 2025, 2:43 AM
Unknown Object (File)
Aug 20 2025, 12:10 AM
View All 44 Files
Subscribers
brooks
imp

Details

Reviewers
brooks
Commits
rGe4bcef6daba7: makefs: Make cd9660 Rock Ridge inodes reproducible
rG518cdd344ec5: makefs: Make cd9660 Rock Ridge inodes reproducible
Summary

Assign Rock Ridge File Serial Numbers (inodes) sequentially rather than passing the inode from the underlying filesystem through.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Feb 26 2025, 7:01 PM
emaste created this revision.
emaste mentioned this in D49134: makefs: Record inode for all entries.Feb 27 2025, 1:25 PM
emaste added inline comments.Feb 27 2025, 1:30 PM
usr.sbin/makefs/cd9660/iso9660_rrip.c
663

makefs's mtree support sets st_ino only if the file has st_nlink > 1

will add a comment here

emaste added a child revision: D48121: release: Use unprivileged mode for bootonly and mini-memstick.Feb 27 2025, 2:58 PM
emaste mentioned this in D48121: release: Use unprivileged mode for bootonly and mini-memstick.
brooks accepted this revision.Feb 28 2025, 7:48 PM
brooks added a subscriber: brooks.

Seems reasonable.

This revision is now accepted and ready to land.Feb 28 2025, 7:48 PM
Closed by commit rG518cdd344ec5: makefs: Make cd9660 Rock Ridge inodes reproducible (authored by emaste). · Explain WhyFeb 28 2025, 8:35 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG518cdd344ec5: makefs: Make cd9660 Rock Ridge inodes reproducible.
Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2025, 8:35 PM
emaste added a commit: rGe4bcef6daba7: makefs: Make cd9660 Rock Ridge inodes reproducible.Mar 4 2025, 8:59 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
12 lines
cd9660/
2 lines
67 lines

Diff 151698

View Options

usr.sbin/makefs/cd9660.h

Loading...
View Options

usr.sbin/makefs/cd9660/iso9660_rrip.h

Loading...
View Options

usr.sbin/makefs/cd9660/iso9660_rrip.c

Loading...