Page MenuHomeFreeBSD

release/vm: partially support NO_ROOT
ClosedPublic

Authored by brooks on Mar 11 2025, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 8:04 AM
Unknown Object (File)
Mon, Sep 22, 5:23 PM
Unknown Object (File)
Sat, Sep 20, 2:41 AM
Unknown Object (File)
Thu, Sep 18, 10:52 AM
Unknown Object (File)
Wed, Sep 17, 2:56 PM
Unknown Object (File)
Sun, Sep 14, 9:07 AM
Unknown Object (File)
Sep 10 2025, 2:18 AM
Unknown Object (File)
Aug 29 2025, 1:34 PM
Subscribers

Details

Summary

For images that don't require QEMU, support NO_ROOT. This entails:

  • Passing NO_ROOT down to mk-vmimage.sh (which sets it for installworld, etc)
  • Handling etcupdate bootstrapping
  • Adding assorted config file METALOG entries
  • Running makefs in the right directory and adding -D for dups

The main gap in NO_ROOT support is package installation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

release/tools/vmimage.subr
71–78

${NO_ROOT:+-N} and drop the var?

211–212

Why the cd if you also use DESTDIR in sourcepath? (I can guess why the cd, but then should sourcepath not just be .[/METALOG]?)

Implement suggetions from @jrtc27

  • Use shell variable substitutions instead of temporaries
  • Use DESTDIR-relative paths in makefs calls

Looks reasonable. Perhaps also add comments on cases that still need NO_ROOT support?

release/tools/vmimage.subr
72

Add a comment here?

This revision is now accepted and ready to land.Mar 12 2025, 12:46 PM
  • Add a comment about the etcupdate metalog bits
  • Require that both or neither of WITHOUT_QEMU and NO_ROOT be set
This revision now requires review to proceed.Mar 12 2025, 5:49 PM
This revision is now accepted and ready to land.Mar 12 2025, 5:59 PM
  • fix BASIC-CI images (missing files)
  • add some more abstraction to reduce the overall diff
This revision now requires review to proceed.Mar 12 2025, 7:43 PM
This revision is now accepted and ready to land.Mar 12 2025, 7:45 PM
This revision was automatically updated to reflect the committed changes.