release/vm: empty sh functions are disallowed
ClosedPublic
Actions

Authored by brooks on Mar 26 2025, 6:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 16, 2:32 AM

	Unknown Object (File)
	Thu, Sep 10, 3:24 PM

	Unknown Object (File)
	Wed, Sep 9, 10:08 AM

	Unknown Object (File)
	Sun, Sep 6, 10:09 AM

	Unknown Object (File)
	Sat, Sep 5, 1:16 PM

	Unknown Object (File)
	Sat, Sep 5, 9:48 AM

	Unknown Object (File)
	Sat, Sep 5, 4:16 AM

	Unknown Object (File)
	Sat, Sep 5, 3:54 AM

View All Files

Subscribers

imp

jrtc27

Details

Reviewers

emaste

Group Reviewers

releng

Commits

rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed

Summary

This happens to work with FreeBSD's shell, but is rejected by dash and
bash.

Reported by: def
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 26 2025, 6:57 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMar 26 2025, 6:57 PM

brooks requested review of this revision.Mar 26 2025, 6:57 PM

Harbormaster completed remote builds in B63142: Diff 152713.Mar 26 2025, 6:57 PM

emaste accepted this revision as: emaste.Mar 26 2025, 7:00 PM

This revision is now accepted and ready to land.Mar 26 2025, 7:00 PM

Closed by commit rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed (authored by brooks). · Explain WhyMar 27 2025, 4:04 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed.

Revision Contents
Changeset List

Path

Size

release/

tools/

vmimage.subr

1 line

Diff 152751

View Options

release/tools/vmimage.subr

release/vm: empty sh functions are disallowedClosedPublicActions