release/vm: empty sh functions are disallowed
ClosedPublic
Actions

Authored by brooks on Mar 26 2025, 6:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 5 2025, 6:54 PM

	Unknown Object (File)
	Oct 27 2025, 2:48 AM

	Unknown Object (File)
	Oct 26 2025, 10:50 PM

	Unknown Object (File)
	Oct 26 2025, 9:51 PM

	Unknown Object (File)
	Oct 26 2025, 4:19 PM

	Unknown Object (File)
	Oct 21 2025, 12:20 AM

	Unknown Object (File)
	Oct 20 2025, 1:39 AM

	Unknown Object (File)
	Oct 2 2025, 12:58 PM

View All 42 Files

Subscribers

imp

jrtc27

Details

Reviewers

emaste

Group Reviewers

releng

Commits

rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed

Summary

This happens to work with FreeBSD's shell, but is rejected by dash and
bash.

Reported by: def
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63142
Build 60026: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 26 2025, 6:57 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMar 26 2025, 6:57 PM

brooks requested review of this revision.Mar 26 2025, 6:57 PM

Harbormaster completed remote builds in B63142: Diff 152713.Mar 26 2025, 6:57 PM

emaste accepted this revision as: emaste.Mar 26 2025, 7:00 PM

This revision is now accepted and ready to land.Mar 26 2025, 7:00 PM

Closed by commit rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed (authored by brooks). · Explain WhyMar 27 2025, 4:04 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed.

Revision Contents
Changeset List

Path

Size

release/

tools/

vmimage.subr

1 line

Diff 152713

View Options

release/tools/vmimage.subr

release/vm: empty sh functions are disallowedClosedPublicActions