Differential D49351

sysctl: Panic on OID reuse
ClosedPublic
Actions

Authored by markj on Mar 14 2025, 1:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 3:16 AM

	Unknown Object (File)
	Tue, Oct 14, 3:16 AM

	Unknown Object (File)
	Mon, Oct 13, 8:22 PM

	Unknown Object (File)
	Mon, Oct 13, 4:29 AM

	Unknown Object (File)
	Sun, Oct 5, 3:12 AM

	Unknown Object (File)
	Fri, Oct 3, 1:28 PM

	Unknown Object (File)
	Fri, Oct 3, 11:22 AM

	Unknown Object (File)
	Fri, Oct 3, 2:01 AM

View All 57 Files

Subscribers

Details

Reviewers

jhb
kib
brooks

Commits

rG4f3ce62ff7ef: sysctl: Panic on OID reuse
rGd35c4cfad580: sysctl: Panic on OID reuse

Summary

In CheriBSD we had a conflict in the KERN_PROC OID space and didn't
notice for some time. Let's panic instead to make such conflicts easier
to detect. Note that this doesn't affect conflicts arising from name
collisions in OID_AUTO sysctls, which happen sometimes due to driver
bugs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 14 2025, 1:43 AM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 14 2025, 1:43 AM

markj requested review of this revision.Mar 14 2025, 1:43 AM

Harbormaster completed remote builds in B62912: Diff 152242.Mar 14 2025, 1:44 AM

jhb accepted this revision.Mar 14 2025, 1:20 PM

This revision is now accepted and ready to land.Mar 14 2025, 1:20 PM

kib accepted this revision.Mar 14 2025, 2:29 PM

brooks accepted this revision.Mar 24 2025, 7:42 PM

Closed by commit rGd35c4cfad580: sysctl: Panic on OID reuse (authored by markj). · Explain WhyApr 5 2025, 4:31 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd35c4cfad580: sysctl: Panic on OID reuse.

markj added a commit: rG4f3ce62ff7ef: sysctl: Panic on OID reuse.May 6 2025, 2:16 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 153175

sys/kern/kern_sysctl.c

Loading...