libc: use sys_realpathat directly in realpath
ClosedPublic
Actions

Authored by brooks on Feb 18 2025, 6:38 PM.

Details

Reviewers

Commits

rGed955671d2e8: libc: use __sys___realpathat directly in realpath

Summary

We don't need to use an interposable symbol for this purpose and it's
simpler to just call the syscall in libsys. The to another bug (fixed
in the next commit) we were incorrectly using __realpathat in libc not
libsys.

While here, drop support for running on a FreeBSD 12 kernel and simplify
includes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Feb 18 2025, 6:38 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 18 2025, 6:38 PM

brooks requested review of this revision.Feb 18 2025, 6:38 PM

Harbormaster completed remote builds in B62503: Diff 151154.Feb 18 2025, 6:38 PM

brooks added a child revision: D49049: libsys: Don't create or expose __realpathat.Feb 18 2025, 6:38 PM

kib accepted this revision.Feb 19 2025, 11:14 AM

This revision is now accepted and ready to land.Feb 19 2025, 11:14 AM

"The to another bug" in the summary is either a too advanced english (for me) or a typo.

In D49048#1118546, @kib wrote:

"The to another bug" in the summary is either a too advanced english (for me) or a typo.

It's me editing the message too many times and doing it badly. I mean to say something like "This lead to a bug where we were incorrectly using __realpathat in libc not
libsys."

Closed by commit rGed955671d2e8: libc: use __sys___realpathat directly in realpath (authored by brooks). · Explain WhyFeb 19 2025, 4:55 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGed955671d2e8: libc: use __sys___realpathat directly in realpath.