Page MenuHomeFreeBSD

libc: use __sys___realpathat directly in realpath
ClosedPublic

Authored by brooks on Feb 18 2025, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 2:01 AM
Unknown Object (File)
Fri, Oct 3, 4:40 PM
Unknown Object (File)
Fri, Oct 3, 5:03 AM
Unknown Object (File)
Fri, Oct 3, 1:43 AM
Unknown Object (File)
Thu, Oct 2, 4:46 PM
Unknown Object (File)
Thu, Sep 25, 5:33 PM
Unknown Object (File)
Mon, Sep 22, 8:58 AM
Unknown Object (File)
Aug 23 2025, 12:18 AM
Subscribers

Details

Summary

We don't need to use an interposable symbol for this purpose and it's
simpler to just call the syscall in libsys. The to another bug (fixed
in the next commit) we were incorrectly using __realpathat in libc not
libsys.

While here, drop support for running on a FreeBSD 12 kernel and simplify
includes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 19 2025, 11:14 AM

"The to another bug" in the summary is either a too advanced english (for me) or a typo.

In D49048#1118546, @kib wrote:

"The to another bug" in the summary is either a too advanced english (for me) or a typo.

It's me editing the message too many times and doing it badly. I mean to say something like "This lead to a bug where we were incorrectly using __realpathat in libc not
libsys."