Committed as rS346574 and rS346576.

Move the SUBDIR+= profile outside the architecture dependent blocks

In D20005#429909, @lwhsu wrote:

Thanks for the better fix. BTW, I still think these checks would be better to be rewritten as getting the real number and compare with 65535.

I've proposed a different solution in D20005.

This moved SUBDIR+= profile inside another .if block :/...

Sidenote: given that it's been over 2 weeks since you put this out for review, I think you can put in Approved by: jmg (maintainer timeout) and commit the change.

Requesting changes because there are a handful of non-style nits that should be resolved before this is committed to ^/head .

LGTM! Please commit this change to ^/head.

Fix accidental diff update in last revision

That's not what I wanted to do >_>...

Update the comment

In D19906#427977, @asomers wrote:

That's a lot of tiny files! Would it be possible and desirable to reduce the file count by using here documents or something?

I reworded the commit message/review name. Please use -g, not -d.

Try again with a patched libcurl

Let's try triggering the issue in bug 233177 again

Sort the Makefile variables per style.Makefile(9)

Remove bogus (unsigned) cast with call to MIN().

In D19854#426171, @asomers wrote:

I don't know why you added a blank line at 179, but otherwise LGTM.