Page MenuHomeFreeBSD

Use more descriptive algorithm names in skip messages.
ClosedPublic

Authored by jhb on Apr 19 2019, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:32 AM
Unknown Object (File)
Oct 24 2024, 3:26 PM
Unknown Object (File)
Oct 8 2024, 5:44 PM
Unknown Object (File)
Sep 27 2024, 4:40 AM
Unknown Object (File)
Sep 25 2024, 9:54 PM
Unknown Object (File)
Sep 19 2024, 1:29 PM
Unknown Object (File)
Sep 16 2024, 9:32 AM
Unknown Object (File)
Sep 4 2024, 11:11 PM
Subscribers

Details

Test Plan
  • faked that ccr0 couldn't do AES in cryptotest.py and then ran it with -v.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

No objection, although it's somewhat moot because the lists are shared (aesmodules, shamodules). Unless you plan to change that.

This revision is now accepted and ready to land.Apr 19 2019, 10:17 PM

It is mostly moot and I don't really plan to change it currently. At some point I might instead make it just try to create a single test session for each algorithm up front and skip if it gets EOPNOTSUPP. It also should not have a hardcoded list of device names. It should really take an optional command line argument for what devices you want to test or use some method to enumerate the available devices (might have to add something to OCF to support the latter).

ngie added a subscriber: ngie.

LGTM! Please commit this change to ^/head.

This revision was automatically updated to reflect the committed changes.