Page MenuHomeFreeBSD

Build libclang_rt/profile on all clang-supported architectures
ClosedPublic

Authored by ngie on Apr 22 2019, 5:57 AM.

Details

Summary

There's no reason why a special case needs to be added specifically for amd64,
arm, and i386, as the code is written in machine architecture agnostic C/C++.

This will make it possible for all supporting clang architectures to produce
runtime coverage with --coverage.

MFC after: 2 weeks

Test Plan

"make tinderbox"

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ngie created this revision.Apr 22 2019, 5:57 AM
ngie retitled this revision from Build libclang_rt/profile on all clang-supported architectures <<Replace this line with your revision title> to Build libclang_rt/profile on all clang-supported architectures.Apr 22 2019, 5:57 AM
ngie planned changes to this revision.Apr 22 2019, 7:56 AM

This moved SUBDIR+= profile inside another .if block :/...

dim accepted this revision.Apr 22 2019, 7:12 PM

IIRC in the past I tried this on other architectures, and got errors, but if you've ran universe or tinderbox builds with this, I'm fine with it.

ngie updated this revision to Diff 56508.Apr 22 2019, 7:18 PM

Move the SUBDIR+= profile outside the architecture dependent blocks

Tested with "make universe", including the relevant change (^/projects/runtime-coverage-v2@r346532).

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2019, 7:21 PM
This revision was automatically updated to reflect the committed changes.