Differential D20003

Build libclang_rt/profile on all clang-supported architectures
ClosedPublic
Actions

Authored by ngie on Apr 22 2019, 5:57 AM.

Details

Reviewers

dim
emaste
jtl

Commits

rS346578: Build libclang_rt/profile on all clang-supported architectures

Summary

There's no reason why a special case needs to be added specifically for amd64,
arm, and i386, as the code is written in machine architecture agnostic C/C++.

This will make it possible for all supporting clang architectures to produce
runtime coverage with --coverage.

MFC after: 2 weeks

Test Plan

"make tinderbox"

Diff Detail

Repository

rS FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ngie created this revision.Apr 22 2019, 5:57 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 22 2019, 5:57 AM

Harbormaster completed remote builds in B23809: Diff 56469.Apr 22 2019, 5:57 AM

ngie retitled this revision from Build libclang_rt/profile on all clang-supported architectures <<Replace this line with your revision title> to Build libclang_rt/profile on all clang-supported architectures.Apr 22 2019, 5:57 AM

This moved SUBDIR+= profile inside another .if block :/...

IIRC in the past I tried this on other architectures, and got errors, but if you've ran universe or tinderbox builds with this, I'm fine with it.

Move the SUBDIR+= profile outside the architecture dependent blocks

Tested with "make universe", including the relevant change (^/projects/runtime-coverage-v2@r346532).

Harbormaster completed remote builds in B23830: Diff 56508.Apr 22 2019, 7:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2019, 7:21 PM

Closed by commit rS346578: Build libclang_rt/profile on all clang-supported architectures (authored by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			head/lib/libclang_rt/Makefile (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56469	346526		Apr 22 2019, 5:57 AM	★	★
Diff 2	56508	346572	Move the `SUBDIR+= profile` outside the architecture dependent blocks	Apr 22 2019, 7:18 PM	★	★
Diff 3	56509	346577	rS346578	Apr 22 2019, 7:21 PM	★	★

Diff 56509

View Options

head/lib/libclang_rt/Makefile

Build libclang_rt/profile on all clang-supported architecturesClosedPublicActions