Page MenuHomeFreeBSD
Differential D20003

Build libclang_rt/profile on all clang-supported architectures
ClosedPublic
Actions

Authored by ngie on Apr 22 2019, 5:57 AM.
Tags
None
Referenced Files
F103446747: D20003.diff
Mon, Nov 25, 3:35 AM
Unknown Object (File)
Sat, Nov 23, 10:19 PM
Unknown Object (File)
Sat, Nov 23, 1:48 PM
Unknown Object (File)
Oct 3 2024, 12:02 AM
Unknown Object (File)
Sep 8 2024, 7:50 PM
Unknown Object (File)
Sep 5 2024, 9:04 AM
Unknown Object (File)
Aug 15 2024, 10:20 AM
Unknown Object (File)
Aug 2 2024, 4:37 AM
View All 46 Files
Subscribers
imp

Details

Reviewers
dim
emaste
jtl
Commits
rS346578: Build libclang_rt/profile on all clang-supported architectures
Summary

There's no reason why a special case needs to be added specifically for amd64,
arm, and i386, as the code is written in machine architecture agnostic C/C++.

This will make it possible for all supporting clang architectures to produce
runtime coverage with --coverage.

MFC after: 2 weeks

Test Plan

"make tinderbox"

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23830
Build 22770: arc lint + arc unit

Event Timeline

ngie created this revision.Apr 22 2019, 5:57 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 22 2019, 5:57 AM
Harbormaster completed remote builds in B23809: Diff 56469.Apr 22 2019, 5:57 AM
ngie retitled this revision from Build libclang_rt/profile on all clang-supported architectures <<Replace this line with your revision title> to Build libclang_rt/profile on all clang-supported architectures.Apr 22 2019, 5:57 AM
ngie planned changes to this revision.Apr 22 2019, 7:56 AM

This moved SUBDIR+= profile inside another .if block :/...

dim accepted this revision.Apr 22 2019, 7:12 PM

IIRC in the past I tried this on other architectures, and got errors, but if you've ran universe or tinderbox builds with this, I'm fine with it.

ngie updated this revision to Diff 56508.Apr 22 2019, 7:18 PM

Move the SUBDIR+= profile outside the architecture dependent blocks

Tested with "make universe", including the relevant change (^/projects/runtime-coverage-v2@r346532).

Harbormaster completed remote builds in B23830: Diff 56508.Apr 22 2019, 7:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2019, 7:21 PM
Closed by commit rS346578: Build libclang_rt/profile on all clang-supported architectures (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libclang_rt/
3 lines

Diff 56508

View Options

lib/libclang_rt/Makefile

Loading...