You're welcome :) __/||\__

I think it was parallel work in same time ``:-] 😅
Already fixed on --> https://reviews.freebsd.org/D11648

In D11554#241100, @cpm wrote:

I'm a bit off for incoming changes because I'm testing chromium build on arm64 (thanks to @andrew) but at first sight it looks good to me. It's still building....

This can be speeded up by providing the poudriere build logs. Luca, would you mind providing us a poudriere build log for the supported releases?

Thanks for your work.

Thanks a lot.
I'll add one of chromium@ people here too.

-Rename devel/gn to devel/chromium-gn regarding to package name

-Rename devel/gn to devel/chromium-gn regarding to package name

-Delete unneeded ?= symbols from chromium Makefile
-Delete redundant PORTNAME from slave port

Use the ${RLN} instead of {LN} as @mat suggested.

-Fix brainmelting part (complex/unclear ifs in Makefile)
-Revert a locally commented part

To me it seems fine.
I'll wait for @mat or @feld comments also.
Then hopefully I can commit it :-)

Fix some points to make it build in a clean poudriere jail:

• Change portname in a more meaningful thing as a slaveport (Added a PKGNAME_SUFFIX) This actually will help us not redifining DISTNAME, And because of that make makesum wont break the master port's distinfo. This also helps the revision of the slaveport meaningfully being bumped with its master port.
• Add TEST_DISTFILES to both master and slave ports
• Fix LICENSE Error

Tested via poudriere and portlint.
it's fine.

Okay, with changes applied I successfully built mysql57 without anything bad happening.
Seems good to me 😄

To me it seems good idea, I haven't applied/tested the patch yet though.
Shouldn't we also change Makefiles of mysql variants to make it work?

@feld Thanks
@wjw_digiware.nl Am going to commit it soon.

Thanks :)

Yeah, preferably do this please.
So @mat can view the changes easier too.

Okay, I did also QA on it [with added as option, on the patch attached to PR] too, It's okay.
So I did maintainer-approval '+' on it.

Hmm, I made another change on this, I'd say it's better to add this as option, to [at least] not make surprise for people/companies who currently not expecting this option as default.
I'll upload my changes plus what @mat suggests to the PR you opened for this, would you please update this diff with that?

In D9584#208091, @wjw_digiware.nl wrote:

In D9584#208085, @mmokhi wrote:

Hmm, yeah.
@feld I'd suggest to test the patch that I attached on the PR (or @wjw_digiware.nl can update diffs here :D)
I forgot to state this problem on PR (but it's fixed on attached patch) that recently things are added to GID/UID files right before our entry, which makes this patch fail.

Oke, I see... Sorry about this.
It took me about a year to get used to the processes in the Ceph community, so I'll manage here as well.
Will work on it tonight. Doesn't seem like much work, and then both sides are again equal.
Should prevent a lot of annoyance.

Hmm, yeah.
@feld I'd suggest to test the patch that I attached on the PR (or @wjw_digiware.nl can update diffs here :D)
I forgot to state this problem on PR (but it's fixed on attached patch) that recently things are added to GID/UID files right before our entry, which makes this patch fail.

Added my mentors for review-before-commit process. (@mat is already here, I added @feld too)
I made few small changes (regenerated distinfo, on PR-attached patch @wjw_digiware.nl confirmed it builds fine

@ngie It's committed by another committer AFAIK,
How can we close this review?

In D9849#203619, @mat wrote:

In D9849#203617, @mmokhi wrote:

Some of the changes are made on net/py-eventlet (updating it to latest version)
I should wait for @cs approval on their port too, yeah?

The mentor approval is an added step in the normal pipe of steps that you have to follow when committing things in the ports tree, we're here to make sure you're not doing silly things.

So you still have to wait for cs@'s approval for his port.

Oops :)
One more question mentor, before I commit it.
Some of the changes are made on net/py-eventlet (updating it to latest version)
I should wait for @cs approval on their port too, yeah?