inet/ceph-devel: bimonthly ports update v2017-07-27
ClosedPublic
Actions

Authored by wjw_digiware.nl on Jul 28 2017, 8:00 AM.

Details

Reviewers

mmokhi
asomers
pi

Commits

rP447772: net/ceph-devel: update wip.v2017-05-01 -> wip.v2017-07-27-1

Summary

The "bimonthly" port upgrade to the current state of affairs.
This version is more or less equal to

12.1.2 Luminous RC2

Major diffrence is that it also incluse the code for rbd-ggate, which allows to mount ceph-pools as raw device. (/dev/ggate)

ceph-fuse is working, albeit slow and typical fuse style.

Test Plan

Ceph is extensively tested by Jenkins at:

http://cephdev.digiware.nl:8180/jenkins

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wjw_digiware.nl created this revision.Jul 28 2017, 8:00 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptJul 28 2017, 8:00 AM

Harbormaster completed remote builds in B10725: Diff 31299.Jul 28 2017, 8:00 AM

wjw_digiware.nl added reviewers: mmokhi, asomers.Jul 28 2017, 8:05 AM

mmokhi added inline comments.Jul 28 2017, 11:31 AM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	Maybe you can add this to LIB_DEPENDS? without `${LOCALBASE}` part

wjw_digiware.nl added inline comments.Jul 28 2017, 11:47 AM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	This was already in the original patch, and I think we had some discussion on it there too. What I remember is that `LIB_DEPENDS` only likes `.so` files. But I'll give it a try.

wjw_digiware.nl added inline comments.Jul 28 2017, 11:55 AM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	Portlint warns: `WARN: Makefile: LIB_DEPENDS the new format is libFOO.so (e.g., liblibatomic_ops.a.so).`
20 ↗	(On Diff #31299)	make package: `Error: pattern libatomic_ops.a in LIB_DEPENDS is not valid` So nope, that does not work.

mmokhi added inline comments.Jul 28 2017, 12:05 PM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	is it because of .a extension or because you have ${LOCALBASE} before it?

wjw_digiware.nl added inline comments.Jul 28 2017, 1:37 PM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	Because of the .a extension.

mat added inline comments.Jul 28 2017, 1:58 PM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	LIB_DEPENDS is for shared libraries, not static libraries. (Static libraries should not be used in the ports tree, but even after 20 something years of them being outdated, they persist.)

wjw_digiware.nl added inline comments.Jul 28 2017, 2:07 PM

net/ceph-devel/Makefile
20 ↗	(On Diff #31299)	@mat I understand and appreciate your sentiment. The project uses it, so I need it for building, and it is in ports. And it does not generate an `.so` It would not not an easy fix for me, because I would have to dive into `libatomic_ops` And only just by its name, I would not like to touch it with a 10 meter pole. Any other suggestion for getting the port loaded that pleases 'the court' is welcome

@mat @mmokhi
Any particular reason why this cannot move forward.
I'm having the first official release of net/ceph in the pipe.
Just waiting for it to be release by the Ceph-developers.
Would be nice if that one have not the same discussion we have here.

In D11770#248469, @wjw_digiware.nl wrote:

@mat @mmokhi
Any particular reason why this cannot move forward.
I'm having the first official release of net/ceph in the pipe.
Just waiting for it to be release by the Ceph-developers.
Would be nice if that one have not the same discussion we have here.

I think I already said it, but, this, here, is a code review tool, not a bug report tool.
If you want a patch committed in the tree, the fastest way is to open a bug report on our bugzilla.

@mat
I understand, and will ask on the ports-list if somebody wants to do the honnurs.