Handle security concerns in sys/dev about out of bound and initilized stack vars

[mmokhi]

Summary

Use of initialised stack variables in tdfx_query_update

	 and handle Out of bounds negative array index in iicrdwr

[mmokhi]

related Bugzilla issues:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206755
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206754

[ngie]

sys/dev/tdfx/tdfx_pci.c

710–712

• You addressed the copyin piece, but the copyout piece could fail as well.
• Please use copy{in,out} != 0 instead of testing for boolean true/false.

[ngie]

sys/dev/iicbus/iic.c

296–298

This is ok. I'll commit this to head.

[mmokhi]

Updating D5132: Handle security concerns in sys/dev about out of bound and initilized stack vars

Using $cond != 0 instead of testing for boolean true/false.

[mmokhi]

Sorry for delay in doing "$cond != 0"
I didn't see your comments in my mail_box.
BTW, Done as you told :)

Thanks.

[ngie]

Resigning as reviewer because this is not my area of expertise and I lack the hardware to test out the change, i.e., I'm not a relevant reviewer.

[mmokhi]

@ngie It's committed by another committer AFAIK,
How can we close this review?

[allanjude]

Committed as rS295080