Page MenuHomeFreeBSD

Update KomodoEdit from 6.x to 10.2.2
ClosedPublic

Authored by allanjude on Jul 9 2017, 9:56 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

allanjude created this revision.Jul 9 2017, 9:56 AM
netchild accepted this revision.Jul 9 2017, 11:02 AM

Looks OK for me (after wrapping my head around PLIST_FILES and PORTDATA and how the port installs the files).

This revision is now accepted and ready to land.Jul 9 2017, 11:02 AM
mmokhi accepted this revision.Jul 9 2017, 4:32 PM

Tested via poudriere and portlint.
it's fine.

mat requested changes to this revision.Jul 11 2017, 12:04 PM
mat added inline comments.
editors/komodo-edit/Makefile
36 ↗(On Diff #30600)

I can't believe this does not give a warning. Symlinks inside PREFIX must be relative.

So, you can either manually compute the relative path yourself, or do:

​ ${RLN} ${STAGEDIR}${DATADIR}/bin/komodo ${STAGEDIR}${PREFIX}/bin
This revision now requires changes to proceed.Jul 11 2017, 12:04 PM
mmokhi updated this revision to Diff 30646.Jul 11 2017, 1:51 PM
mmokhi edited edge metadata.

Use the ${RLN} instead of {LN} as @mat suggested.

mat accepted this revision.Jul 11 2017, 9:55 PM
This revision is now accepted and ready to land.Jul 11 2017, 9:55 PM
This revision was automatically updated to reflect the committed changes.