Page MenuHomeFreeBSD

Update KomodoEdit from 6.x to 10.2.2
ClosedPublic

Authored by allanjude on Jul 9 2017, 9:56 AM.
Tags
None
Referenced Files
F167559415: D11543.id.diff
Sat, Aug 22, 4:32 PM
Unknown Object (File)
Thu, Aug 20, 11:42 PM
Unknown Object (File)
Tue, Aug 11, 11:24 AM
Unknown Object (File)
Tue, Aug 11, 9:43 AM
Unknown Object (File)
Mon, Aug 10, 5:35 PM
Unknown Object (File)
Sun, Aug 9, 9:12 AM
Unknown Object (File)
Sun, Aug 9, 12:28 AM
Unknown Object (File)
Sat, Aug 8, 4:33 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks OK for me (after wrapping my head around PLIST_FILES and PORTDATA and how the port installs the files).

This revision is now accepted and ready to land.Jul 9 2017, 11:02 AM

Tested via poudriere and portlint.
it's fine.

mat requested changes to this revision.Jul 11 2017, 12:04 PM
mat added inline comments.
editors/komodo-edit/Makefile
36 ↗(On Diff #30600)

I can't believe this does not give a warning. Symlinks inside PREFIX must be relative.

So, you can either manually compute the relative path yourself, or do:

​ ${RLN} ${STAGEDIR}${DATADIR}/bin/komodo ${STAGEDIR}${PREFIX}/bin
This revision now requires changes to proceed.Jul 11 2017, 12:04 PM
mmokhi edited edge metadata.

Use the ${RLN} instead of {LN} as @mat suggested.

This revision is now accepted and ready to land.Jul 11 2017, 9:55 PM
This revision was automatically updated to reflect the committed changes.