Page MenuHomeFreeBSD

Update KomodoEdit from 6.x to 10.2.2
ClosedPublic

Authored by allanjude on Jul 9 2017, 9:56 AM.
Tags
None
Referenced Files
F83465418: D11543.id30646.diff
Fri, May 10, 8:02 PM
F83465414: D11543.id30600.diff
Fri, May 10, 8:02 PM
F83465410: D11543.id30782.diff
Fri, May 10, 8:02 PM
F83465403: D11543.id.diff
Fri, May 10, 8:02 PM
Unknown Object (File)
Mon, May 6, 4:36 PM
Unknown Object (File)
Wed, Apr 24, 3:25 PM
Unknown Object (File)
Fri, Apr 19, 12:13 PM
Unknown Object (File)
Feb 16 2024, 12:54 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks OK for me (after wrapping my head around PLIST_FILES and PORTDATA and how the port installs the files).

This revision is now accepted and ready to land.Jul 9 2017, 11:02 AM

Tested via poudriere and portlint.
it's fine.

mat requested changes to this revision.Jul 11 2017, 12:04 PM
mat added inline comments.
editors/komodo-edit/Makefile
36 ↗(On Diff #30600)

I can't believe this does not give a warning. Symlinks inside PREFIX must be relative.

So, you can either manually compute the relative path yourself, or do:

​ ${RLN} ${STAGEDIR}${DATADIR}/bin/komodo ${STAGEDIR}${PREFIX}/bin
This revision now requires changes to proceed.Jul 11 2017, 12:04 PM
mmokhi edited edge metadata.

Use the ${RLN} instead of {LN} as @mat suggested.

This revision is now accepted and ready to land.Jul 11 2017, 9:55 PM
This revision was automatically updated to reflect the committed changes.