Differential D11543

Update KomodoEdit from 6.x to 10.2.2
ClosedPublic
Actions

Authored by allanjude on Jul 9 2017, 9:56 AM.

Tags

None

Referenced Files

	F163314336: D11543.id30646.diff
	Wed, Jul 22, 12:32 AM

	Unknown Object (File)
	Tue, Jul 21, 7:22 AM

	Unknown Object (File)
	Fri, Jul 17, 11:35 AM

	Unknown Object (File)
	Tue, Jul 7, 2:23 AM

	Unknown Object (File)
	Tue, Jul 7, 2:23 AM

	Unknown Object (File)
	Tue, Jul 7, 2:06 AM

	Unknown Object (File)
	Sat, Jul 4, 6:54 AM

	Unknown Object (File)
	Jun 17 2026, 9:54 AM

Subscribers

Details

Reviewers

brnrd
netchild
mmokhi
feld
mat

Commits

rP445754: editors/komodo-edit: Update port from 6.x to 10.2.2

Summary

Fix my text editor

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10427
Build 10837: arc lint + arc unit

Event Timeline

allanjude created this revision.Jul 9 2017, 9:56 AM

Herald added a subscriber: mat. · View Herald TranscriptJul 9 2017, 9:56 AM

Harbormaster completed remote builds in B10406: Diff 30600.Jul 9 2017, 9:56 AM

Looks OK for me (after wrapping my head around PLIST_FILES and PORTDATA and how the port installs the files).

This revision is now accepted and ready to land.Jul 9 2017, 11:02 AM

Tested via poudriere and portlint.
it's fine.

mmokhi added reviewers: feld, mat.Jul 9 2017, 4:33 PM

mat requested changes to this revision.Jul 11 2017, 12:04 PM

mat added inline comments.

editors/komodo-edit/Makefile
36	I can't believe this does not give a warning. Symlinks inside PREFIX must be relative. So, you can either manually compute the relative path yourself, or do: ${RLN} ${STAGEDIR}${DATADIR}/bin/komodo ${STAGEDIR}${PREFIX}/bin

This revision now requires changes to proceed.Jul 11 2017, 12:04 PM

Use the ${RLN} instead of {LN} as @mat suggested.

Harbormaster completed remote builds in B10427: Diff 30646.Jul 11 2017, 1:51 PM

mat accepted this revision.Jul 11 2017, 9:55 PM

This revision is now accepted and ready to land.Jul 11 2017, 9:55 PM

Closed by commit rP445754: editors/komodo-edit: Update port from 6.x to 10.2.2 (authored by mmokhi). · Explain WhyJul 14 2017, 1:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

editors/

komodo-edit/

13 lines

5 lines

Diff 30646

editors/komodo-edit/Makefile

Loading...

editors/komodo-edit/distinfo

Loading...