Activate the filter for the PC/SC daemon
ClosedPublic

Authored by roberfern_gmail.com on Mar 22 2017, 10:39 AM.

Details

Summary
Test Plan
  • After the port was built, and with two card readers attached to my PC, I have run the following commands:
    1. env PCSCLITE_FILTER_IGNORE_READER_NAMES="<card regex>" pcscd
    2. env PCSCLITE_FILTER_IGNORE_READER_NAMES="<card regex>" pcscd -H
    3. pcsc_scan # <- security/pcsc-tools are needed for this.

      Only the card reader that does not match the regular expression should appear on the screen.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mat added a comment.Mar 22 2017, 11:01 AM

You'll need to bump PORTREVISION here.

In D10090#208658, @mat wrote:

You'll need to bump PORTREVISION here.

Do you mean to set the PORTREVISION variable to one? It is not set.

I am sorry for the inconvenience, but I am relative new in this things and I want to do it in the right way.

Hmm, I made another change on this, I'd say it's better to add this as option, to [at least] not make surprise for people/companies who currently not expecting this option as default.
I'll upload my changes plus what @mat suggests to the PR you opened for this, would you please update this diff with that?

Okay, I did also QA on it [with added as option, on the patch attached to PR] too, It's okay.
So I did maintainer-approval '+' on it.

If @mat approves this as my mentor, I'll commit it :)

mmokhi edited the summary of this revision. (Show Details)Mar 22 2017, 11:42 AM

Okay, I did also QA on it [with added as option, on the patch attached to PR] too, It's okay.
So I did maintainer-approval '+' on it.

If @mat approves this as my mentor, I'll commit it :)

Should I then update this diff?

Yeah, preferably do this please.
So @mat can view the changes easier too.

Udpdating the patch with the diff from mmokhi

mmokhi accepted this revision.Mar 22 2017, 11:50 AM

Thanks :)

This revision is now accepted and ready to land.Mar 22 2017, 11:50 AM
mat accepted this revision.Mar 22 2017, 4:24 PM
This revision was automatically updated to reflect the committed changes.