Page MenuHomeFreeBSD
Feed Advanced Search

Apr 15 2017

neel committed rS316990: Due to time constraints remove myself as a vmm(4) maintainer..
Due to time constraints remove myself as a vmm(4) maintainer.
Apr 15 2017, 10:43 PM

Apr 19 2016

neel accepted D5990: More error messages for passthru..

Looks good.

Apr 19 2016, 6:13 PM
neel accepted D5982: bhyve: document signals handling and exit codes.
Apr 19 2016, 6:11 PM

Mar 3 2016

neel added a comment to D5371: Adding myself(anish) in various doc files..

A reminder to make sure you add the appropriate "Approved by" note in the actual commit log.

Mar 3 2016, 5:07 PM
neel accepted D5371: Adding myself(anish) in various doc files..

First commit looks good!

Mar 3 2016, 5:06 PM

Feb 27 2016

neel added inline comments to D5371: Adding myself(anish) in various doc files..
Feb 27 2016, 8:15 PM

Jan 26 2016

neel accepted D5042: Cleanup unused-but-set-variable spotted by gcc-4.9.
Jan 26 2016, 7:10 AM

Sep 17 2015

neel accepted D3685: Make sure f_name is nul-terminated..

Looks good. Thanks for fixing.

Sep 17 2015, 5:54 PM

Jul 16 2015

neel committed rS285619: If uart interrupts are not functioning then schedule the callout to do the.
If uart interrupts are not functioning then schedule the callout to do the
Jul 16 2015, 4:15 AM

Jul 8 2015

neel added a comment to D2838: Add on bhyvectl the capability to list the running vms..

Sorry about that - the delay wasn't intentional :-(

Jul 8 2015, 2:10 AM

Jul 6 2015

neel committed rS285218: Move the 'devmem' device nodes from /dev/vmm to /dev/vmm.io.
Move the 'devmem' device nodes from /dev/vmm to /dev/vmm.io
Jul 6 2015, 7:41 PM
neel committed rS285217: Always assert DCD and DSR in bhyve's uart emulation..
Always assert DCD and DSR in bhyve's uart emulation.
Jul 6 2015, 7:33 PM

Jul 1 2015

neel committed rS285015: MFC r284712:.
MFC r284712:
Jul 1 2015, 7:47 PM

Jun 28 2015

neel committed rS284900: MFC r282209:.
MFC r282209:
Jun 28 2015, 3:22 AM
neel committed rS284899: MFC r279444:.
MFC r279444:
Jun 28 2015, 1:22 AM

Jun 27 2015

neel committed rS284894: MFC r276428:.
MFC r276428:
Jun 27 2015, 10:48 PM
neel committed rS284892: Fix issues detected by 'mandoc -Tlint bhyveload.8'.
Fix issues detected by 'mandoc -Tlint bhyveload.8'
Jun 27 2015, 6:24 PM
neel closed D2762: Restructure memory allocation in bhyve to support "devmem". by committing rS284892: Fix issues detected by 'mandoc -Tlint bhyveload.8'.
Jun 27 2015, 6:24 PM

Jun 23 2015

neel committed rS284712: Restore the host's GS.base before returning from 'svm_launch()'..
Restore the host's GS.base before returning from 'svm_launch()'.
Jun 23 2015, 2:17 AM

Jun 22 2015

neel committed rS284688: Fix a regression in "movs" emulation after r284539. The regression was caused.
Fix a regression in "movs" emulation after r284539. The regression was caused
Jun 22 2015, 12:30 AM

Jun 20 2015

neel added inline comments to D2873: Fix CID 1307758: Unused value..
Jun 20 2015, 12:20 AM

Jun 19 2015

neel added inline comments to D2873: Fix CID 1307758: Unused value..
Jun 19 2015, 11:03 PM
neel added a comment to D2873: Fix CID 1307758: Unused value..

Thanks for the quick turnaround, but this idiom is intentional (I updated the CID a couple of hours ago).

Jun 19 2015, 10:55 PM

Jun 18 2015

neel added a comment to D2838: Add on bhyvectl the capability to list the running vms..

Regarding libxo:

Jun 18 2015, 8:13 AM
neel added a comment to D2838: Add on bhyvectl the capability to list the running vms..

This patch will need to be updated after r284539
https://svnweb.freebsd.org/base?view=revision&revision=284539

Jun 18 2015, 8:04 AM
neel committed rS284539: Restructure memory allocation in bhyve to support "devmem"..
Restructure memory allocation in bhyve to support "devmem".
Jun 18 2015, 6:00 AM

Jun 10 2015

neel added a comment to D2762: Restructure memory allocation in bhyve to support "devmem"..
In D2762#52988, @tychon wrote:
In D2762#52919, @neel wrote:
In D2762#52915, @tychon wrote:

Thanks Tycho. My responses inline:

This restructuring will be really handy. However, I think it's possible
to unify the handling of 'sysmem' and 'devmem' such that 'sysmem'
differs from 'devmem' only in persistance and accessibility (PROT_*).
Since alloc_memseg() is already called by both vm_setup_memory() and
vm_create_devmem() you'll simply need to provide a vanity name for
"lower", "low" and "high" memory to vm_alloc_memseg() when it's
created. Then you can delete the inference that a memsesg is 'RAM'
you get when you encounter a VM_MEMSEG_NAME. You'll also need to
augment vm_alloc_memseg() will to take a persistance argument
which will be set for 'sysmem' and clear for 'devmem'.

I think knowing which memory segments represent system memory is useful.
For e.g., I use this in iommu_modify() to only map 'sysmem' in the passthru
device's address space. This enforces consistency with the treatment of other
(emulated) device memory (e.g. AHCI BAR) from the point of view of the
passthru device.

It appears beyond just useful but rather an implementation requirement :-)

As a side benefit to treating all memory roughly equal is that you'll
be able to expose the entire guest's memory PA-wise in
/dev/vmm/testvmm.lowermem, /dev/vmm/testvmm.lowmem and
/dev/vmm/testvmm.highmem!

That's one way to do it although I don't see it as being functionally
different than mmap(/dev/vmm/vmname).

It's not different so there isn't much point.
My point really was that the API as proposed would be impossible for someone with a copy of vmm_dev.h and a binary only vmm.ko to use properly. Not that that someone like that exists but libvmmapi.so and bhyve shouldn't contain too much embedded knowledge of the kernel internals.
Specifically, VM_ALLOC_MEMSEG takes a struct vm_memseg which in no way makes it obvious that when you supply a name you get a devseg and that it's necessary to omit the name when you want to get a "true" memseg. It you add 'int ismemseg' then it would be obvious.

Jun 10 2015, 7:41 PM
neel added a comment to D2762: Restructure memory allocation in bhyve to support "devmem"..
In D2762#52915, @tychon wrote:
Jun 10 2015, 2:05 AM

Jun 9 2015

neel retitled D2762: Restructure memory allocation in bhyve to support "devmem". from to Restructure memory allocation in bhyve to support "devmem"..
Jun 9 2015, 1:08 AM

Jun 6 2015

neel committed rS284046: The 'verify_gla()' function is used to ensure that the effective address.
The 'verify_gla()' function is used to ensure that the effective address
Jun 6 2015, 10:52 PM

Jun 4 2015

neel committed rS283973: Use tunable 'hw.vmm.svm.features' to disable specific SVM features even.
Use tunable 'hw.vmm.svm.features' to disable specific SVM features even
Jun 4 2015, 2:12 AM

Jun 3 2015

neel accepted D2723: bhyve/vmrun.sh: two improvements.

Looks good.

Jun 3 2015, 9:39 PM

May 28 2015

neel added a comment to D2629: Avoid bhyve(8) have a core dump when try to activate a new vcpu using a running vm..

There are many reasons why 'vm_activate_cpu()' might fail.

May 28 2015, 5:59 PM
neel committed rS283657: Fix non-deterministic delays when accessing a vcpu that was in "running" or.
Fix non-deterministic delays when accessing a vcpu that was in "running" or
May 28 2015, 5:37 PM

May 23 2015

neel committed rS283308: Exceptions don't deliver an error code in real mode..
Exceptions don't deliver an error code in real mode.
May 23 2015, 1:17 AM

May 22 2015

neel committed rS283299: Remove the verification of instruction length after instruction decode. The.
Remove the verification of instruction length after instruction decode. The
May 22 2015, 9:09 PM
neel committed rS283293: Don't rely on the 'VM-exit instruction length' field in the VMCS to always.
Don't rely on the 'VM-exit instruction length' field in the VMCS to always
May 22 2015, 5:34 PM

May 21 2015

neel committed rS283256: Add an option "--get-vmcs-exit-inst-length" to display the instruction length.
Add an option "--get-vmcs-exit-inst-length" to display the instruction length
May 21 2015, 6:29 PM
neel committed rS283255: Emulate the "CMP r/m, reg" instruction (opcode 39H)..
Emulate the "CMP r/m, reg" instruction (opcode 39H).
May 21 2015, 6:23 PM

May 19 2015

neel accepted D2595: Expand ktr_mask to be a 64-bit unsigned integer..
May 19 2015, 9:42 PM

May 16 2015

neel accepted D2569: Fix off-by-one in array index bounds check.

Looks good.

May 16 2015, 7:04 PM

May 12 2015

neel committed rS282788: Allow configuration of the sector size advertised to the guest..
Allow configuration of the sector size advertised to the guest.
May 12 2015, 12:30 AM

May 7 2015

neel committed rS282595: Allow byte reads of AHCI registers..
Allow byte reads of AHCI registers.
May 7 2015, 6:35 PM
neel updated the diff for D2469: Allow byte reads of AHCI registers..

Assert that AHCI reads are naturally aligned and do not straddle a 32-bit
boundary.

May 7 2015, 6:01 PM
neel added a comment to D2469: Allow byte reads of AHCI registers..
In D2469#45441, @mav wrote:

As I see, reading single byte at offset multiple to 4 this function still return 32-bit value, at next -- 24-bit, etc. Is this expected/acceptable behavior?

May 7 2015, 5:49 PM
neel retitled D2469: Allow byte reads of AHCI registers. from to Allow byte reads of AHCI registers..
May 7 2015, 1:30 AM

May 6 2015

neel committed rS282571: Check 'td_owepreempt' and yield the vcpu thread if it is set..
Check 'td_owepreempt' and yield the vcpu thread if it is set.
May 6 2015, 11:40 PM
neel closed D2430: Check 'td_owepreempt' and yield the vcpu thread if it is set. by committing rS282571: Check 'td_owepreempt' and yield the vcpu thread if it is set..
May 6 2015, 11:40 PM
neel committed rS282558: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup()..
Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup().
May 6 2015, 4:25 PM
neel closed D2428: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup(). by committing rS282558: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup()..
May 6 2015, 4:25 PM
neel committed rS282520: Do a proper emulation of guest writes to MSR_EFER..
Do a proper emulation of guest writes to MSR_EFER.
May 6 2015, 5:40 AM
neel committed rS282519: Add macros for AMD-specific bits in MSR_EFER: LMSLE, FFXSR and TCE..
Add macros for AMD-specific bits in MSR_EFER: LMSLE, FFXSR and TCE.
May 6 2015, 5:12 AM

May 4 2015

neel added a comment to D2428: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup()..
In D2428#44714, @tychon wrote:

Hi,
In most cases it was treated as such, but you've actually got the information to do better. Specifically around line 624 in the newvmm_instruction_emul.c you could set *fault to IDT_SS or IDT_GP. If you think no one will ever care about the specific fault, perhaps renaming fault to is_fault would further cement it's boolean nature.

May 4 2015, 5:57 PM
neel added a comment to D2428: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup()..
In D2428#44714, @tychon wrote:

Hi,
This looks very nice. My only feedback is that I got confused as to whether or not the "return fault (*fault)" provided by vmm_fetch_instruction was boolean or not. In most cases it was treated as such, but you've actually got the information to do better. Specifically around line 624 in the new vmm_instruction_emul.c you could set *fault to IDT_SS or IDT_GP. If you think no one will ever care about the specific fault, perhaps renaming fault to is_fault would further cement it's boolean nature.
Also as a mini-nit I'd suggest changing 'guest_fault' in the comment to 'fault' to match the function prototype vmm_instruction_emul.h
Tycho

May 4 2015, 4:42 PM
neel updated the diff for D2428: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup()..

Update all extern function declarations to use 'int *is_fault' consistently.

May 4 2015, 4:40 PM
neel committed rS282407: Emulate the 'CMP r/m8, imm8' instruction encountered when booting a Windows.
Emulate the 'CMP r/m8, imm8' instruction encountered when booting a Windows
May 4 2015, 4:27 AM

May 2 2015

neel retitled D2430: Check 'td_owepreempt' and yield the vcpu thread if it is set. from to Check 'td_owepreempt' and yield the vcpu thread if it is set..
May 2 2015, 10:01 PM
neel retitled D2429: Check 'td_owepreempt' and yield the vcpu thread if it is set. from to Check 'td_owepreempt' and yield the vcpu thread if it is set..
May 2 2015, 10:00 PM
neel committed rS282351: Don't advertise the Intel SMX capability to the guest..
Don't advertise the Intel SMX capability to the guest.
May 2 2015, 7:08 PM
neel committed rS282336: Emulate machine check related MSRs to allow guest OSes like Windows to boot..
Emulate machine check related MSRs to allow guest OSes like Windows to boot.
May 2 2015, 4:19 AM
neel retitled D2428: Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup(). from to Deprecate the 3-way return values from vm_gla2gpa() and vm_copy_setup()..
May 2 2015, 3:54 AM
neel committed rS282335: Advertise an additional memory BAR in the "dummy" device emulation..
Advertise an additional memory BAR in the "dummy" device emulation.
May 2 2015, 3:25 AM

May 1 2015

neel committed rS282301: r281630 relaxed the limits on the vectors that can be asserted in the IRRs..
r281630 relaxed the limits on the vectors that can be asserted in the IRRs.
May 1 2015, 4:00 PM
neel committed rS282296: Emulate MSR_SYSCFG which is accessed by Linux on AMD cpus when MTRRs are.
Emulate MSR_SYSCFG which is accessed by Linux on AMD cpus when MTRRs are
May 1 2015, 5:11 AM

Apr 30 2015

neel committed rS282287: Don't require <sys/cpuset.h> to be always included before <machine/vmm.h>..
Don't require <sys/cpuset.h> to be always included before <machine/vmm.h>.
Apr 30 2015, 10:23 PM
neel committed rS282284: When an instruction cannot be decoded just return to userspace so bhyve(8).
When an instruction cannot be decoded just return to userspace so bhyve(8)
Apr 30 2015, 9:00 PM
neel committed rS282281: Advertise the MTRR feature via CPUID and emulate the minimal set of MTRR MSRs..
Advertise the MTRR feature via CPUID and emulate the minimal set of MTRR MSRs.
Apr 30 2015, 7:24 PM

Apr 29 2015

neel committed rS282259: Re-implement RTC current time calculation to eliminate the possibility of.
Re-implement RTC current time calculation to eliminate the possibility of
Apr 29 2015, 11:44 PM
neel committed rS282209: Emulate the 'bit test' instruction. Windows 7 uses 'bit test' to check the.
Emulate the 'bit test' instruction. Windows 7 uses 'bit test' to check the
Apr 29 2015, 2:01 AM

Apr 28 2015

neel committed rS282206: Implement the century byte in the RTC. Some guests require this field to be.
Implement the century byte in the RTC. Some guests require this field to be
Apr 28 2015, 11:44 PM

Apr 24 2015

neel committed rS281946: Don't allow guest to modify readonly bits in the PCI config 'status' register..
Don't allow guest to modify readonly bits in the PCI config 'status' register.
Apr 24 2015, 7:15 PM

Apr 23 2015

neel retitled D2350: Implement NMI window exiting on AMD/SVM processors. from to Implement NMI window exiting on AMD/SVM processors..
Apr 23 2015, 2:40 AM

Apr 22 2015

neel accepted D2342: Missing break..

Looks good. Thanks for catching this.

Apr 22 2015, 5:21 PM

Apr 15 2015

neel closed D2294: Fix handling of BUS_PROBE_NOWILDCARD in 'device_probe_child()'..

Closed by commit rS281559 (authored by @neel).

Apr 15 2015, 4:22 PM

Apr 14 2015

neel added a comment to D2294: Fix handling of BUS_PROBE_NOWILDCARD in 'device_probe_child()'..
In D2294#6, @rstone wrote:

I think that it would be sufficient to test that this still allows ppt to attach to a device dynamically:

  1. devctl detach ixl4
  2. devctl set driver pci11:0:3 ppt

(replace ixl4/pci11:0:3 with some unused PCI device from your test machine)
devctl also uses the same BUS_PROBE_NOWILDCARD feature that SR-IOV uses.

Apr 14 2015, 9:48 PM
neel added inline comments to D2294: Fix handling of BUS_PROBE_NOWILDCARD in 'device_probe_child()'..
Apr 14 2015, 9:45 PM
neel added a comment to D2294: Fix handling of BUS_PROBE_NOWILDCARD in 'device_probe_child()'..

The test plan should also verify that VF passthrough still works after this change.

Apr 14 2015, 7:16 PM
neel retitled D2294: Fix handling of BUS_PROBE_NOWILDCARD in 'device_probe_child()'. from to Fix handling of BUS_PROBE_NOWILDCARD in 'device_probe_child()'..
Apr 14 2015, 7:14 PM

Mar 17 2015

neel accepted D1892: Remap interrupts using VT-d hardware; allow 32bit x2apic apic_ids to be used for interrupt destinations..
Mar 17 2015, 4:23 PM
neel added a comment to D1892: Remap interrupts using VT-d hardware; allow 32bit x2apic apic_ids to be used for interrupt destinations..

Apologies for the delayed review. I have some comments inline.

Mar 17 2015, 12:40 AM

Mar 14 2015

neel closed D2042: APIs to dynamically allocate and free IPI slots..

Closed by commit rS279970 (authored by @neel).

Mar 14 2015, 12:31 AM

Mar 10 2015

neel retitled D2042: APIs to dynamically allocate and free IPI slots. from to APIs to dynamically allocate and free IPI slots..
Mar 10 2015, 7:40 PM

Mar 1 2015

neel closed D1983: Free up the IPI slot used by IPI_STOP_HARD..

Closed by commit rS279468 (authored by @neel).

Mar 1 2015, 2:32 AM
neel added a comment to D1983: Free up the IPI slot used by IPI_STOP_HARD..
In D1983#7, @kostikbel wrote:
In D1983#6, @neel wrote:
In D1983#3, @kostikbel wrote:

Does IPI_STOP_HARD value must fit into 8 bits ? It is not the same as the spurious vector, which should be innocent as well, but slightly confusing.

There were two restrictions when choosing the value for the IPI_STOP_HARD value:

  • 'native_lapic_ipi_vectored()' wants the vector to be less than 256

So if we change the assertion in native_lapic_ipi_vectored(), the IPI_STOP_HARD value could be moved outside the [0,255] range ? I mean, explicitly allow a value in the valid range OR IPI_STOP_HARD, in the assertion.

Mar 1 2015, 2:26 AM

Feb 28 2015

neel added a comment to D1983: Free up the IPI slot used by IPI_STOP_HARD..
In D1983#3, @kostikbel wrote:

Does IPI_STOP_HARD value must fit into 8 bits ? It is not the same as the spurious vector, which should be innocent as well, but slightly confusing.

Feb 28 2015, 11:57 AM

Feb 27 2015

neel retitled D1983: Free up the IPI slot used by IPI_STOP_HARD. from to Free up the IPI slot used by IPI_STOP_HARD..
Feb 27 2015, 11:17 PM

Feb 24 2015

neel accepted D1943: Implement EOI suppression mode..
Feb 24 2015, 2:08 AM

Feb 23 2015

neel accepted D1943: Implement EOI suppression mode..

Looks good. A couple of minor comments inline.

Feb 23 2015, 8:39 PM

Jan 18 2015

neel closed D1526: Simplify instruction restart logic in bhyve..

Closed by commit rS277310 (authored by @neel).

Jan 18 2015, 3:08 AM

Jan 14 2015

neel retitled D1526: Simplify instruction restart logic in bhyve. from to Simplify instruction restart logic in bhyve..
Jan 14 2015, 8:51 AM

Dec 30 2014

neel closed D1385: Add RTC device emulation to vmm.ko.
Dec 30 2014, 10:25 PM
neel added a comment to D1385: Add RTC device emulation to vmm.ko.

Tycho, can you accept the revision in phabric?

Dec 30 2014, 10:19 PM
neel added a comment to D1385: Add RTC device emulation to vmm.ko.
In D1385#7, @tychon wrote:
In D1385#6, @neel wrote:
In D1385#5, @tychon wrote:

Then with respect to the other code, I'm a bit curious about the VM_RTC_READ/VM_RTC_WRITE interface. I'd sort of expected a size or length parameter -- perhaps length so the NVRAM component can be bulk import/exported -- but even size would be fine. Another alternative is to make the 'value' or 'retval' uint8_t so it's obvious it's a byte-based.

Does the following seem alright?
int vm_rtc_write(struct vmctx *ctx, int offset, uint8_t value);
int vm_rtc_read(struct vmctx *ctx, int offset, uint8_t *retval);
int vm_rtc_size(struct vmctx *ctx); /* return size of the nvram including the RTC control/status registers */

In rereading what I wrote, maybe I was too vague. I think that vm_rtc_write() and vm_rtc_read() are sufficient as the size of the device is well known or at least the consumer of these interfaces would be best served by knowing what they were reading or writing.
My suggestion of 'size' was along the lines of a read/write interface which allowed the access of multiple bytes at once. For one at a time interface, I think vm_rtc_size() can be omitted for simplicity.

Dec 30 2014, 7:35 PM
neel added a comment to D1385: Add RTC device emulation to vmm.ko.
In D1385#5, @tychon wrote:
In D1385#4, @neel wrote:
In D1385#3, @tychon wrote:

I'm still in the process of reviewing this, however at first glance I'm not sure I see any reason to remove the HPET Legacy Routing support.
When you first mentioned it, I assumed that some interface change which made it difficult to support and that it added the to the test matrix. Now seeing the implementation it appears entirely independent from the RTC support.

The reason it appears independent is because I removed LegacyRouting :-)

Since it's not broken and provides additional functionality -- which I can't help bug imagine that some guest out there is relying on -- I don't see the justification from deleting it as there are several other examples of "redundant mechanisms".

LegacyRouting is an optional capability so guests shouldn't be upset if they don't see this capability. I haven't run into any issues with the different guests that I have tested.
Also, LegacyRouting doesn't obviate the need for a complete PIT and RTC device emulation since we'll always need to support guests that depend on them.
The interrupt routing gets complicated with LegacyRouting. For e.g., if LegacyRouting is enabled then RTC periodic interrupts are disconnected from the PIC but the alarm and update-ended interrupts are now routed to the SCI. This is not insurmountable but I don't see a tangible benefit.
In any case the most important reason to deprecate LegacyRouting is because doubles the test matrix.

That is a valid reason... out it goes.
Then with respect to the other code, I'm a bit curious about the VM_RTC_READ/VM_RTC_WRITE interface. I'd sort of expected a size or length parameter -- perhaps length so the NVRAM component can be bulk import/exported -- but even size would be fine. Another alternative is to make the 'value' or 'retval' uint8_t so it's obvious it's a byte-based.

Dec 30 2014, 2:39 AM

Dec 29 2014

neel added a comment to D1385: Add RTC device emulation to vmm.ko.
In D1385#3, @tychon wrote:

I'm still in the process of reviewing this, however at first glance I'm not sure I see any reason to remove the HPET Legacy Routing support.
When you first mentioned it, I assumed that some interface change which made it difficult to support and that it added the to the test matrix. Now seeing the implementation it appears entirely independent from the RTC support.

Dec 29 2014, 8:09 PM

Dec 28 2014

neel closed D1384: Implement "special mask mode" in vatpic..
Dec 28 2014, 12:53 AM

Dec 27 2014

neel added a comment to D1384: Implement "special mask mode" in vatpic..

Addressed all issues raised in Peter's comments in the new diff.

Dec 27 2014, 11:01 PM
neel updated the diff for D1384: Implement "special mask mode" in vatpic..

Address Peter's comments.

Dec 27 2014, 11:00 PM
neel retitled D1385: Add RTC device emulation to vmm.ko from to Add RTC device emulation to vmm.ko.
Dec 27 2014, 5:08 AM
neel retitled D1384: Implement "special mask mode" in vatpic. from to Implement "special mask mode" in vatpic..
Dec 27 2014, 4:13 AM