Fix off-by-one in array index bounds check
ClosedPublic
Actions

Authored by allanjude on May 16 2015, 6:28 PM.

Tags

None

Referenced Files

	F153855738: D2569.id5430.diff
	Fri, Apr 24, 7:04 AM

	F153814244: D2569.id5462.diff
	Thu, Apr 23, 11:31 PM

	Unknown Object (File)
	Thu, Apr 23, 3:03 PM

	Unknown Object (File)
	Mon, Apr 20, 6:02 PM

	Unknown Object (File)
	Mon, Apr 20, 12:36 PM

	Unknown Object (File)
	Sun, Apr 19, 10:51 AM

	Unknown Object (File)
	Sun, Apr 19, 7:54 AM

	Unknown Object (File)
	Sun, Apr 19, 5:57 AM

View All Files

Subscribers

imp

Details

Reviewers

grehan
neel
jhb
araujo

Commits

rS283075: Fix off-by-one in array index bounds check

Summary

bhyveload would allow you to create 33 entries on an array that only has 32 slots

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

allanjude updated this revision to Diff 5430.May 16 2015, 6:28 PM

allanjude retitled this revision from to Fix off-by-one in array index bounds check.

allanjude updated this object.

allanjude edited the test plan for this revision. (Show Details)

allanjude added reviewers: grehan, neel, jhb, araujo.

Herald added a subscriber: imp. · View Herald TranscriptMay 16 2015, 6:28 PM

Looks good.

This revision is now accepted and ready to land.May 16 2015, 7:04 PM

Seems reasonable. Go ahead.

Closed by commit rS283075: Fix off-by-one in array index bounds check (authored by allanjude). · Explain WhyMay 18 2015, 7:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyveload/

bhyveload.c

2 lines

Diff 5462

View Options

head/usr.sbin/bhyveload/bhyveload.c

Fix off-by-one in array index bounds checkClosedPublicActions