Page MenuHomeFreeBSD

Expand ktr_mask to be a 64-bit unsigned integer.

Authored by jhb on May 19 2015, 9:23 PM.
Referenced Files
Unknown Object (File)
Dec 31 2023, 12:36 PM
Unknown Object (File)
Dec 20 2023, 1:32 AM
Unknown Object (File)
Dec 14 2023, 7:18 AM
Unknown Object (File)
Nov 12 2023, 7:30 PM
Unknown Object (File)
Nov 10 2023, 7:45 PM
Unknown Object (File)
Nov 8 2023, 8:43 AM
Unknown Object (File)
Oct 12 2023, 3:12 PM
Unknown Object (File)
Oct 9 2023, 6:33 PM



Expand ktr_mask to be a 64-bit unsigned integer.

The mask does not really need to be updated with atomic operations and
the downside of losing races during transitions is not great (it is
not marked volatile, so those races are pretty wide open as it is).

Test Plan
  • Tested some ktr tracing (albeit still using a 32-bit mask) and it still worked fine.

Diff Detail

rS FreeBSD src repository - subversion
Lint Not Applicable
Tests Not Applicable

Event Timeline

jhb retitled this revision from to Expand ktr_mask to be a 64-bit unsigned integer..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
neel added a reviewer: neel.
This revision is now accepted and ready to land.May 19 2015, 9:42 PM

I like this change, but I missing one small thing: the conversion of KTR_foo classes from 32 bit defines to 64 bit defines in sys/ktr_class.h

This comment was removed by op.
rpaulo added a reviewer: rpaulo.
emaste added a reviewer: emaste.

Strictly speaking I don't think we need to convert the KTR class macros just yet. Also, we don't need to bump KTR_VERSION since the layout of the logged records hasn't changed.

This revision was automatically updated to reflect the committed changes.