Implement "special mask mode" in vatpic.
ClosedPublic
Actions

Authored by neel on Dec 27 2014, 4:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 9, 9:49 PM

	Unknown Object (File)
	Wed, Oct 8, 4:52 PM

	Unknown Object (File)
	Mon, Oct 6, 6:43 AM

	Unknown Object (File)
	Tue, Sep 16, 1:30 AM

	Unknown Object (File)
	Mon, Sep 15, 5:08 PM

	Unknown Object (File)
	Sep 2 2025, 4:14 AM

	Unknown Object (File)
	Aug 31 2025, 6:23 AM

	Unknown Object (File)
	Aug 15 2025, 3:43 PM

View All Files

Subscribers

None

Details

Reviewers

grehan
tychon

Summary

OpenBSD guests always enable "special mask mode" during boot. As a result of
r275952 this is flagged as an error and the guest cannot boot.

Fix this by implementing the 8259 "special mask mode".

Test Plan

Boot the OpenBSD/amd64 5.6 installer.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

neel updated this revision to Diff 2888.Dec 27 2014, 4:13 AM

neel retitled this revision from to Implement "special mask mode" in vatpic..

neel updated this object.

neel added reviewers: tychon, grehan.

neel edited the test plan for this revision. (Show Details)

grehan added inline comments.Dec 27 2014, 9:46 PM

sys/amd64/vmm/io/vatpic.c
166	, when a mask bit is set in OCW1 it
169	no bearing on the levels
397–400	Minor: should this just be 'atpic->smm = 1' to fit in with the bool-style usage of the variable ?

Address Peter's comments.

Addressed all issues raised in Peter's comments in the new diff.

Please review.

grehan accepted this revision.Dec 27 2014, 11:15 PM

grehan edited edge metadata.

This revision is now accepted and ready to land.Dec 27 2014, 11:15 PM

neel closed this revision.Dec 28 2014, 12:53 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

io/

vatpic.c

29 lines

Diff 2895

View Options

Implement "special mask mode" in vatpic.ClosedPublicActions