Page MenuHomeFreeBSD

Implement "special mask mode" in vatpic.
ClosedPublic

Authored by neel on Dec 27 2014, 4:13 AM.

Details

Reviewers
grehan
tychon
Summary

OpenBSD guests always enable "special mask mode" during boot. As a result of
r275952 this is flagged as an error and the guest cannot boot.

Fix this by implementing the 8259 "special mask mode".

Test Plan

Boot the OpenBSD/amd64 5.6 installer.

Diff Detail

Repository
rS FreeBSD src repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

neel retitled this revision from to Implement "special mask mode" in vatpic..Dec 27 2014, 4:13 AM
neel updated this object.
neel added reviewers: tychon, grehan.
neel edited the test plan for this revision. (Show Details)
neel updated this revision to Diff 2888.
grehan added inline comments.Dec 27 2014, 9:46 PM
sys/amd64/vmm/io/vatpic.c
166

, when a mask bit is set in OCW1 it

169

no bearing on the levels

397–400

Minor: should this just be 'atpic->smm = 1' to fit in with the bool-style usage of the variable ?

neel updated this revision to Diff 2895.Dec 27 2014, 11:00 PM

Address Peter's comments.

neel added a comment.Dec 27 2014, 11:01 PM

Addressed all issues raised in Peter's comments in the new diff.

Please review.

grehan edited edge metadata.Dec 27 2014, 11:15 PM
grehan accepted this revision.
This revision is now accepted and ready to land.Dec 27 2014, 11:15 PM
neel closed this revision.Dec 28 2014, 12:53 AM