- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 20 2020
Jun 18 2020
Jun 17 2020
Jun 16 2020
Jun 14 2020
Jun 6 2020
Jun 5 2020
(I don't think I have any better idea on the wording of 'hardware' either, maybe leave it as-is for now?)
Jun 4 2020
Jun 1 2020
May 30 2020
Looks good to me (there are a few minor nits or optional alternative proposals)
May 29 2020
May 28 2020
May 27 2020
May 23 2020
Remove unused sha256.c and use sed instead of awk.
May 22 2020
May 20 2020
In D24596#548787, @rgrimes wrote:In D24596#548776, @emaste wrote:POSIX allows implementations to do what they want with read() on a directory and grep's behaviour follows from that, so I think it's within the spirit for us to show errors or not, as we see fit.
Please do not change the default, that would just make our greps defaults different than linux and everyone else. Just "recommend" the use of grep -d skip in the UPDATE entry, the RELEASE NOTES, and perhaps by adding t as an example, aka commented out, in /root/csh.cshrc and /root/.profile, and perhaps in the usr/share/skel files.
May 19 2020
May 18 2020
May 15 2020
May 14 2020
I've requested a new exp-run with this one.
May 13 2020
May 12 2020
IMHO I think it's not worth the effort to make this knob-controllable and the old behavior should be gone: directories are not stored in an uniform format, it varies from file system to file system and I'd be really surprised if anything would depend on the old behavior: for starters, these application would have already been broken many years ago when we move to a different file system. Neither fsck_ffs nor fsck_msdosfs rely on being able to read() directories directly, and I don't see any legitimate reason that an application should do it either.
Could you please incorporate the manual page change from D24814 into this one?
https://reviews.freebsd.org/D24596 is a superset of this changeset (except manual page change).
May 11 2020
May 9 2020
LGTM (please be sure to bump .Dd dates for manual pages.
May 6 2020
May 5 2020
May 4 2020
May 3 2020
May 1 2020
Apr 30 2020
Apr 29 2020
Apr 28 2020
Makes sense, I've updated the patch, could you please take another look?
Address reviewer comment (unconditionally calculate badbytes).
Apr 27 2020
Please take another look, thanks!
Address reviewer comments.
Apr 26 2020
Round down chunksize if it's not fully aligned.
Address reviewer comment.
Apr 25 2020
Apr 23 2020
Apr 22 2020
Apr 21 2020
Apr 20 2020
Tested on a hard drive; this reduced the time for format by 2/3:
x before + after +------------------------------------------------------------+ |+++ xx| ||A| AM| +------------------------------------------------------------+ N Min Max Median Avg Stddev x 3 7.24 7.33 7.29 7.2866667 0.045092498 + 3 2.36 2.49 2.4 2.4166667 0.066583281 Difference at 95.0% confidence -4.87 +/- 0.128884 -66.8344% +/- 1.50101% (Student's t, pooled s = 0.0568624)