Return EISDIR when read() and pread()'ing a directory.
AbandonedPublic
Actions

Authored by delphij on May 12 2020, 2:50 AM.

Tags

None

Referenced Files

	F124967768: D24814.diff
	Fri, Aug 1, 9:18 PM

	Unknown Object (File)
	Sun, Jul 27, 8:35 AM

	Unknown Object (File)
	Sat, Jul 26, 9:13 PM

	Unknown Object (File)
	Sat, Jul 26, 1:41 PM

	Unknown Object (File)
	Wed, Jul 23, 1:02 AM

	Unknown Object (File)
	Tue, Jul 22, 1:33 PM

	Unknown Object (File)
	Tue, Jul 22, 1:33 PM

	Unknown Object (File)
	Tue, Jul 22, 1:33 PM

View All 59 Files

Subscribers

imp

Details

Reviewers

emaste
jilles
kib
mckusick

Group Reviewers

manpages

Summary

POSIX allows implementation to return EISDIR when reading of directory is not allowed.
readdir() should be used instead.

PR: 246412

Test Plan

cat /

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31037
Build 28743: arc lint + arc unit

Event Timeline

delphij created this revision.May 12 2020, 2:50 AM

Herald added a reviewer: manpages. · View Herald TranscriptMay 12 2020, 2:50 AM

Herald added a subscriber: imp. · View Herald Transcript

delphij requested review of this revision.May 12 2020, 2:50 AM

Harbormaster completed remote builds in B31037: Diff 71671.May 12 2020, 2:50 AM

delphij added a reviewer: mckusick.May 12 2020, 4:14 AM

https://reviews.freebsd.org/D24596 is a superset of this changeset (except manual page change).

delphij mentioned this in D24596: vfs: add restrictions to read(2) of a directory.May 12 2020, 4:21 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

read.2

9 lines

sys/

kern/

vfs_vnops.c

2 lines

Diff 71671

View Options

lib/libc/sys/read.2