Do not overflow when calculating file system size.
ClosedPublic
Actions

Authored by delphij on Apr 28 2020, 3:30 AM.

Details

Reviewers

cem
emaste
kevlo

Commits

rS360428: Do not overflow when calculating file system size.

Summary

Reported by: Hyeongseok Kim <hyeongseok kim lge com>

Test Plan

truncate -s 128g test; newfs_msdos ./test; fsck_msdosfs ./test

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij requested review of this revision.Apr 28 2020, 3:30 AM

delphij created this revision.

Harbormaster completed remote builds in B30770: Diff 71092.Apr 28 2020, 3:30 AM

cem accepted this revision.Apr 28 2020, 3:54 AM

cem added inline comments.

sbin/fsck_msdosfs/check.c
135 ↗	(On Diff #71092)	I don’t think this condition serves any purpose?

This revision is now accepted and ready to land.Apr 28 2020, 3:54 AM

Address reviewer comment (unconditionally calculate badbytes).

This revision now requires review to proceed.Apr 28 2020, 4:10 AM

Harbormaster completed remote builds in B30771: Diff 71093.Apr 28 2020, 4:10 AM

Makes sense, I've updated the patch, could you please take another look?

Looks great, thanks!

This revision is now accepted and ready to land.Apr 28 2020, 5:08 AM

Closed by commit rS360428: Do not overflow when calculating file system size. (authored by delphij). · Explain WhyApr 28 2020, 5:10 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS360428: Do not overflow when calculating file system size..

Herald added a subscriber: imp. · View Herald TranscriptApr 28 2020, 5:10 AM

Revision Contents
Changeset List

Path

Size

head/

sbin/

fsck_msdosfs/

check.c

26 lines

Diff 71096

View Options

head/sbin/fsck_msdosfs/check.c

Do not overflow when calculating file system size.ClosedPublicActions