Page MenuHomeFreeBSD

Do not overflow when calculating file system size.
ClosedPublic

Authored by delphij on Apr 28 2020, 3:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 9:16 AM
Unknown Object (File)
Wed, Dec 11, 4:25 PM
Unknown Object (File)
Thu, Dec 5, 4:42 PM
Unknown Object (File)
Nov 23 2024, 2:23 AM
Unknown Object (File)
Nov 16 2024, 3:11 PM
Unknown Object (File)
Oct 18 2024, 10:43 AM
Unknown Object (File)
Oct 1 2024, 5:10 AM
Unknown Object (File)
Sep 25 2024, 8:53 AM
Subscribers

Details

Summary

Reported by: Hyeongseok Kim <hyeongseok kim lge com>

Test Plan

truncate -s 128g test; newfs_msdos ./test; fsck_msdosfs ./test

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30770
Build 28495: arc lint + arc unit

Event Timeline

delphij created this revision.
cem added inline comments.
sbin/fsck_msdosfs/check.c
135

I don’t think this condition serves any purpose?

This revision is now accepted and ready to land.Apr 28 2020, 3:54 AM

Address reviewer comment (unconditionally calculate badbytes).

This revision now requires review to proceed.Apr 28 2020, 4:10 AM

Makes sense, I've updated the patch, could you please take another look?

Looks great, thanks!

This revision is now accepted and ready to land.Apr 28 2020, 5:08 AM
This revision was automatically updated to reflect the committed changes.