You can check your man page change by running "mandoc -Tlint" to get some feedback about it.

Found two smaller issues.
As far as I can tell, this is as ready as it's going to be. If we find issues afterwards, we can fix those in the handbook, rather than putting more and more stuff into this review.

Looks good, thanks for documenting these!

Some sentences should be rewritten to avoid the use of "you". I've made a couple of suggestions towards this. There may be other instances (search for "you" and rewrite accordingly). This often results in the use of active voice (i.e. "Use FreeBSD" instead of "You could use FreeBSD") as a positive side effect.
No more content changes as far as I can tell.

Read to commit, nothing to complain about. Thanks!

Good to (literally) go!

The new additions are even better and are approved as well!

Good thing to have! Thanks!

OK from manpages.

Alright, nothing to complain about.

@ziaee Do you think we can commit this as part of your list of doc changes needed for pkgbase? It's a start and I'd rather have something in the handbook that we can commit extension to before we try to add more to an ever growing review. Any thoughts? Do we need more reviewers?

OK from manpages.

Looks good now, thank you!

A few minor textual suggestions.

I like it, nothing to complain as a first version. 👍

Good to go, thanks!

The man page looks good to me.

OK from manpages, good to go!

OK from manpages.

Thanks for the patch. It looks good to me. I'll commit it soon.

A few suggestions for conciseness. The text looks good so far, keep it up!

OK for the manpage part.

Thanks for documenting this.

Good to go!

Looks good and it reads better, too.

Looks good to me for the docs part of the change. 👍

Any updates? Maybe we can come up with some new EXAMPLES together?

Minor nit, missing : at end of sentence.

A few minor things, the rest looks fine.

Looks good to me. Don't forget to bump the document date.

Looks good!

I've found two small nits. The rest looks god enough to commit I would say. As mentioned by others, we can always fix other things found in a followup commit.

Looks good to me, even though people may say this is shameless self-advertising. ;-)

On @delphij's suggestion, I've changed a sentence below the SATA examples to use da in case of SCSI/SAS devices.

Show how to create the GPT partitions of type freebsd-zfs in the quickstart section first. Use the GPT partitions to create pools as well as all zpool status outputs.

Removed a sentence fragment which is no longer relevant since it deals with one of the old device names.

What's the state of this? Has it been resolved in HEAD or do we still have this problem where not all zpool mirror disks get the ESP boot code (only the first one)?

In D49757#1147902, @fernape wrote:

In D49757#1147818, @bcr wrote:

@fernape: Just to check, since you're a doceng member: was your approval made in your own name or as a doceng member (for the team)?
The latter would remove the blocker for this and we can go ahead. If the team needs more time, then let us know.
Thanks!

My approval was just from the doc technical point of view.
doceng@ had a discussion about this change and sent core@ an answer about this via the doceng@ liaison.

@fernape: Just to check, since you're a doceng member: was your approval made in your own name or as a doceng member (for the team)?
The latter would remove the blocker for this and we can go ahead. If the team needs more time, then let us know.
Thanks!

Looks good to me!

In D49038#1137547, @ziaee wrote:

Sorry I'm late, can/should we use the macro for current stable release?

Adding doceng@ for completeness sake, since the website is their domain. If core already approved, that's fine then. Just want to make sure everyone is involved.
I like the change as it is both benefitting us in learning a bit more about our visitors, while having privacy as a main focus.

Looks good to me. Approved!

This may be coming from the upstream vendor and may be fixed there already. When we import this third party software next time, we'll get this fix automatically. It is worth checking if it is fixed upstream. If not, they'll certainly appreciate a bug report.

Looks good to me, thanks!

OK for the man page part of the change.

Looks good, approved!

Other than that, it's OK to commit.

Checked up and good to go!

I'll take care of it. Thanks for the work!

OK for the man page change.

Man page looks good to me. The actual code has to be reviewed/accepted by someone else.

Looks good to me. I think we should try to use some automated link checker that reports when there is a broken link in our docs. But that's beside this review, so go ahead. Thank you for the work!

OK for the man page part of the change.

Some language and typo fixes.

Looks good to me.

Here's how you can "make" the doc tree:
https://docs.freebsd.org/en/books/fdp-primer/doc-build/

Small fixes, easy to implement..

Looks good to me.

Looks good to me, thanks!

yes, no more need for DocBook tools/validations since we moved to Asciidoc.

Ideally, this would list the browser used when testing. This is a quickly moving target as both browsers and meeting software evolve, we would need a couple more "works here" reports from users before we can make that claim in the handbook.

If you don't know any (or want to add) individual reviewers, you can use the reviewer groups you used.

Looks good, thanks for the submission.