Page MenuHomeFreeBSD
Differential D51706

libutil: Add numerous missing MLINKs
ClosedPublic
Actions

Authored by des on Aug 2 2025, 5:35 PM.
Tags
None
Referenced Files
F132261358: D51706.id159688.diff
Wed, Oct 15, 7:09 AM
Unknown Object (File)
Fri, Oct 10, 5:48 PM
Unknown Object (File)
Fri, Oct 10, 12:47 PM
Unknown Object (File)
Fri, Oct 10, 5:56 AM
Unknown Object (File)
Fri, Oct 10, 5:56 AM
Unknown Object (File)
Fri, Oct 10, 12:19 AM
Unknown Object (File)
Sun, Sep 21, 9:43 PM
Unknown Object (File)
Sat, Sep 20, 5:45 PM
View All 35 Files
Subscribers
bcr
imp
ziaee

Details

Reviewers
emaste
olce
imp
Group Reviewers
manpages
Commits
rGf0ee68d143e5: libutil: Add missing MLINKs
rGa64e03483190: libutil: Add missing MLINKs
rG22afc767869a: libutil: Add missing MLINKs
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Aug 2 2025, 5:35 PM
Herald added a reviewer: olce. · View Herald TranscriptAug 2 2025, 5:35 PM
Herald added subscribers: ziaee, imp. · View Herald Transcript
des requested review of this revision.Aug 2 2025, 5:35 PM
Harbormaster completed remote builds in B65928: Diff 159642.Aug 2 2025, 5:35 PM
des mentioned this in D51694: libutil: Add symbol versioning.Aug 2 2025, 5:45 PM
emaste added inline comments.Aug 2 2025, 9:10 PM
lib/libutil/Makefile
130

duplicate

emaste added a comment.Aug 2 2025, 9:10 PM

LGTM other than the duplicated line

des marked an inline comment as done.Aug 2 2025, 9:40 PM
des updated this revision to Diff 159660.Aug 2 2025, 9:40 PM

dedup

Harbormaster completed remote builds in B65933: Diff 159660.Aug 2 2025, 9:40 PM
imp accepted this revision.Aug 3 2025, 6:08 AM

Seems sane now

This revision is now accepted and ready to land.Aug 3 2025, 6:08 AM
bcr accepted this revision as: manpages.Aug 3 2025, 2:03 PM
bcr added a subscriber: bcr.

OK from manpages.

emaste accepted this revision.Aug 3 2025, 2:10 PM
olce accepted this revision.Aug 3 2025, 5:02 PM

Much more readable like that.

It seems the commit message needs amending though, as almost all mlinks were in fact in the original file. Is some diff missing?

des added a comment.Aug 3 2025, 5:30 PM
In D51706#1181249, @olce wrote:

It seems the commit message needs amending though, as almost all mlinks were in fact in the original file. Is some diff missing?

Nothing is missing. The patch reformats the Makefile and adds 9 MLINKs which were previously missing.

Closed by commit rG22afc767869a: libutil: Add missing MLINKs (authored by des). · Explain WhyAug 3 2025, 5:33 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG22afc767869a: libutil: Add missing MLINKs.
des added a commit: rGa64e03483190: libutil: Add missing MLINKs.Aug 14 2025, 4:05 PM
des added a commit: rGf0ee68d143e5: libutil: Add missing MLINKs.Aug 18 2025, 10:41 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
179 lines
1 line

Diff 159688

View Options

lib/libutil/Makefile

Loading...
View Options

lib/libutil/pw_util.3

Loading...