Improve several descriptions for loader tunables and add descriptions of the statistics provided by read only sysctl-variables.
Right now all aggregated interface level counters dev.vtnet.X.tx_task_rescheduled, dev.vtnet.X.tx_tso_offloaded, dev.vtnet.X.tx_csum_offloaded, dev.vtnet.X.rx_task_rescheduled, dev.vtnet.X.rx_csum_offloaded, and dev.vtnet.X.rx_csum_failed are always reported as zero. In addition, the interface level counter dev.vtnet.X.tx_defrag_failed will count more than expected. Fixes for these issues are under review in D51999.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Thanks for doing this!
share/man/man4/vtnet.4 | ||
---|---|---|
171 | Stupid style nit: This is equivalent (6 spaces) and preferred per style.mdoc(5) |
share/man/man4/vtnet.4 | ||
---|---|---|
171 | Doesn't that man page say:
Willing to change it, but the "xxxxxx" is used elsewhere in the man page. So I guess it is preferred to use the same pattern in the file? |
share/man/man4/vtnet.4 | ||
---|---|---|
171 | Same pattern in the file is good, sorry. I was thinking of the previous clause where we use the longest thing in between the quotes and not xxxx or nnnnn, which is harder to maintain because people don't want to count. |
share/man/man4/vtnet.4 | ||
---|---|---|
171 | All specifications of the width in this files are using "xxxxxx". So I keep it for consistency. |
share/man/man4/vtnet.4 | ||
---|---|---|
71–74 | Nit: most (if not all) other pages currently refer to this as transmit checksum offloading instead of transmission. |