Please check with mandoc -tlint pci.4 and igor -R pci.4 before commit. And update .Dd. And don't run with scissors.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 9 2016
Sep 7 2016
Sep 5 2016
There is no rule to avoid markup for the first word in a sentence. The only history of this was due to a buggy shell script that dealt with man pages and has not be used since Linuxdoc times a couple of decades ago.
Sep 4 2016
Sep 3 2016
Sep 2 2016
When committing, remember to note that it is a whitespace-only change in the commit message.
Thanks!
Aug 31 2016
Aug 30 2016
Aug 29 2016
Aug 27 2016
Aug 26 2016
Man page looks okay to me. Worth running igor -R bnxt.4 | less -RS and mandoc -Tlint bnxt4 on it, just in case. Please remember to update .Dd also. Thanks!
Missing that one "and", but otherwise looks good. Thanks!
Aug 25 2016
Aug 23 2016
Aug 20 2016
Aug 19 2016
Wow!
Aug 16 2016
Seems to work, but only lightly tested here.
Aug 12 2016
Aug 9 2016
Aug 6 2016
Looks okay to me (correcting a cut-and-paste error). Next time, a little bit of explanation in the Details section of the review would help to explain not just what is being done, but why.
Aug 5 2016
Only one last note: the section on minimum RAM and disk space says that 2 to 4 G of RAM is a starting point, but does not mention disk space.
In D1626#153838, @rmacklem wrote:I've copied these lines from ken@'s comment into the man page and it seems to read ok to me.
I added these lines after ...can exceed 100%.:This is because of the way busy percentages are calculated. The busy time is calculated by adding the elapsed time between the last time an operation started or finished, and the current time. If there is only one operation outstanding, the "busy time" time will get updated with the total time of that operation.
That means that the difference in the busy time between the two measurement intervals (often 1 second) will increase by more than the measurement interval.
Man page changes look good.
Jul 29 2016
Jul 25 2016
Jul 24 2016
A couple of other comments. Please adjust these, then I can download the entire man page source and see about setting up a table. The source for gpart.8 has some examples of these.
Remember to bump .Dd. Thanks!
Jul 23 2016
Markup looks fine, can't speak for the revision numbers, though.
Jul 21 2016
In D7261#151132, @emaste wrote:@wblock, should mdoc.7 be updated to remove the . from the example I pasted?
Jul 20 2016
Jul 19 2016
Please run textproc/igor on this man page, it helps to spot problems.
Jul 5 2016
Please wait on this. I have an idea that might work, but it will take a little while to implement and test.
Jul 4 2016
This does not build for me. There are errors in the translation of the version strings. In the original XML, these are $FreeBSD$, but in the PO file, it has been changed to $FreeBSD$. Subversion then changes these, and there are multiple translations of that string. These need to be $FreeBSD$ in both the source and translation.