It seems that people do not find the exp-run flag when opening a PR.
Details
Details
Diff Detail
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| en_US.ISO8859-1/articles/committers-guide/article.xml | ||
|---|---|---|
| 4877 ↗ | (On Diff #19276) | s/aswers/answers/ |
| en_US.ISO8859-1/articles/committers-guide/article.xml | ||
|---|---|---|
| 4828 ↗ | (On Diff #19276) | This sentence is a little awkward, maybe: What is the procedure to request an experimental build of the ports tree, also known as an 'exp-run'? |
| 4833 ↗ | (On Diff #19276) | s/requires/requests/ ? |
| 4837 ↗ | (On Diff #19276) | s/Full builds/A full package build/ |
| en_US.ISO8859-1/articles/committers-guide/article.xml | ||
|---|---|---|
| 4834 ↗ | (On Diff #19279) | &a.portmgr; prefers that an exp-run is performed before patches with a large impact to ports or the base system are committed. |
| 4838 ↗ | (On Diff #19279) | Please, not "you". <para>Full package builds will be done with the patches provided by the submitter, and the submitter is required to fix detected problems before commit.</para> |
| 4853 ↗ | (On Diff #19279) | No, please, no "you". Fill in the bug report as normal. |
| 4854 ↗ | (On Diff #19279) | Negative logic: if !(forget). Use positive logic: Remember to attach the patch. |
| 4861 ↗ | (On Diff #19279) | This is more confusing because it asks for the opposite of what is needed. Also, "you are good" is ...not good. Please remind me about this later when I have more energy. |
| 4865 ↗ | (On Diff #19279) | This assumes a certain page layout which might not always be that way. Can probably just say "Set the flags to..." |
| 4868 ↗ | (On Diff #19279) | No, please not "your" unless absolutely necessary. Hovering the mouse over any field shows more details. |
| 4877 ↗ | (On Diff #19279) | s/the &a.portmgr;/&a.portmgr/ (I think). s/answers back/replies/ |
| 4878 ↗ | (On Diff #19279) | "fallout" might not be clearly defined to the reader. |
| 4879 ↗ | (On Diff #19279) | Please, no "you" or "your" except when needed. The fallout might be a bug in the original patch or other ports that need to be fixed. Both need to be addressed. Update the patch to repair all the fallout and repeat. |
| 4828 ↗ | (On Diff #19276) | "What is the procedure" is still a bit redundant. Also, "test" is helpful to make the purpose clearer. How can an experimental test build of the ports tree (<emphasis>exp-run</emphasis>) be requested? |
| en_US.ISO8859-1/articles/committers-guide/article.xml | ||
|---|---|---|
| 4834 ↗ | (On Diff #19279) | Is this the polite way of saying "you have to" ? |
| 4838 ↗ | (On Diff #19279) | There are "you" and "your" all over the place here, it always was less formal than the rest of this article. |
| 4877 ↗ | (On Diff #19279) | Without "the" it reads: When Ports Management Team <portmgr@FreeBSD.org> replies,... |
| 4828 ↗ | (On Diff #19276) | It sounds better, most other questions start with "What ..." so I went with it :-) |
| en_US.ISO8859-1/articles/committers-guide/article.xml | ||
|---|---|---|
| 4834 ↗ | (On Diff #19279) | The polite way is "must", like An exp-run must be completed before patches with a significant ports impact are committed. |
| 4838 ↗ | (On Diff #19279) | Yes, but we should be working on that. It's not to make it more formal, it's to make the sentences more direct. |
| 4877 ↗ | (On Diff #19279) | Oops, sorry, thought it was a bare email address. Yes, it needs the "the". |