Page MenuHomeFreeBSD

Add a bit about how to ask for an exp-run.
ClosedPublic

Authored by mat on Aug 15 2016, 10:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 8:27 PM
Unknown Object (File)
Tue, Apr 30, 8:25 PM
Unknown Object (File)
Tue, Apr 30, 8:12 PM
Unknown Object (File)
Tue, Apr 30, 8:12 PM
Unknown Object (File)
Tue, Apr 30, 8:11 PM
Unknown Object (File)
Tue, Apr 30, 6:18 PM
Unknown Object (File)
Mar 4 2024, 2:40 PM
Unknown Object (File)
Dec 23 2023, 2:53 AM

Details

Summary

It seems that people do not find the exp-run flag when opening a PR.

Diff Detail

Event Timeline

mat retitled this revision from to Add a bit about how to ask for an exp-run..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: wblock.
mat added a subscriber: Doc Committers.
brd requested changes to this revision.Aug 15 2016, 11:26 AM
brd added a reviewer: brd.
brd added a subscriber: brd.
brd added inline comments.
en_US.ISO8859-1/articles/committers-guide/article.xml
4877

s/aswers/answers/

This revision now requires changes to proceed.Aug 15 2016, 11:26 AM
en_US.ISO8859-1/articles/committers-guide/article.xml
4828

This sentence is a little awkward, maybe:

What is the procedure to request an experimental build of the ports tree, also known as an 'exp-run'?

4833

s/requires/requests/ ?

4837

s/Full builds/A full package build/

mat marked 4 inline comments as done.Aug 15 2016, 11:37 AM
mat added inline comments.
en_US.ISO8859-1/articles/committers-guide/article.xml
4833

I don't know, I want it to be clear that it is not something that is optional :-)

4837

I kinda liked having it as a plural

mat edited edge metadata.
mat marked 2 inline comments as done.
  • Feedback from @brd.
en_US.ISO8859-1/articles/committers-guide/article.xml
4833

Sure, but it is optional... :)

4837

I was just thinking, a full build of what?

en_US.ISO8859-1/articles/committers-guide/article.xml
4833

And if you don't ask for it and break it, you'll get crucified :-p

4837

I changed it to "Full package builds"

brd edited edge metadata.
This revision is now accepted and ready to land.Aug 15 2016, 3:53 PM
en_US.ISO8859-1/articles/committers-guide/article.xml
4828

"What is the procedure" is still a bit redundant. Also, "test" is helpful to make the purpose clearer.

How can an experimental test build of the ports tree (<emphasis>exp-run</emphasis>) be requested?
4834
&a.portmgr; prefers that an exp-run is performed before patches with a large impact to ports or the base system are committed.
4838

Please, not "you".

<para>Full package builds will be done with the patches
provided by the submitter, and the submitter is required to fix detected
problems before commit.</para>
4853

No, please, no "you".

Fill in the bug report as normal.
4854

Negative logic: if !(forget). Use positive logic:

Remember to attach the patch.
4861

This is more confusing because it asks for the opposite of what is needed.

Also, "you are good" is ...not good.

Please remind me about this later when I have more energy.

4865

This assumes a certain page layout which might not always be that way. Can probably just say "Set the flags to..."

4868

No, please not "your" unless absolutely necessary.

Hovering the mouse over any field shows more details.
4877

s/the &a.portmgr;/&a.portmgr/ (I think).

s/answers back/replies/

4878

"fallout" might not be clearly defined to the reader.

4879

Please, no "you" or "your" except when needed.

The fallout might be a bug in the original patch or other ports that need to be fixed. 
Both need to be addressed.  Update the patch to repair all the fallout and repeat.
mat edited edge metadata.
mat marked 8 inline comments as done.
  • With wblock's comments.
This revision now requires review to proceed.Aug 16 2016, 11:46 AM
en_US.ISO8859-1/articles/committers-guide/article.xml
4828

It sounds better, most other questions start with "What ..." so I went with it :-)

4834

Is this the polite way of saying "you have to" ?

4838

There are "you" and "your" all over the place here, it always was less formal than the rest of this article.

4877

Without "the" it reads:

When Ports Management Team <portmgr@FreeBSD.org> replies,...
en_US.ISO8859-1/articles/committers-guide/article.xml
4834

The polite way is "must", like

An exp-run must be completed before patches with a significant ports impact are committed.
4838

Yes, but we should be working on that. It's not to make it more formal, it's to make the sentences more direct.

4877

Oops, sorry, thought it was a bare email address. Yes, it needs the "the".

This revision was automatically updated to reflect the committed changes.