Page MenuHomeFreeBSD

Add fdatasync(2) man page, combined with fsync(2).
ClosedPublic

Authored by kib on Aug 16 2016, 8:32 AM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib retitled this revision from to Add fdatasync(2) man page, combined with fsync(2)..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added a reviewer: emaste.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
lib/libc/sys/fsync.2
6 ↗(On Diff #19325)

s/was/were/

78–81 ↗(On Diff #19325)

Can we be more specific here, or at least avoid "appear"?

kib marked 2 inline comments as done.
kib edited edge metadata.

Notes by Ed.

wblock added inline comments.
lib/libc/sys/fsync.2
78 ↗(On Diff #19329)

Passive -> active:

If the file metadata has already been committed, using
81 ↗(On Diff #19329)

"for the same purpose" is a little unclear. How about

can be more efficient than
.Fn fsync .
95 ↗(On Diff #19329)

Either remove the "The" at the beginning of this sentence, or add a word before "fail" to say what they are:

"fsync and fdatasync fail if:"
or
"The fsync and fdatasync calls fail if:"

kib marked 3 inline comments as done.
kib edited edge metadata.

wblock changes

Other than the optional change I suggested for the '.Nd' line, this looks good to me.

lib/libc/sys/fsync.2
42 ↗(On Diff #19350)

"synchronize changes to a file's data, without or with it's metadata"

lib/libc/sys/fsync.2
42 ↗(On Diff #19350)

Wouldn't it clutter the tag line ? Some changes are synced, which are is described in the main text.

fdatasync(2) cannot be a default choice, it requires careful consideration if used.

emaste edited edge metadata.
emaste added inline comments.
lib/libc/sys/fsync.2
37 ↗(On Diff #19350)

Update

This revision is now accepted and ready to land.Aug 17 2016, 10:08 AM
This revision was automatically updated to reflect the committed changes.