share/man/man4/genet.4
19	Maybe add instructions for having loader(8) load it at boot time? These are common for other Ethernet interfaces, eg for re(4); Alternatively, to load the driver as a module at boot time, place the following line in loader.conf(5): if_re_load="YES"

• karels added inline comments.Dec 9 2021, 3:09 PM

share/man/man4/genet.4
19	That is not implemented in the driver.

Grammar and language look good to me.

Same here, can't find any grammar or other nits.

should work on all BCM2711xxx SOC-revisions, not only on the mentioned P4b(BCM2711B08)
while not specifically inspected I didn't notice any problem with the CM4(BCM2711C0)

Good point. I had more hardware information in the Description section originally, but moved it to Hardware. I'll try to come up with something more generic. I still want to mention the RPi 4, as that is the most common.

In D33360#754185, @karels wrote:

...mention the RPi 4, as that is the most common.

of course... e.g. removing the "B" should match, thanks.

Added copyright; touched up hardware info

Harbormaster completed remote builds in B43313: Diff 99944.Dec 13 2021, 5:35 PM

In D33360#755447, @karels wrote:

Added copyright; touched up hardware info

┈┈┈┈┈┈▕▔╲
┈┈┈┈┈┈┈▏▕
┈┈┈┈┈┈┈▏▕▂▂▂
▂▂▂▂▂▂╱┈▕▂▂▂▏
▉▉▉▉▉┈┈┈▕▂▂▂▏
▉▉▉▉▉┈┈┈▕▂▂▂▏
▔▔▔▔▔▔╲▂▕▂▂▂I

imp accepted this revision.Dec 13 2021, 8:06 PM

This revision is now accepted and ready to land.Dec 13 2021, 8:06 PM

ObAccessibility; in case anyone visits this (now or later) using a screenreader and is wondering, the ASCII art in maciphone2_googlemail.com's comment earlier is a thumb-up sign.

In D33360#755573, @pauamma_gundo.com wrote:

ObAccessibility; in case anyone visits this (now or later) using a screenreader and is wondering, the ASCII art in maciphone2_googlemail.com's comment earlier is a thumb-up sign.

👍

@pauamma_gundo.com wrote:

the ASCII art in comment earlier is a thumb-up sign.

Technically, it was not ASCII art, it was UTF-8 art (and not very good one).

In D33360#755717, @danfe wrote:

Technically, it was not ASCII art, it was UTF-8 art (and not very good one).

since not accepted as it landed I abandone that revision

Closed by commit rG6ccff5c0452c: Add genet.4 for RPi 4 Ethernet (authored by • karels). · Explain WhyDec 14 2021, 1:46 PM

This revision was automatically updated to reflect the committed changes.

• karels added a commit: rG6ccff5c0452c: Add genet.4 for RPi 4 Ethernet.

In D33360#755717, @danfe wrote:

@pauamma_gundo.com wrote:

the ASCII art in comment earlier is a thumb-up sign.

Technically, it was not ASCII art, it was UTF-8 art (and not very good one).

Psst. This is (well, was) a documentation review. Art reviews are ----> over that way.