Page MenuHomeFreeBSD
Differential D32058

llvm-readobj: Attach to buildsystem
ClosedPublic
Actions

Authored by me_cameronkatri.com on Sep 22 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 6:15 PM
Unknown Object (File)
Nov 5 2024, 8:33 PM
Unknown Object (File)
Nov 5 2024, 8:33 PM
Unknown Object (File)
Nov 5 2024, 8:32 PM
Unknown Object (File)
Oct 23 2024, 4:48 PM
Unknown Object (File)
Oct 23 2024, 4:48 PM
Unknown Object (File)
Oct 23 2024, 4:48 PM
Unknown Object (File)
Oct 23 2024, 4:48 PM
View All Files
Subscribers
arichardson
dim
emaste
imp
Contributor Reviews (src)

Details

Reviewers
dim
arichardson
Commits
rG98a049f22ef3: llvm-readobj: Attach to buildsystem
rGe52de8a91581: llvm-readobj: Attach to buildsystem
rG1b85b68da0b2: llvm-readobj: Attach to buildsystem

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42080
Build 38968: arc lint + arc unit

Event Timeline

me_cameronkatri.com created this revision.Sep 22 2021, 6:10 PM
Herald added a reviewer: manpages. · View Herald TranscriptSep 22 2021, 6:10 PM
Herald added subscribers: Contributor Reviews (src), imp, emaste. · View Herald Transcript
me_cameronkatri.com requested review of this revision.Sep 22 2021, 6:10 PM
Harbormaster completed remote builds in B41641: Diff 95511.Sep 22 2021, 6:10 PM
me_cameronkatri.com removed a reviewer: manpages.Sep 22 2021, 6:11 PM
me_cameronkatri.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
emaste added a subscriber: arichardson.Sep 22 2021, 6:56 PM
emaste added a subscriber: dim.

We should handle the llvm-strip man page as a separate change

me_cameronkatri.com updated this revision to Diff 95517.Sep 22 2021, 7:04 PM

Move llvm-strip manpage to D32061

Harbormaster completed remote builds in B41644: Diff 95517.Sep 22 2021, 7:04 PM
me_cameronkatri.com edited the summary of this revision. (Show Details)Sep 22 2021, 7:06 PM
me_cameronkatri.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dim added a comment.Sep 22 2021, 7:09 PM

Hm, one thing is missing: why do we need this tool? :) Last time I looked it was a tool specifically for llvm's regression tests. Do we really want to build this unconditionally?

me_cameronkatri.com added a comment.Sep 22 2021, 7:14 PM
In D32058#723538, @dim wrote:

Hm, one thing is missing: why do we need this tool? :) Last time I looked it was a tool specifically for llvm's regression tests. Do we really want to build this unconditionally?

readelf is just a symlink to readobj, so in order to have a full llvm binutils instead of elftoolchain with WITH_LLVM_BINUTILS we need llvm-readelf.

dim accepted this revision.Sep 22 2021, 7:24 PM
In D32058#723540, @me_cameronkatri.com wrote:

readelf is just a symlink to readobj, so in order to have a full llvm binutils instead of elftoolchain with WITH_LLVM_BINUTILS we need llvm-readelf.

Ah, I wasn't aware that we were replacing elftoolchain's readelf here. But in that case, it should be OK, I guess. For now, WITH_LLVM_BINUTILS isn't defaulted on, right?

This revision is now accepted and ready to land.Sep 22 2021, 7:24 PM
me_cameronkatri.com added a comment.EditedSep 22 2021, 7:31 PM
In D32058#723551, @dim wrote:
In D32058#723540, @me_cameronkatri.com wrote:

readelf is just a symlink to readobj, so in order to have a full llvm binutils instead of elftoolchain with WITH_LLVM_BINUTILS we need llvm-readelf.

Ah, I wasn't aware that we were replacing elftoolchain's readelf here. But in that case, it should be OK, I guess. For now, WITH_LLVM_BINUTILS isn't defaulted on, right?

Well it will be built and installed as llvm-readobj and llvm-readelf, just like llvm-ar, but if WITH_LLVM_BINUTILS is set then readobj and readelf links will be setup.

me_cameronkatri.com updated this revision to Diff 96712.Oct 11 2021, 11:28 PM

Rebase after 88c027338f18

This revision now requires review to proceed.Oct 11 2021, 11:28 PM
Harbormaster completed remote builds in B42080: Diff 96712.Oct 11 2021, 11:29 PM
me_cameronkatri.com updated this revision to Diff 96713.Oct 11 2021, 11:30 PM

Rebase after 88c027338f18

Harbormaster completed remote builds in B42081: Diff 96713.Oct 11 2021, 11:30 PM
arichardson accepted this revision.Oct 12 2021, 7:23 AM

Other than my minor comment this LGTM.

usr.bin/clang/llvm-readobj/Makefile
25

I don't think we need a readobj symlink. Just llvm-readobj+llvm-readelf (and readelf with MK_LLVM_BINUTILS should be enough.

I'm also not entirely sure whether we need to install as llvm-readobj since the GNU output format is the only stable one.

This revision is now accepted and ready to land.Oct 12 2021, 7:23 AM
Closed by commit rG1b85b68da0b2: llvm-readobj: Attach to buildsystem (authored by me_cameronkatri.com, committed by arichardson). · Explain WhyOct 14 2021, 4:20 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG1b85b68da0b2: llvm-readobj: Attach to buildsystem.
me_cameronkatri.com added a comment.Oct 14 2021, 4:30 PM

Thank you!

dim added a commit: rGe52de8a91581: llvm-readobj: Attach to buildsystem.Dec 6 2021, 4:33 PM
dim added a commit: rG98a049f22ef3: llvm-readobj: Attach to buildsystem.Dec 25 2021, 11:58 AM

Revision Contents
Changeset List

PathSize
lib/
clang/
libllvm/
21 lines
tools/
build/
mk/
4 lines
usr.bin/
clang/
1 line
llvm-readobj/
32 lines
272 lines
403 lines

Diff 96712

View Options

lib/clang/libllvm/Makefile

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

usr.bin/clang/Makefile

Loading...
View Options

usr.bin/clang/llvm-readobj/Makefile

Loading...
View Options

usr.bin/clang/llvm-readobj/llvm-readelf.1

Loading...
View Options

usr.bin/clang/llvm-readobj/llvm-readobj.1

Loading...