bhyve: Support setting the disk serial number for VirtIO block devices.
ClosedPublic
Actions

Authored by jhb on Sep 16 2021, 1:57 PM.

Details

Reviewers

chuck
allanjude

Group Reviewers

manpages
bhyve

Commits

rG5f6c2bd03bc3: bhyve: Support setting the disk serial number for VirtIO block devices.
rGc6efcb1281f3: bhyve: Support setting the disk serial number for VirtIO block devices.

Summary

Obtained from: illumos

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 16 2021, 1:57 PM

Herald added a reviewer: manpages. · View Herald TranscriptSep 16 2021, 1:58 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

Harbormaster completed remote builds in B41541: Diff 95250.Sep 16 2021, 1:58 PM

jhb requested review of this revision.Sep 16 2021, 1:58 PM

OK from manpages.

@chuck, would you be able to test this easily?

Whoops, sorry, this isn't NVMe. :)

Since the "serial" taken from the configuration is directly copied to become the virtio-blk device's ident, should we call this "ident" simply? Looks good to me otherwise.

EDIT: I missed the fact that it was obtained from Illumos.

I think the goal was to also be similar to the name used for the AHCI and NVMe device models which both use "ser" for this.

Reviewed By: allanjude

This revision is now accepted and ready to land.Sep 16 2021, 6:57 PM

In D31983#721639, @jhb wrote:

I think the goal was to also be similar to the name used for the AHCI and NVMe device models which both use "ser" for this.

Right - it was added as ser to match the others. Accepting the alternative of serial is there because that's what some illumos distributions had before the configuration management refactoring.

Closed by commit rGc6efcb1281f3: bhyve: Support setting the disk serial number for VirtIO block devices. (authored by jhb). · Explain WhySep 17 2021, 4:56 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc6efcb1281f3: bhyve: Support setting the disk serial number for VirtIO block devices..

Apologies for getting to this late, but I tested this with ser, serial, and with no options. Seemed to work as expected

jhb added a commit: rG5f6c2bd03bc3: bhyve: Support setting the disk serial number for VirtIO block devices..Nov 23 2021, 11:13 PM