Page MenuHomeFreeBSD
Differential D31991

minidump: Use provided msgbuf pointer
ClosedPublic
Actions

Authored by mhorne on Sep 16 2021, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 12:08 AM
Unknown Object (File)
Fri, Aug 7, 10:10 AM
Unknown Object (File)
Fri, Aug 7, 6:09 AM
Unknown Object (File)
Thu, Aug 6, 12:55 PM
Unknown Object (File)
Thu, Aug 6, 8:17 AM
Unknown Object (File)
Wed, Aug 5, 6:17 AM
Unknown Object (File)
Wed, Jul 22, 12:36 AM
Unknown Object (File)
Tue, Jul 21, 6:28 PM
View All Files
Subscribers
allanjude
andrew
emaste
imp
jhibbits

Details

Reviewers
manu
markj
kib
jhb
stevek
Commits
rG069d7fa63b21: minidump: Use provided msgbuf pointer
rG1d2d1418b492: minidump: Use provided msgbuf pointer
Summary

Don't assume we are dumping the global message buffer, but use the one
provided by the minidumpstate argument.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41549
Build 38438: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 16 2021, 6:40 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 16 2021, 6:40 PM
Herald added subscribers: Contributor Reviews (src), jhibbits, emaste and 2 others. · View Herald Transcript
mhorne requested review of this revision.Sep 16 2021, 6:40 PM
Harbormaster completed remote builds in B41549: Diff 95262.Sep 16 2021, 6:40 PM
mhorne added a parent revision: D31990: minidump: reduce the amount direct accesses to page tables.Sep 16 2021, 6:40 PM
mhorne added a child revision: D31992: minidump: Use the provided dump bitset.
mhorne added reviewers: markj, kib, jhb, stevek.Sep 16 2021, 6:43 PM
mhorne added a parent revision: D31989: minidump: Parameterize minidumpsys().
mhorne edited subscribers, added: allanjude; removed: Contributor Reviews (src).
mhorne added a child revision: D31993: Allow minidumps to be performed on the live system.Sep 16 2021, 6:45 PM
markj accepted this revision.Sep 16 2021, 6:56 PM
markj added inline comments.
sys/amd64/amd64/minidump_machdep.c
305

While here, the casts to (char *) can be dropped.

This revision is now accepted and ready to land.Sep 16 2021, 6:56 PM
jhb accepted this revision.Sep 16 2021, 7:50 PM
Closed by commit rG1d2d1418b492: minidump: Use provided msgbuf pointer (authored by mhorne). · Explain WhyNov 19 2021, 7:07 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG1d2d1418b492: minidump: Use provided msgbuf pointer.
mhorne added a commit: rG069d7fa63b21: minidump: Use provided msgbuf pointer.Dec 3 2021, 2:54 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
9 lines
arm/
arm/
10 lines
arm64/
arm64/
10 lines
i386/
i386/
9 lines
mips/
mips/
10 lines
powerpc/
powerpc/
12 lines
riscv/
riscv/
10 lines

Diff 95262

View Options

sys/amd64/amd64/minidump_machdep.c

Loading...
View Options

sys/arm/arm/minidump_machdep.c

Loading...
View Options

sys/arm64/arm64/minidump_machdep.c

Loading...
View Options

sys/i386/i386/minidump_machdep_base.c

Loading...
View Options

sys/mips/mips/minidump_machdep.c

Loading...
View Options

sys/powerpc/powerpc/minidump_machdep.c

Loading...
View Options

sys/riscv/riscv/minidump_machdep.c

Loading...