Page MenuHomeFreeBSD
Differential D31406

sdhci: add sysctls to dump sdhci registers and capabilites
ClosedPublic
Actions

Authored by bag_semihalf.com on Aug 4 2021, 8:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 10:34 AM
Unknown Object (File)
Sat, Jul 4, 10:21 AM
Unknown Object (File)
Sat, Jul 4, 8:28 AM
Unknown Object (File)
Wed, Jul 1, 7:59 AM
Unknown Object (File)
Wed, Jul 1, 1:50 AM
Unknown Object (File)
Sun, Jun 28, 3:54 PM
Unknown Object (File)
Fri, Jun 26, 12:44 PM
Unknown Object (File)
Thu, Jun 18, 3:56 PM
View All Files
Subscribers
ar_semihalf.com
dgr_semihalf.com
kd

Details

Reviewers
mw
mmel
manu
Commits
rGd00c1f7f2f4a: sdhci: add sysctls to dump sdhci registers and capabilites
Summary

Add sysctls dev.sdhci.X.slotY.dumpregs and dev.sdhci.X.slotY.dumpcaps
which dumps sdhci registers or capabilities.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bag_semihalf.com requested review of this revision.Aug 4 2021, 8:11 AM
bag_semihalf.com created this revision.
bag_semihalf.com updated this revision to Diff 93435.Aug 9 2021, 9:08 AM
mw accepted this revision.Aug 13 2021, 3:14 PM

LGTM + tested on MacchiatoBin/CN913x-DB/CN913x-CEx7-Evaluation board

This revision is now accepted and ready to land.Aug 13 2021, 3:14 PM
ar_semihalf.com added a subscriber: ar_semihalf.com.Aug 16 2021, 11:55 AM

How about moving those sysctls under a dev.sdhci.X.slotY.debug parent node? This way we can add more debug tunables in the future.

bag_semihalf.com updated this revision to Diff 93862.Aug 18 2021, 8:25 AM
This revision now requires review to proceed.Aug 18 2021, 8:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 13 2021, 8:02 AM
Closed by commit rGd00c1f7f2f4a: sdhci: add sysctls to dump sdhci registers and capabilites (authored by bag_semihalf.com, committed by wma). · Explain Why
This revision was automatically updated to reflect the committed changes.
wma added a commit: rGd00c1f7f2f4a: sdhci: add sysctls to dump sdhci registers and capabilites.

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
219 lines

Diff 93435

View Options

sys/dev/sdhci/sdhci.c

Loading...