Page MenuHomeFreeBSD
Differential D30309

md5: Create md5sum, etc compatible programs
ClosedPublic
Actions

Authored by imp on May 17 2021, 5:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 8:10 PM
Unknown Object (File)
Sun, Apr 21, 8:10 PM
Unknown Object (File)
Sun, Apr 21, 8:10 PM
Unknown Object (File)
Sun, Apr 21, 8:10 PM
Unknown Object (File)
Sun, Apr 21, 8:10 PM
Unknown Object (File)
Sun, Apr 21, 8:10 PM
Unknown Object (File)
Sat, Apr 20, 5:37 AM
Unknown Object (File)
Feb 9 2024, 11:11 PM
View All 61 Files
Subscribers
0mp
bcr
darius-dons.net.au
kp
sef

Details

Reviewers
emaste
allanjude
phk
arichardson
cem
sef
kp
Group Reviewers
manpages
Commits
rG5f13ee9179e1: md5: Create md5sum, etc compatible programs
rGc0d5665be0dc: md5: Create md5sum, etc compatible programs
rG086feed850c3: md5: Create md5sum, etc compatible programs
Summary

On Linux, there's a similar set of programs to ours, but that end in the
letters 'sum'. These act basically like FreeBSD versions run with the -r
option. Add code so that when the program ends in 'sum' you get the
linux -r behavior. This is enough to make most things that use sha*sum
work correctly (the -c / --check options, as well as the long args
are not implemented).

Relnotes: yes
Sponsored by: Netflix

Test Plan

Note: I've not implemented all the flags of *sum, but this is enough to make qemu's test suite
happier with FreeBSD and it's not the first time I've hit this issue.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39243
Build 36132: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 17 2021, 5:08 AM
imp created this revision.
Harbormaster completed remote builds in B39234: Diff 89328.May 17 2021, 5:08 AM
imp added reviewers: emaste, allanjude, phk, arichardson, cem.May 17 2021, 5:10 AM
imp edited the test plan for this revision. (Show Details)May 17 2021, 5:14 AM
imp edited the summary of this revision. (Show Details)May 17 2021, 5:20 AM
sef accepted this revision.May 17 2021, 5:30 AM
sef added a subscriber: sef.

lgtm.

This revision is now accepted and ready to land.May 17 2021, 5:30 AM
darius-dons.net.au added a subscriber: darius-dons.net.au.May 17 2021, 6:00 AM

I think there should be some updates to the man page to note the links and that they are for (limited) Linux compatibility.

sbin/md5/md5.c
187

A comment about why this is done would be good.

imp updated this revision to Diff 89346.May 17 2021, 1:05 PM

man page update and comment

This revision now requires review to proceed.May 17 2021, 1:05 PM
Herald added a reviewer: manpages. · View Herald TranscriptMay 17 2021, 1:05 PM
Harbormaster completed remote builds in B39243: Diff 89346.May 17 2021, 1:06 PM
imp marked an inline comment as done.May 17 2021, 1:07 PM
allanjude accepted this revision.May 17 2021, 1:08 PM

Reviewed By: allanjude

This revision is now accepted and ready to land.May 17 2021, 1:08 PM
bcr accepted this revision as: manpages.May 17 2021, 1:36 PM
bcr added a subscriber: bcr.

Manpages is also fine with the change. Thanks!

kp accepted this revision.May 17 2021, 1:40 PM
kp added a subscriber: kp.
kp added inline comments.
sbin/md5/md5.c
191

s/proide/provide/

0mp added a subscriber: 0mp.May 17 2021, 2:21 PM

Does it mean that FreeBSD *sum versions of those utilities are going to support all the existing FreeBSD flags? Shouldn't we restrict the flags of the *sum utilities to only those that provide the same functionality both on FreeBSD and on GNU?

emaste added a comment.May 17 2021, 2:49 PM

Shouldn't we restrict the flags of the *sum utilities to only those that provide the same functionality both on FreeBSD and on GNU?

Not a bad idea, we can introduce *sum flags intentionally, as necessary.

imp added a comment.May 17 2021, 3:12 PM
In D30309#680792, @emaste wrote:

Shouldn't we restrict the flags of the *sum utilities to only those that provide the same functionality both on FreeBSD and on GNU?

Not a bad idea, we can introduce *sum flags intentionally, as necessary.

I think the best bet is to flag the -c use in this mode because they are different. We could also accept-b and -t as nops too easily enough. Any extensions from there, though, I don't think we should prohibit.

imp updated this revision to Diff 89364.May 17 2021, 5:29 PM

Better compatibility with gnu versions from coreutils. Note this
in man page.

This revision now requires review to proceed.May 17 2021, 5:29 PM
Harbormaster completed remote builds in B39250: Diff 89364.May 17 2021, 5:29 PM
imp updated this revision to Diff 89365.May 17 2021, 5:35 PM

Tweak wording, and provide sha1sum for consistency.

Harbormaster completed remote builds in B39251: Diff 89365.May 17 2021, 5:35 PM
imp added inline comments.May 17 2021, 5:37 PM
sbin/md5/md5.c
365

this is a trivial trailing whitespace thing emacs decided to fix... Normally, I'd split it out, but it's trivial enough to be flexible on the style / substance division we normally do)

imp marked an inline comment as done.May 18 2021, 3:42 AM
sef accepted this revision.May 18 2021, 3:45 AM
sef added inline comments.
sbin/md5/md5.1
96

Traditional English convention is "-sum" not "*sum". Not worth changing unless a) you agree, and b) have other changes to make.

This revision is now accepted and ready to land.May 18 2021, 3:45 AM
Closed by commit rG086feed850c3: md5: Create md5sum, etc compatible programs (authored by imp). · Explain WhyMay 19 2021, 5:44 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG086feed850c3: md5: Create md5sum, etc compatible programs.
se added a commit: rGc0d5665be0dc: md5: Create md5sum, etc compatible programs.Jun 28 2021, 4:05 PM
se added a commit: rG5f13ee9179e1: md5: Create md5sum, etc compatible programs.Jul 6 2021, 3:39 PM

Revision Contents
Changeset List

PathSize
sbin/
md5/
28 lines
20 lines
16 lines

Diff 89346

View Options

sbin/md5/Makefile

Loading...
View Options

sbin/md5/md5.1

Loading...
View Options

sbin/md5/md5.c

Loading...