Differential D30135

sglist: Add sglist_append_single_mbuf().
ClosedPublic
Actions

Authored by jhb on May 5 2021, 9:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 13, 11:53 AM

	Unknown Object (File)
	Sun, May 12, 7:22 AM

	Unknown Object (File)
	Sun, May 12, 7:22 AM

	Unknown Object (File)
	Sun, May 12, 7:19 AM

	Unknown Object (File)
	Thu, May 9, 9:44 AM

	Unknown Object (File)
	Thu, May 2, 2:53 AM

	Unknown Object (File)
	Apr 25 2024, 12:54 AM

	Unknown Object (File)
	Apr 18 2024, 4:24 PM

View All 44 Files

Subscribers

Details

Reviewers

markj
gallatin

Group Reviewers

Commits

rG60b9ce724518: sglist: Add sglist_append_single_mbuf().
rG6663f8a23e7c: sglist: Add sglist_append_single_mbuf().

Summary

This function appends the contents of a single mbuf to an sglist
rather than an entire mbuf chain.

Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39040
Build 35929: arc lint + arc unit

Event Timeline

jhb created this revision.May 5 2021, 9:30 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 5 2021, 9:30 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.May 5 2021, 9:30 PM

Harbormaster completed remote builds in B39040: Diff 88710.May 5 2021, 9:30 PM

jhb added a parent revision: D30134: Support unmapped mbufs in crypto buffers..May 5 2021, 9:30 PM

jhb added a child revision: D30136: crypto: Add a new type of crypto buffer for a single mbuf..

markj accepted this revision.May 6 2021, 2:18 PM

This revision is now accepted and ready to land.May 6 2021, 2:18 PM

I kind of wish "sglist_append_mbuf" was the "single" version and there was a separate name for the "append a mbuf chain" variant, but that ship has sailed I think.

In D30135#676970, @jhb wrote:

I kind of wish "sglist_append_mbuf" was the "single" version and there was a separate name for the "append a mbuf chain" variant, but that ship has sailed I think.

Yeah I had the same thought while reading these diffs.

gallatin accepted this revision.May 7 2021, 2:00 PM

Closed by commit rG6663f8a23e7c: sglist: Add sglist_append_single_mbuf(). (authored by jhb). · Explain WhyMay 26 2021, 12:00 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6663f8a23e7c: sglist: Add sglist_append_single_mbuf()..

jhb added a commit: rG60b9ce724518: sglist: Add sglist_append_single_mbuf()..Oct 21 2021, 5:08 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

1 line

10 lines

sys/

kern/

15 lines

sys/

1 line

Diff 88710

share/man/man9/Makefile

Loading...

share/man/man9/sglist.9

Loading...

sys/kern/subr_sglist.c

Loading...

sys/sys/sglist.h

Loading...