MFC after: 3 days
Details
Details
- Reviewers
bnovkov alc royger kib markj - Group Reviewers
manpages - Commits
- rG3ae682909950: uio.9: Document uiomove_fromphys()
rG076e44839160: uio.9: Document uiomove_fromphys()
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| share/man/man9/uio.9 | ||
|---|---|---|
| 165 | I don't think this is fully accurate. uiomove_fromphys() is implemented on i386 that lacks a directmap using sf_bufs. I think whether the underlying implementation uses the direct map or transient mappings is not relevant in the context of the man page. | |
| share/man/man9/uio.9 | ||
|---|---|---|
| 165 | Exactly, the point of uiomove_fromphys() is to provide machine-independent helper to copy to/from memory in the physical address space. | |
| 169 | Described how? You should explain somehow that array provides the locations that form the place to target the copying. I do not know how to formulate it concise but understandable. | |
| share/man/man9/uio.9 | ||
|---|---|---|
| 169 | Maybe use: "The source physical address are provided in the ma[] parameter."? I'm not a native speaker, so others might have better suggestions. | |
| share/man/man9/uio.9 | ||
|---|---|---|
| 169 | 'adresses' then, each page in the ma[] array provides the page-sized chunk of the phys space. It is not necessary contiguous. | |
| share/man/man9/uio.9 | ||
|---|---|---|
| 169 | Ops, yes, sorry, that was a typo on my end. | |
Comment Actions
- Remove implementation notes where I unnecessarily documented that uiomove_fromphys is MD.
- Fix the description of the offset arg. The offset does not have to be within the first page of tha array.
Comment Actions
I'm going to wait a while before pushing this upstream to let other reviewers chime in.
Thanks kib!