Page MenuHomeFreeBSD

uio.9: Document uiomove_fromphys()
Needs ReviewPublic

Authored by 0mp on Thu, Dec 4, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 25, 5:26 AM
Unknown Object (File)
Fri, Dec 19, 9:34 PM
Unknown Object (File)
Fri, Dec 19, 2:56 AM
Unknown Object (File)
Wed, Dec 10, 8:51 PM
Unknown Object (File)
Wed, Dec 10, 1:17 PM
Unknown Object (File)
Tue, Dec 9, 2:22 PM
Unknown Object (File)
Fri, Dec 5, 2:52 AM
Unknown Object (File)
Thu, Dec 4, 9:45 PM
Subscribers

Details

Reviewers
bnovkov
alc
royger
kib
markj
Group Reviewers
manpages
Summary

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69042
Build 65925: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Thu, Dec 4, 3:12 PM
share/man/man9/uio.9
165

I don't think this is fully accurate. uiomove_fromphys() is implemented on i386 that lacks a directmap using sf_bufs. I think whether the underlying implementation uses the direct map or transient mappings is not relevant in the context of the man page.

share/man/man9/uio.9
165

Exactly, the point of uiomove_fromphys() is to provide machine-independent helper to copy to/from memory in the physical address space.

169

Described how? You should explain somehow that array provides the locations that form the place to target the copying. I do not know how to formulate it concise but understandable.

share/man/man9/uio.9
169

Maybe use: "The source physical address are provided in the ma[] parameter."? I'm not a native speaker, so others might have better suggestions.

share/man/man9/uio.9
169

'adresses' then, each page in the ma[] array provides the page-sized chunk of the phys space. It is not necessary contiguous.

share/man/man9/uio.9
169

Ops, yes, sorry, that was a typo on my end.