Page MenuHomeFreeBSD

Only build security/ktls_isa-l_crypto-kmod on FreeBSD 13.
ClosedPublic

Authored by jhb on May 15 2021, 6:16 PM.

Details

Summary

FreeBSD 14 and later will only use in-kernel crypto drivers for
software KTLS. The security/isal-kmod port provides an in-kernel
crypto driver using the same ISA-L crypto library as this port.

Sponsored by: Netflix

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.May 15 2021, 6:16 PM

Seems ok, though I don't know the ports framework well enough to say that this is the correct way to check.

This revision is now accepted and ready to land.May 16 2021, 5:04 PM
sbz added inline comments.
security/ktls_isa-l_crypto-kmod/Makefile
35

We tend to use OSVERSION (integer) instead of OSREL (string) across the port tree to test for version requirements. You can the definition here cf. OSVERSION

imp added inline comments.
security/ktls_isa-l_crypto-kmod/Makefile
35

Doesn't this need to be

.if ${OSVERSION} >= 1300000 && ${OSVERSION} < 1400000

?

security/ktls_isa-l_crypto-kmod/Makefile
35

Yes if it's only for 13.x, I don't have the full context here. I wanted just to report the use of OSVERSION instead.

security/ktls_isa-l_crypto-kmod/Makefile
35

Ah, I had patterned this on the existing IGNORE functionality which uses OSREL:

https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.port.mk#L163

What I really need is a 'ONLY_FOR_${OPSYS}_${OSREL:R}' type functionality, but we don't have that, only the inverse (IGNORE_${OPSYS}_${OSREL:R}). It is somewhat confusing to use OSREL when working with major versions (as this chunk here is and as all the BROKEN_* and IGNORE_* helpers do) and OSVERSION at other times. In this case, I don't have a specific range of OSVERSION values to check for, but I guess can add another bump for just this port (it's the only one that cares).

This revision now requires review to proceed.May 26 2021, 12:16 AM
This revision is now accepted and ready to land.May 27 2021, 12:00 AM