Only build security/ktls_isa-l_crypto-kmod on FreeBSD 13.
ClosedPublic
Actions

Authored by jhb on May 15 2021, 6:16 PM.

Details

Reviewers

gallatin
markj
sbz

Commits

R11:d5e302a28d9a: security/ktls_isa-l_crypto-kmod: Only build on FreeBSD 13.

Summary

FreeBSD 14 and later will only use in-kernel crypto drivers for
software KTLS. The security/isal-kmod port provides an in-kernel
crypto driver using the same ISA-L crypto library as this port.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 39208
Build 36097: arc lint + arc unit

Event Timeline

jhb created this revision.May 15 2021, 6:16 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 15 2021, 6:16 PM

jhb requested review of this revision.May 15 2021, 6:16 PM

Harbormaster completed remote builds in B39208: Diff 89269.May 15 2021, 6:16 PM

jhb added a child revision: D30138: Assume OCF is the only KTLS software backend..May 15 2021, 6:16 PM

Seems ok, though I don't know the ports framework well enough to say that this is the correct way to check.

This revision is now accepted and ready to land.May 16 2021, 5:04 PM

gallatin accepted this revision.May 17 2021, 2:18 PM

sbz added a subscriber: sbz.May 25 2021, 8:35 PM

sbz added inline comments.

security/ktls_isa-l_crypto-kmod/Makefile
36	We tend to use `OSVERSION` (integer) instead of `OSREL` (string) across the port tree to test for version requirements. You can the definition here cf. OSVERSION

imp added a subscriber: imp.May 25 2021, 8:40 PM

imp added inline comments.

security/ktls_isa-l_crypto-kmod/Makefile
36	Doesn't this need to be .if ${OSVERSION} >= 1300000 && ${OSVERSION} < 1400000 ?

sbz added inline comments.May 25 2021, 8:54 PM

security/ktls_isa-l_crypto-kmod/Makefile
36	Yes if it's only for 13.x, I don't have the full context here. I wanted just to report the use of `OSVERSION` instead.

jhb added inline comments.May 25 2021, 10:57 PM

security/ktls_isa-l_crypto-kmod/Makefile
36	Ah, I had patterned this on the existing IGNORE functionality which uses OSREL: https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.port.mk#L163 What I really need is a 'ONLY_FOR_${OPSYS}_${OSREL:R}' type functionality, but we don't have that, only the inverse (IGNORE_${OPSYS}_${OSREL:R}). It is somewhat confusing to use OSREL when working with major versions (as this chunk here is and as all the BROKEN_* and IGNORE_* helpers do) and OSVERSION at other times. In this case, I don't have a specific range of OSVERSION values to check for, but I guess can add another bump for just this port (it's the only one that cares).