FreeBSD 14 and later will only use in-kernel crypto drivers for
software KTLS. The security/isal-kmod port provides an in-kernel
crypto driver using the same ISA-L crypto library as this port.
Sponsored by: Netflix
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 39457 Build 36346: arc lint + arc unit
Event Timeline
Comment Actions
Seems ok, though I don't know the ports framework well enough to say that this is the correct way to check.
| security/ktls_isa-l_crypto-kmod/Makefile | ||
|---|---|---|
| 36 | Doesn't this need to be .if ${OSVERSION} >= 1300000 && ${OSVERSION} < 1400000? | |
| security/ktls_isa-l_crypto-kmod/Makefile | ||
|---|---|---|
| 36 | Yes if it's only for 13.x, I don't have the full context here. I wanted just to report the use of OSVERSION instead. | |
| security/ktls_isa-l_crypto-kmod/Makefile | ||
|---|---|---|
| 36 | Ah, I had patterned this on the existing IGNORE functionality which uses OSREL: https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.port.mk#L163 What I really need is a 'ONLY_FOR_${OPSYS}_${OSREL:R}' type functionality, but we don't have that, only the inverse (IGNORE_${OPSYS}_${OSREL:R}). It is somewhat confusing to use OSREL when working with major versions (as this chunk here is and as all the BROKEN_* and IGNORE_* helpers do) and OSVERSION at other times. In this case, I don't have a specific range of OSVERSION values to check for, but I guess can add another bump for just this port (it's the only one that cares). | |